Remove stream forwarder and pass direct from db to kinesis

Author: nhsd-david-wass

infrastructure/terraform/components/api/README.md

@@ -47,7 +47,6 @@ No requirements.
 | <a name="module_letter_status_updates_queue"></a> [letter\_status\_updates\_queue](#module\_letter\_status\_updates\_queue) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-sqs.zip | n/a |
 | <a name="module_letter_updates_transformer"></a> [letter\_updates\_transformer](#module\_letter\_updates\_transformer) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
 | <a name="module_logging_bucket"></a> [logging\_bucket](#module\_logging\_bucket) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-s3bucket.zip | n/a |
-| <a name="module_mi_stream_forwarder"></a> [mi\_stream\_forwarder](#module\_mi\_stream\_forwarder) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
 | <a name="module_mi_updates_transformer"></a> [mi\_updates\_transformer](#module\_mi\_updates\_transformer) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
 | <a name="module_patch_letter"></a> [patch\_letter](#module\_patch\_letter) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip | n/a |
 | <a name="module_post_letters"></a> [post\_letters](#module\_post\_letters) | https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.24/terraform-lambda.zip | n/a |

infrastructure/terraform/components/api/event_source_mapping_mi_updates.tf

@@ -1,15 +1,3 @@
-resource "aws_lambda_event_source_mapping" "mi_stream_forwarder_dynamodb" {
-  event_source_arn                     = aws_dynamodb_table.mi.stream_arn
-  function_name                        = module.mi_stream_forwarder.function_arn
-  starting_position                    = "TRIM_HORIZON"
-  batch_size                           = 10
-  maximum_batching_window_in_seconds   = 1
-
-  depends_on = [
-    module.mi_stream_forwarder       # ensures stream forwarder exists
-  ]
-}
-
 resource "aws_lambda_event_source_mapping" "mi_updates_transformer_kinesis" {
   event_source_arn                     = aws_kinesis_stream.mi_change_stream.arn
   function_name                        = module.mi_updates_transformer.function_arn

infrastructure/terraform/components/api/kinesis_mi_change_stream.tf

@@ -3,3 +3,9 @@ resource "aws_kinesis_stream" "mi_change_stream" {
   shard_count      = 1
   retention_period = 24
 }
+
+resource "aws_dynamodb_kinesis_streaming_destination" "mi_streaming_destination" {
+  stream_arn                               = aws_kinesis_stream.mi_change_stream.arn
+  table_name                               = aws_dynamodb_table.mi.name
+  approximate_creation_date_time_precision = "MILLISECOND"
+}