Add peer review suggestions

Author: francisco-videira-nhs

infrastructure/terraform/components/api/module_lambda_get_letters.tf

@@ -60,10 +60,8 @@ data "aws_iam_policy_document" "get_letters_lambda" {
     effect = "Allow"
 
     actions = [
-      "dynamodb:BatchGetItem",
       "dynamodb:GetItem",
-      "dynamodb:Query",
-      "dynamodb:Scan",
+      "dynamodb:Query"
     ]
 
     resources = [

lambdas/api-handler/src/config/deps.ts

@@ -5,8 +5,6 @@ import pino from 'pino';
 import { LetterRepository } from '../../../../internal/datastore';
 import { lambdaEnv, LambdaEnv } from "../config/env";
 
-const BASE_TEN = 10;
-
 let singletonDeps: Deps | null = null;
 
 export type Deps = {
@@ -21,7 +19,7 @@ function createLetterRepository(log: pino.Logger, lambdaEnv: LambdaEnv): LetterR
   const docClient = DynamoDBDocumentClient.from(ddbClient);
   const config = {
     lettersTableName: lambdaEnv.LETTERS_TABLE_NAME,
-    ttlHours: Number.parseInt(lambdaEnv.LETTER_TTL_HOURS, BASE_TEN),
+    ttlHours: Number.parseInt(lambdaEnv.LETTER_TTL_HOURS)
   };
 
   return new LetterRepository(docClient, log, config);

lambdas/api-handler/src/config/env.ts

@@ -14,9 +14,9 @@ export const lambdaEnv: LambdaEnv = {
   DOWNLOAD_URL_TTL_SECONDS: getEnv('DOWNLOAD_URL_TTL_SECONDS')!
 };
 
-function getEnv(name: string, required = true): string | undefined {
+function getEnv(name: string): string {
   const value = process.env[name];
-  if (!value && required) {
+  if (!value) {
     throw new Error(`Missing required env var: ${name}`);
   }
   return value;