CCM-11602: limit can't be 0, return maxLimit value

Author: masl2

lambdas/api-handler/src/handlers/__tests__/get-letters.test.ts

@@ -123,6 +123,21 @@ describe('API Lambda handler', () => {
     });
   });
 
+  it("returns 400 if the limit parameter is zero", async () => {
+    const event = makeApiGwEvent({
+      path: "/letters",
+      queryStringParameters: { limit: "0" },
+    });
+    const context = mockDeep<Context>();
+    const callback = jest.fn();
+    const result = await getLetters(event, context, callback);
+
+    expect(result).toEqual({
+      statusCode: 400,
+      body: "Invalid Request: limit parameter must be a positive number not greater than 2500",
+    });
+  });
+
   it("returns 400 if the limit parameter is out of range", async () => {
     const event = makeApiGwEvent({
       path: "/letters",

lambdas/api-handler/src/handlers/get-letters.ts

@@ -67,14 +67,14 @@ export const getLetters: APIGatewayProxyHandler = async (event) => {
       limitNumber = maxLimit;
     }
 
-    if (limitNumber < 0 || limitNumber > maxLimit) {
+    if (limitNumber <= 0 || limitNumber > maxLimit) {
       log.info({
         description: "Limit value is invalid",
         limitNumber,
       });
       return {
         statusCode: 400,
-        body: "Invalid Request: limit parameter must be a positive number not greater than 2500",
+        body: `Invalid Request: limit parameter must be a positive number not greater than ${maxLimit}`,
       };
     }