Fix linting config

Author: m-houston

eslint.config.mjs

@@ -12,7 +12,7 @@ import unicorn from 'eslint-plugin-unicorn';
 import { defineConfig, globalIgnores } from 'eslint/config';
 import js from '@eslint/js';
 import html from 'eslint-plugin-html';
-import tseslint from '@typescript-eslint/parser';
+import tseslint from 'typescript-eslint'; // Replace plugin-only import with meta package that includes configs
 import sortDestructureKeys from 'eslint-plugin-sort-destructure-keys';
 import {
   configs as airbnbConfigs,
@@ -40,9 +40,15 @@ export default defineConfig([
     '**/test-results',
     '**/playwright-report*',
     'eslint.config.mjs',
+    // newly ignored generated/build artifacts
+    'build/**',
+    'sdk/**',
+    'docs/_site/**',
+    'docs/vendor/**',
+    'docs/**/*.html',
   ]),
 
-  //imports
+  // imports
   importX.flatConfigs.recommended,
   { rules: { ...airbnbPlugins.importX.rules } },
 
@@ -66,21 +72,16 @@ export default defineConfig([
       },
     },
   },
-
-  {
-    files: ['**/*.json'],
-    extends: [tseslint.configs.disableTypeChecked],
-  },
+  { files: ['**/*.json'], extends: [tseslint.configs.disableTypeChecked] },
 
   {
     settings: {
       'import-x/resolver-next': [
         eslintImportResolverTypescript.createTypeScriptImportResolver({
           project: [
-            'frontend/tsconfig.json',
             'lambdas/*/tsconfig.json',
             'tests/test-team/tsconfig.json',
-            'utils/*/tsconfig.json',
+            'internal/*/tsconfig.json',
           ],
         }),
       ],
@@ -91,10 +92,7 @@ export default defineConfig([
     rules: {
       '@typescript-eslint/no-unused-vars': [
         2,
-        {
-          argsIgnorePattern: '^_',
-          varsIgnorePattern: '^_',
-        },
+        { argsIgnorePattern: '^_', varsIgnorePattern: '^_' },
       ],
       '@typescript-eslint/consistent-type-definitions': 0,
     },
@@ -107,22 +105,13 @@ export default defineConfig([
       'unicorn/prevent-abbreviations': 0,
       'unicorn/filename-case': [
         2,
-        {
-          case: 'kebabCase',
-          ignore: ['.tsx'],
-        },
+        { case: 'kebabCase', ignore: ['.tsx'] },
       ],
       'unicorn/no-null': 0,
       'unicorn/prefer-module': 0,
       'unicorn/import-style': [
         2,
-        {
-          styles: {
-            path: {
-              named: true,
-            },
-          },
-        },
+        { styles: { path: { named: true } } },
       ],
     },
   },
@@ -145,103 +134,54 @@ export default defineConfig([
   // jsxA11y
   {
     files: ['**/*.{js,mjs,cjs,jsx,mjsx,ts,tsx,mtsx}'],
-    plugins: {
-      'jsx-a11y': jsxA11y,
-    },
-    languageOptions: {
-      parserOptions: {
-        ecmaFeatures: {
-          jsx: true,
-        },
-      },
-    },
+    plugins: { 'jsx-a11y': jsxA11y },
+    languageOptions: { parserOptions: { ecmaFeatures: { jsx: true } } },
   },
 
   // security
   security.configs.recommended,
-
   // sonar
   sonarjs.configs.recommended,
-
   // html
-  {
-    files: ['**/*.html'],
-    plugins: { html },
-  },
-
-  // Next.js
-  ...compat.config({
-    extends: ['next', 'next/core-web-vitals', 'next/typescript'],
-    settings: {
-      next: {
-        rootDir: 'frontend',
-      },
-    },
-    rules: {
-      // needed because next lint rules look for a pages directory
-      '@next/next/no-html-link-for-pages': 0,
-    },
-  }),
+  { files: ['**/*.html'], plugins: { html } },
 
   // json
-  {
-    files: ['**/*.json'],
-    ...json.configs['recommended'],
-  },
+  { files: ['**/*.json'], ...json.configs['recommended'] },
 
   // destructure sorting
   {
     name: 'eslint-plugin-sort-destructure-keys',
-    plugins: {
-      'sort-destructure-keys': sortDestructureKeys,
-    },
-    rules: {
-      'sort-destructure-keys/sort-destructure-keys': 2,
-    },
+    plugins: { 'sort-destructure-keys': sortDestructureKeys },
+    rules: { 'sort-destructure-keys/sort-destructure-keys': 2 },
   },
 
   // imports
   {
     rules: {
-      'sort-imports': [
-        2,
-        {
-          ignoreDeclarationSort: true,
-        },
-      ],
+      'sort-imports': [2, { ignoreDeclarationSort: true }],
       'import-x/extensions': 0,
     },
   },
   {
     files: ['**/*.ts', '**/*.tsx'],
-    rules: {
-      'import-x/no-unresolved': 0, // trust the typescript compiler to catch unresolved imports
-    },
+    rules: { 'import-x/no-unresolved': 0 },
   },
   {
     files: ['tests/test-team/**'],
     rules: {
       'import-x/no-extraneous-dependencies': [
         2,
-        {
-          devDependencies: true,
-        },
+        { devDependencies: true },
       ],
     },
   },
   {
     files: ['**/utils/**', 'tests/test-team/**'],
-    rules: {
-      'import-x/prefer-default-export': 0,
-    },
+    rules: { 'import-x/prefer-default-export': 0 },
   },
   {
-    plugins: {
-      'no-relative-import-paths': noRelativeImportPaths,
-    },
-    rules: {
-      'no-relative-import-paths/no-relative-import-paths': 2,
-    },
+    plugins: { 'no-relative-import-paths': noRelativeImportPaths },
+    rules: { 'no-relative-import-paths/no-relative-import-paths': 2 },
   },
   {
     files: ['scripts/**'],
@@ -253,14 +193,44 @@ export default defineConfig([
     },
   },
 
+  // js parserOptions override to suppress project service warnings for loose JS files
+  {
+    files: ['**/*.js', '**/*.cjs', '**/*.mjs'],
+    languageOptions: {
+      parserOptions: {
+        allowDefaultProject: true,
+        noWarnOnMultipleProjects: true, // suppress informational warning
+      },
+    },
+  },
+  // tests: relax package import restriction
+  {
+    files: ['**/__test__/**', '**/__tests__/**', '**/*.test.ts', '**/*.test.js'],
+    rules: {
+      'import-x/no-relative-packages': 0,
+      'security/detect-non-literal-fs-filename': 0
+    },
+  },
+
+  // CLI tools
+  {
+    files: ['**/cli/**'],
+    rules: {
+      'no-console': 0,
+      'security/detect-non-literal-fs-filename': 0
+    },
+  },
+
   // misc rule overrides
   {
     rules: {
       'no-restricted-syntax': 0,
       'no-underscore-dangle': 0,
       'no-await-in-loop': 0,
       'no-plusplus': [2, { allowForLoopAfterthoughts: true }],
-      'unicorn/prefer-top-level-await': 0, // top level await is not available in commonjs
+      'unicorn/prefer-top-level-await': 0,
+      'import-x/no-relative-packages': 1,
+      'no-relative-import-paths/no-relative-import-paths': 1
     },
   },
 ]);

internal/events/src/cli/bundle-asyncapi.ts

@@ -5,13 +5,10 @@ import { version as packageVersion } from "../../package.json";
 
 async function main() {
   const baseDir = path.resolve(process.cwd(), "..");
-  const document = await bundle(
-    ["events/schemas/supplier-api.yaml"],
-    {
-      baseDir,
-      xOrigin: true,
-    },
-  );
+  const document = await bundle(["events/schemas/supplier-api.yaml"], {
+    baseDir,
+    xOrigin: true,
+  });
   const info = document.json()?.info;
   if (info) {
     info.version = packageVersion;

internal/events/src/cli/generate-json.ts

@@ -1,10 +1,10 @@
 import { z } from "zod";
 import * as fs from "node:fs";
 import { $Letter } from "../domain/letter";
-import {$LetterEvent, letterEventMap} from "../events/letter-events";
+import { $LetterEvent, letterEventMap } from "../events/letter-events";
 
 for (const [key, schema] of Object.entries({
-  "letter": $Letter,
+  letter: $Letter,
 })) {
   const json = z.toJSONSchema(schema, {
     io: "input",