Added dummy responses in for every API method so the csharp generated code is correct.

Author: RossBugginsNHS

.devcontainer/devcontainer.json

@@ -9,6 +9,7 @@
     },
     "vscode": {
       "extensions": [
+        "ms-dotnettools.csdevkit",
         "42crunch.vscode-openapi",
         "alefragnani.bookmarks",
         "AmazonWebServices.aws-toolkit-vscode",
@@ -82,6 +83,11 @@
       "moby": true,
       "version": "latest"
     },
+    "ghcr.io/devcontainers/features/dotnet:2": {
+      "aspNetCoreRuntimeVersions": "8.0",
+      "dotnetRuntimeVersions": "8.0",
+      "version": "8.0"
+    },
     "ghcr.io/devcontainers/features/go:1": {},
     "ghcr.io/devcontainers/features/node:1": {},
     "ghcr.io/devcontainers/features/python:1": {},

project.code-workspace

@@ -89,6 +89,7 @@
   },
   "extensions": {
     "recommendations": [
+  "ms-dotnettools.csdevkit",
   "42crunch.vscode-openapi",
   "alefragnani.bookmarks",
   "AmazonWebServices.aws-toolkit-vscode",

sdk/generate-cs.sh

@@ -1,25 +1,41 @@
 #!/bin/sh
 # run this from directory above, or with npm run generate:ts from parent directory.
 
-mkdir -p sdk/csharp
-
-VERSION="$(cat .version)"
-echo $VERSION
-
-set -x
-docker run \
---rm \
---user $(id -u) \
- -v ${PWD}:/local \
- -e VERSION="$VERSION" \
- openapitools/openapi-generator-cli \
- generate \
- -i /local/specification/api/notify-supplier.yml \
- -g csharp \
- --additional-properties="packageName=nhsnotifysupplier,packageVersion=$VERSION,licenseId=MIT,targetFramework=net8.0" \
- -o /local/sdk/csharp \
- --skip-validate-spec
-set +x
+
+generate () {
+  set -x
+  docker run \
+  --rm \
+  --user $(id -u) \
+  -v ${PWD}:/local \
+  -e VERSION="$VERSION" \
+  openapitools/openapi-generator-cli \
+  generate \
+  -i /local/specification/api/notify-supplier.yml \
+  -g csharp \
+  --additional-properties="packageName=nhsnotifysupplier,packageVersion=$SHORT_VERSION,licenseId=MIT,targetFramework=net8.0" \
+  -o /local/sdk/csharp \
+  --skip-validate-spec
+  set +x
+}
+
+build () {
+  dotnet build sdk/csharp/src/nhsnotifysupplier
+}
+
+prepare(){
+  mkdir -p sdk/csharp
+
+  VERSION="$(cat .version)"
+  echo $VERSION
+
+  SHORT_VERSION="$(echo $VERSION | rev | cut -d"." -f2-  | rev)"
+  echo $SHORT_VERSION
+}
+
+prepare
+generate
+build
 
 # sed -i -e 's|https://github.com/GIT_USER_ID/GIT_REPO_ID.git|https://github.com/NHSDigital/nhs-notify-supplier-api.git|g'  ./sdk/typescript/package.json
 

specification/api/notify-supplier.yml

@@ -194,6 +194,9 @@ paths:
       operationId: postLetter
       tags:
         - letter
+      responses:
+        '200':
+          description: TODO Make a response OK
     get:
       summary: Get a list of letters
       operationId: getAListOfLetters
@@ -202,6 +205,9 @@ paths:
       parameters:
         - $ref: '#/components/parameters/status'
       description: The key use of this endpoint is to query letters which have been cancelled using the `status=CANCELLED` query
+      responses:
+        '200':
+          description: TODO Make a response OK
   '/letter/{id}':
     parameters:
       - $ref: '#/components/parameters/requestId'
@@ -278,11 +284,17 @@ paths:
       operationId: list-mi
       tags:
         - mi
+      responses:
+        '200':
+          description: TODO Make a response OK
     post:
       summary: Create a new MI record
       operationId: create-mi
       tags:
         - mi
+      responses:
+        '200':
+          description: TODO Make a response OK
   '/mi/{id}':
     parameters:
       - $ref: '#/components/parameters/requestId'
@@ -293,6 +305,9 @@ paths:
       operationId: get-mi
       tags:
         - mi
+      responses:
+        '200':
+          description: TODO Make a response OK
   /whitemail:
     parameters:
       - $ref: '#/components/parameters/requestId'
@@ -304,13 +319,19 @@ paths:
         - whitemail
       x-stoplight:
         id: tpzuuj1eovmtc
+      responses:
+        '200':
+          description: TODO Make a response OK
     post:
       summary: Create a new whitemail letter batch
       operationId: create-whitemail
       tags:
         - whitemail
       x-stoplight:
         id: wun7ud7savffm
+      responses:
+        '200':
+          description: TODO Make a response OK
   '/whitemail/{id}':
     parameters:
       - $ref: '#/components/parameters/requestId'
@@ -323,6 +344,9 @@ paths:
         - whitemail
       x-stoplight:
         id: lmbg85kro8iwy
+      responses:
+        '200':
+          description: TODO Make a response OK
   /data:
     parameters:
       - $ref: '#/components/parameters/requestId'
@@ -332,6 +356,10 @@ paths:
       operationId: post-data
       tags:
         - data
+      responses:
+        '200':
+          description: Created OK
+
   '/data/{id}':
     parameters:
       - schema:
@@ -382,7 +410,10 @@ paths:
       summary: Fetch data file metadata
       tags:
         - data
-      responses: {}
+      responses:
+        '200':
+          description: Todo
+
       operationId: head-data-id
       x-stoplight:
         id: tdjs72iaaavub