review changes

Author: nhsd-david-wass

lambdas/mi-updates-transformer/package.json

@@ -1,6 +1,6 @@
 {
   "dependencies": {
-    "@aws-sdk/client-sns": "^3.940.0",
+    "@aws-sdk/client-sns": "^3.954.0",
     "@aws-sdk/util-dynamodb": "^3.943.0",
     "@internal/datastore": "^0.1.0",
     "@nhsdigital/nhs-notify-event-schemas-supplier-api": "*",

lambdas/mi-updates-transformer/src/__tests__/mi-updates-transformer.test.ts

@@ -109,6 +109,19 @@ describe("mi-updates-transformer Lambda", () => {
     );
   });
 
+  it("does not publish invalid MI data", async () => {
+    const handler = createHandler(mockedDeps);
+    const miEvent = { id: String(1232) } as MI; // missing required fields
+
+    const insertMI = generateInsertRecord(miEvent);
+    const testData = generateKinesisEvent([insertMI]);
+    await expect(
+      handler(testData, mockDeep<Context>(), jest.fn()),
+    ).rejects.toThrow();
+
+    expect(mockedDeps.snsClient.send).not.toHaveBeenCalled();
+  });
+
   it("batches mutiple records into a single call to SNS", async () => {
     const handler = createHandler(mockedDeps);
     const miEvents = generateMIEvents(10);