Skip to content

Commit d1e5da3

Browse files
Fix tests and tf
1 parent 95bc137 commit d1e5da3

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

infrastructure/terraform/components/api/module_lambda_get_letter_data.tf

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,9 @@ data "aws_iam_policy_document" "get_letter_data_lambda" {
7272

7373
statement {
7474
sid = "S3GetObjectForPresign"
75-
actions = ["s3:GetObject"]
75+
actions = [
76+
"s3:GetObject",
77+
"s3:ListBucket"] # allows 404 response instead of 403 if object missing
7678
resources = ["${module.s3bucket_test_letters.arn}/*"]
7779
}
7880
}
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
import * as handlers from "../index";
2+
jest.mock('../config/lambda-config', () => ({
3+
lambdaConfig: {
4+
SUPPLIER_ID_HEADER: 'nhsd-supplier-id',
5+
APIM_CORRELATION_HEADER: 'nhsd-correlation-id'
6+
}
7+
}));
8+
9+
it("exports", () => {
10+
expect(handlers.getLetters).toBeDefined();
11+
expect(handlers.patchLetter).toBeDefined();
12+
expect(handlers.getLetterData).toBeDefined();
13+
});

0 commit comments

Comments
 (0)