Skip to content

Commit d2f6147

Browse files
remove all references to 'DESTROYED' status
1 parent 7a88aa5 commit d2f6147

File tree

7 files changed

+7
-10
lines changed

7 files changed

+7
-10
lines changed

docs/assets/diagrams/types.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
## Data Store Schemas
1+
# Data Store Schemas
22

33
This document contains the mermaid diagrams for the data store schemas used in the application.
44

@@ -10,7 +10,7 @@ The schemas are generated from Zod definitions and provide a visual representati
1010
erDiagram
1111
Letter {
1212
string id
13-
string status "enum: PENDING, ACCEPTED, REJECTED, PRINTED, ENCLOSED, CANCELLED, DISPATCHED, FAILED, RETURNED, DESTROYED, FORWARDED, DELIVERED"
13+
string status "enum: PENDING, ACCEPTED, REJECTED, PRINTED, ENCLOSED, CANCELLED, DISPATCHED, FAILED, RETURNED, FORWARDED, DELIVERED"
1414
string specificationId
1515
string groupId
1616
number reasonCode

docs/collections/_consumers/integration.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ The mandatory statuses are: **ACCEPTED**, **REJECTED**, **FORWARDED**, **DISPATC
105105
- **CANCELLED:** The letter was cancelled following a request from the NHS Notify team
106106

107107
**Optional statuses** - additional, non-mandatory updates that can provide greater operational insight.
108-
The optional statuses are: **PRINTED**, **ENCLOSED**, **DELIVERED**, and **DESTROYED**.
108+
The optional statuses are: **PRINTED**, **ENCLOSED**, and **DELIVERED**.
109109
These can be used if your internal workflow supports more granular reporting.
110110

111111
- **PRINTED:** The letter has been printed.

internal/datastore/src/types.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ The schemas are generated from Zod definitions and provide a visual representati
1010
erDiagram
1111
Letter {
1212
string id
13-
string status "enum: PENDING, ACCEPTED, REJECTED, PRINTED, ENCLOSED, CANCELLED, DISPATCHED, FAILED, RETURNED, DESTROYED, FORWARDED, DELIVERED"
13+
string status "enum: PENDING, ACCEPTED, REJECTED, PRINTED, ENCLOSED, CANCELLED, DISPATCHED, FAILED, RETURNED, FORWARDED, DELIVERED"
1414
string specificationId
1515
string groupId
1616
number reasonCode

internal/datastore/src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export type Supplier = z.infer<typeof SupplierSchema>;
1515
export const LetterStatus = z.enum([
1616
'PENDING', 'ACCEPTED', 'REJECTED', 'PRINTED',
1717
'ENCLOSED', 'CANCELLED', 'DISPATCHED', 'FAILED',
18-
'RETURNED', 'DESTROYED', 'FORWARDED', 'DELIVERED']);
18+
'RETURNED', 'FORWARDED', 'DELIVERED']);
1919

2020
export type LetterStatusType = z.infer<typeof LetterStatus>;
2121

lambdas/api-handler/src/contracts/letters.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ export const LetterStatusSchema = z.enum([
2121
'DISPATCHED',
2222
'FAILED',
2323
'RETURNED',
24-
'DESTROYED',
2524
'FORWARDED',
2625
'DELIVERED'
2726
]);

scripts/test-data/src/cli/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ async function main() {
5454
"DISPATCHED",
5555
"FAILED",
5656
"RETURNED",
57-
"DESTROYED",
5857
"FORWARDED",
5958
"DELIVERED",
6059
],
@@ -132,7 +131,6 @@ async function main() {
132131
"DISPATCHED",
133132
"FAILED",
134133
"RETURNED",
135-
"DESTROYED",
136134
"FORWARDED",
137135
"DELIVERED",
138136
],

tests/sandbox/testCases/updateLetterStatus_testCases.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,10 +112,10 @@ export const apiSandboxUpdateLetterStatusTestData: ApiSandboxUpdateLetterStatusT
112112
},
113113
expectedStatus: 400,
114114
expectedResponse: {
115-
message: 'request.body.data.attributes.status should be equal to one of the allowed values: PENDING, ACCEPTED, REJECTED, PRINTED, ENCLOSED, CANCELLED, DISPATCHED, DELIVERED, FAILED, RETURNED, DESTROYED, FORWARDED',
115+
message: 'request.body.data.attributes.status should be equal to one of the allowed values: PENDING, ACCEPTED, REJECTED, PRINTED, ENCLOSED, CANCELLED, DISPATCHED, DELIVERED, FAILED, RETURNED, FORWARDED',
116116
errors: [{
117117
path: '.body.data.attributes.status',
118-
message: 'should be equal to one of the allowed values: PENDING, ACCEPTED, REJECTED, PRINTED, ENCLOSED, CANCELLED, DISPATCHED, DELIVERED, FAILED, RETURNED, DESTROYED, FORWARDED',
118+
message: 'should be equal to one of the allowed values: PENDING, ACCEPTED, REJECTED, PRINTED, ENCLOSED, CANCELLED, DISPATCHED, DELIVERED, FAILED, RETURNED, FORWARDED',
119119
errorCode: 'enum.openapi.validation'
120120
}]
121121
},

0 commit comments

Comments
 (0)