Skip to content

Commit d6e80aa

Browse files
Add latest version event schema letter rendering
1 parent 2715285 commit d6e80aa

File tree

4 files changed

+28
-24
lines changed

4 files changed

+28
-24
lines changed

lambdas/upsert-letter/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"@aws-sdk/client-dynamodb": "^3.858.0",
44
"@aws-sdk/lib-dynamodb": "^3.858.0",
55
"@internal/datastore": "*",
6-
"@nhsdigital/nhs-notify-event-schemas-letter-rendering": "^1.1.5",
6+
"@nhsdigital/nhs-notify-event-schemas-letter-rendering": "^2.0.0",
77
"@types/aws-lambda": "^8.10.148",
88
"aws-lambda": "^1.0.7",
99
"esbuild": "^0.24.0",

lambdas/upsert-letter/src/handler/__tests__/upsert-handler.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import { SNSMessage, SQSEvent } from "aws-lambda";
22
import pino from "pino";
33
import { LetterRepository } from "internal/datastore/src";
4-
import { LetterRequestPreparedEvent } from "@nhsdigital/nhs-notify-event-schemas-letter-rendering";
4+
import { LetterRequestPreparedEventV2 } from "@nhsdigital/nhs-notify-event-schemas-letter-rendering";
55
import createUpsertLetterHandler from "../upsert-handler";
66
import { Deps } from "../../config/deps";
77
import { EnvVars } from "../../config/env";
88

99
function createNotification(
10-
event: LetterRequestPreparedEvent,
10+
event: LetterRequestPreparedEventV2,
1111
): Partial<SNSMessage> {
1212
return {
1313
SignatureVersion: "",
@@ -27,7 +27,7 @@ function createNotification(
2727

2828
function createValidEvent(
2929
overrides: Partial<any> = {},
30-
): LetterRequestPreparedEvent {
30+
): LetterRequestPreparedEventV2 {
3131
// minimal valid event matching the prepared letter schema
3232
const now = new Date().toISOString();
3333

@@ -36,11 +36,11 @@ function createValidEvent(
3636
id: overrides.id ?? "7b9a03ca-342a-4150-b56b-989109c45613",
3737
source: "/data-plane/letter-rendering/test",
3838
subject: "client/client1/letter-request/letterRequest1",
39-
type: "uk.nhs.notify.letter-rendering.letter-request.prepared.v1",
39+
type: "uk.nhs.notify.letter-rendering.letter-request.prepared.v2",
4040
time: now,
4141
dataschema:
42-
"https://notify.nhs.uk/cloudevents/schemas/letter-rendering/letter-request.prepared.1.0.0.schema.json",
43-
dataschemaversion: "1.0.0",
42+
"https://notify.nhs.uk/cloudevents/schemas/letter-rendering/letter-request.prepared.2.0.0.schema.json",
43+
dataschemaversion: "2.0.0",
4444
data: {
4545
domainId: overrides.domainId ?? "letter1",
4646
letterVariantId: overrides.letterVariantId ?? "lv1",

lambdas/upsert-letter/src/handler/upsert-handler.ts

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,21 @@
1-
import { SQSBatchItemFailure, SQSEvent, SQSHandler, SNSMessage } from "aws-lambda";
1+
import {
2+
SNSMessage,
3+
SQSBatchItemFailure,
4+
SQSEvent,
5+
SQSHandler,
6+
} from "aws-lambda";
27
import { UpsertLetter } from "@internal/datastore";
38
import {
4-
$LetterRequestPreparedEvent,
5-
LetterRequestPreparedEvent,
9+
$LetterRequestPreparedEventV2,
10+
LetterRequestPreparedEventV2,
611
} from "@nhsdigital/nhs-notify-event-schemas-letter-rendering";
712
import { ZodError } from "zod";
813
import { Deps } from "../config/deps";
9-
import { no } from "zod/v4/locales";
1014

1115
type SupplierSpec = { supplierId: string; specId: string };
1216

1317
function mapToUpsertLetter(
14-
upsertRequest: LetterRequestPreparedEvent,
18+
upsertRequest: LetterRequestPreparedEventV2,
1519
supplier: string,
1620
spec: string,
1721
): UpsertLetter {
@@ -52,8 +56,8 @@ export default function createUpsertLetterHandler(deps: Deps): SQSHandler {
5256
);
5357
}
5458

55-
const upsertRequest: LetterRequestPreparedEvent =
56-
$LetterRequestPreparedEvent.parse(JSON.parse(notification.Message));
59+
const upsertRequest: LetterRequestPreparedEventV2 =
60+
$LetterRequestPreparedEventV2.parse(JSON.parse(notification.Message));
5761

5862
const supplierSpec: SupplierSpec = resolveSupplierForVariant(
5963
upsertRequest.data.letterVariantId,

package-lock.json

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)