CCM-11192: fix for main merge

Author: masl2

internal/datastore/src/__test__/letter-repository.test.ts

@@ -306,6 +306,21 @@ describe('LetterRepository', () => {
     await checkLetterExists('supplier1', 'letter59');
   });
 
+  test('should skip array gaps', async () => {
+    const letters = [
+      createLetter('supplier1', 'letter1'),
+      createLetter('supplier1', 'letter2'),
+      createLetter('supplier1', 'letter3')
+    ];
+
+    delete letters[1];
+
+    await letterRepository.putLetterBatch(letters);
+
+    await checkLetterExists('supplier1', 'letter1');
+    await checkLetterExists('supplier1', 'letter3');
+  });
+
   test('rethrows errors from DynamoDB when batch creating letter', async () => {
     const misconfiguredRepository = new LetterRepository(db.docClient, logger, {
       ...db.config,

internal/datastore/src/letter-repository.ts

@@ -53,12 +53,19 @@ export class LetterRepository {
     return LetterSchema.parse(letterDb);
   }
 
-  async putLetterBatch(letters: Omit<Letter, 'ttl' | 'supplierStatus'>[]): Promise<void> {
+  async putLetterBatch(letters: Omit<Letter, 'ttl' | 'supplierStatus'| 'supplierStatusSk'>[]): Promise<void> {
     let lettersDb: Letter[] = [];
     for (let i = 0; i < letters.length; i++) {
+
+      const letter = letters[i];
+
+      if(!letter){
+        continue;
+      }
+
       lettersDb.push({
-        ...letters[i],
-        supplierStatus: `${letters[i].supplierId}#${letters[i].status}`,
+        ...letter,
+        supplierStatus: `${letter.supplierId}#${letter.status}`,
         supplierStatusSk: Date.now().toString(),
         ttl: Math.floor(Date.now() / 1000 + 60 * 60 * this.config.ttlHours)
       });