Terraform fixes

Author: stevebux

…i/module_lambda_letter_stream_handler.tf …module_lambda_letter_stream_forwarder.tfinfrastructure/terraform/components/api/module_lambda_letter_stream_handler.tf renamed to infrastructure/terraform/components/api/module_lambda_letter_stream_forwarder.tf infrastructure/terraform/components/api/module_lambda_letter_stream_handler.tf renamed to infrastructure/terraform/components/api/module_lambda_letter_stream_forwarder.tf

@@ -1,8 +1,8 @@
 module "letter_stream_handler" {
   source = "https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/v2.0.26/terraform-lambda.zip"
 
-  function_name = "letter-stream-handler"
-  description   = "Kinesis stream handler for DDB letter status updates"
+  function_name = "letter-stream-forwarder"
+  description   = "Kinesis stream forwarder for DDB letter status updates"
 
   aws_account_id = var.aws_account_id
   component      = var.component
@@ -15,7 +15,7 @@ module "letter_stream_handler" {
   kms_key_arn           = module.kms.key_arn
 
   iam_policy_document = {
-    body = data.aws_iam_policy_document.letter_stream_handler_lambda.json
+    body = data.aws_iam_policy_document.letter_stream_forwarder_lambda.json
   }
 
   function_s3_bucket      = local.acct.s3_buckets["lambda_function_artefacts"]["id"]
@@ -36,11 +36,11 @@ module "letter_stream_handler" {
   log_subscription_role_arn = local.acct.log_subscription_role_arn
 
   lambda_env_vars = merge(local.common_lambda_env_vars, {
-    EVENTPUB_SNS_TOPIC_ARN = module.eventpub.sns_topic.arn
+    LETTER_CHANGE_STREAM_NAME = "letter_change_stream"
   })
 }
 
-data "aws_iam_policy_document" "letter_stream_handler_lambda" {
+data "aws_iam_policy_document" "letter_stream_forwarder_lambda" {
 
   statement {
     sid    = "Kinesis permissions"

infrastructure/terraform/components/api/module_lambda_letter_updates_transformer.tf

@@ -57,7 +57,7 @@ data "aws_iam_policy_document" "letter_updates_transformer_lambda" {
 
 resource "aws_lambda_event_source_mapping" "letter_updates_transformer_kinesis" {
   event_source_arn                     = aws_kinesis_stream.letter_change_stream.arn
-  function_name                        = module.letter_updates_transformer_lambda.lambda_function_name
+  function_name                        = module.letter_updates_transformer.lambda_function_name
   starting_position                    = "LATEST"
   batch_size                           = 10
   maximum_batching_window_in_seconds   = 1