Fix attempt

Author: francisco-videira-nhs

infrastructure/terraform/components/api/module_lambda_letter_status_update.tf

@@ -22,7 +22,7 @@ module "letter_status_update" {
   function_code_base_path = local.aws_lambda_functions_dir_path
   function_code_dir       = "api-handler/dist"
   function_include_common = true
-  handler_function_name   = "statusUpdateHandler"
+  handler_function_name   = "letterStatusUpdate"
   runtime                 = "nodejs22.x"
   memory                  = 128
   timeout                 = 5
@@ -58,6 +58,8 @@ data "aws_iam_policy_document" "letter_status_update" {
     effect = "Allow"
 
     actions = [
+      "dynamodb:GetItem",
+      "dynamodb:Query",
       "dynamodb:UpdateItem",
     ]
 

lambdas/api-handler/src/handlers/__tests__/letter-status-update.test.ts

@@ -100,7 +100,7 @@ describe('createLetterStatusUpdateHandler', () => {
 
     expect(mockedDeps.letterRepo.updateLetterStatus).toHaveBeenCalledWith(letterToUpdate[0]);
     expect(mockedDeps.logger.error).toHaveBeenCalledWith({ err: mockError},
-      'Error processing update to letterId=id1 supplierId=s1 correlationId=correlationId-id1');
+      'Error processing update: messageId=mid-id1 correlationId=correlationId-id1');
   });
 });
 

lambdas/api-handler/src/handlers/letter-status-update.ts

@@ -1,10 +1,10 @@
-import { SQSEvent, Context, SQSHandler, SQSRecord } from 'aws-lambda';
+import { SQSEvent, SQSHandler, SQSRecord } from 'aws-lambda';
 import { LetterDto, LetterDtoSchema } from '../contracts/letters';
 import { Deps } from '../config/deps';
 
 export function createLetterStatusUpdateHandler(deps: Deps): SQSHandler {
 
-  return async ( event: SQSEvent, context: Context ) => {
+  return async ( event: SQSEvent ) => {
     for (const message of event.Records) {
       await processMessageAsync(message, deps);
     }
@@ -13,11 +13,11 @@ export function createLetterStatusUpdateHandler(deps: Deps): SQSHandler {
 
 async function processMessageAsync(message: SQSRecord, deps: Deps): Promise<any> {
 
-  const letterToUpdate: LetterDto = LetterDtoSchema.parse(JSON.parse(message.body));
-
   try {
+    const letterToUpdate: LetterDto = LetterDtoSchema.parse(JSON.parse(message.body));
     await deps.letterRepo.updateLetterStatus(letterToUpdate);
+    deps.logger.info(`Processed update to letterId=${letterToUpdate.id} supplierId=${letterToUpdate.supplierId} correlationId=${message.messageAttributes["CorrelationId"].stringValue}`);
   } catch (error) {
-    deps.logger.error({ err: error }, `Error processing update to letterId=${letterToUpdate.id} supplierId=${letterToUpdate.supplierId} correlationId=${message.messageAttributes["CorrelationId"].stringValue}`);
+    deps.logger.error({ err: error }, `Error processing update: messageId=${message.messageId} correlationId=${message.messageAttributes["CorrelationId"].stringValue}`);
   }
 }

lambdas/api-handler/src/index.ts

@@ -13,7 +13,7 @@ export const getLetter = createGetLetterHandler(container);
 export const getLetterData = createGetLetterDataHandler(container);
 export const getLetters = createGetLettersHandler(container);
 export const patchLetter = createPatchLetterHandler(container);
-export const statusUpdateHandler = createLetterStatusUpdateHandler(container);
+export const letterStatusUpdate = createLetterStatusUpdateHandler(container);
 export const postLettersReceiver = createPostLettersReceiverHandler(container);
 
 export const postMI = createPostMIHandler(container);

lambdas/api-handler/src/services/__tests__/letter-operations.test.ts

@@ -327,7 +327,7 @@ describe('enqueueLetterUpdateRequests function', () => {
     };
     const deps: Deps = { sqsClient, logger, env } as Deps;
 
-    const result = await enqueueLetterUpdateRequests(updateLettersRequest, 'supplier1', 'correlationId1', deps);
+    await enqueueLetterUpdateRequests(updateLettersRequest, 'supplier1', 'correlationId1', deps);
 
     expect(deps.logger.error).toHaveBeenCalledWith({ err: mockError},
           'Error queuing letterId=id1 supplierId=supplier1 correlationId=correlationId1 for update');

lambdas/api-handler/src/services/letter-operations.ts

@@ -91,6 +91,7 @@ export async function enqueueLetterUpdateRequests(postLettersRequest: PostLetter
         MessageBody: JSON.stringify(mapPostLetterResourceToDto(request, supplierId)),
       });
       await deps.sqsClient.send(command);
+      deps.logger.info(`Enqueued letter update: url=${command.input.QueueUrl}, message=${command.input.MessageBody}, correlationId=${correlationId}`)
     } catch (err) {
       deps.logger.error({ err }, `Error queuing letterId=${request.id} supplierId=${supplierId} correlationId=${correlationId} for update`);
     }