tests manual fixes

Author: nhsd-david-wass

tests/component-tests/apiGateway-tests/testCases/create-mi.ts

@@ -13,9 +13,7 @@ export type MiRequestBody = {
 };
 
 export function miValidRequest(): MiRequestBody {
-  let requestBody: MiRequestBody;
-
-  requestBody = {
+  return {
     data: {
       attributes: {
         groupId: "group123",
@@ -28,13 +26,10 @@ export function miValidRequest(): MiRequestBody {
       type: "ManagementInformation",
     },
   };
-  return requestBody;
 }
 
 export function miInvalidRequest(): MiRequestBody {
-  let requestBody: MiRequestBody;
-
-  requestBody = {
+  return {
     data: {
       attributes: {
         groupId: "group123",
@@ -47,13 +42,10 @@ export function miInvalidRequest(): MiRequestBody {
       type: "?",
     },
   };
-  return requestBody;
 }
 
 export function miInvalidDateRequest(): MiRequestBody {
-  let requestBody: MiRequestBody;
-
-  requestBody = {
+  return {
     data: {
       attributes: {
         groupId: "group123",
@@ -66,5 +58,4 @@ export function miInvalidDateRequest(): MiRequestBody {
       type: "ManagementInformation",
     },
   };
-  return requestBody;
 }

tests/component-tests/apiGateway-tests/testCases/update-letter-status.ts

@@ -29,23 +29,19 @@ export type PatchMessageResponseBody = {
 };
 
 export function patchRequestHeaders(): RequestHeaders {
-  let requestHeaders: RequestHeaders;
-  requestHeaders = {
+  return {
     headerauth1: process.env.HEADERAUTH || "",
     "NHSD-Supplier-ID": SUPPLIERID,
     "NHSD-Correlation-ID": "12344",
     "X-Request-ID": "requestId1",
   };
-  return requestHeaders;
 }
 
 export function patchValidRequestBody(
   id: string,
   status: string,
 ): PatchMessageRequestBody {
-  let requestBody: PatchMessageRequestBody;
-
-  requestBody = {
+  return {
     data: {
       attributes: {
         status,
@@ -54,16 +50,13 @@ export function patchValidRequestBody(
       id,
     },
   };
-  return requestBody;
 }
 
 export function patchFailureRequestBody(
   id: string,
   status: string,
 ): PatchMessageRequestBody {
-  let requestBody: PatchMessageRequestBody;
-
-  requestBody = {
+  return {
     data: {
       attributes: {
         status,
@@ -74,12 +67,10 @@ export function patchFailureRequestBody(
       id,
     },
   };
-  return requestBody;
 }
 
 export function patch400ErrorResponseBody(): ErrorMessageBody {
-  let responseBody: ErrorMessageBody;
-  responseBody = {
+  return {
     errors: [
       {
         id: "12344",
@@ -94,12 +85,10 @@ export function patch400ErrorResponseBody(): ErrorMessageBody {
       },
     ],
   };
-  return responseBody;
 }
 
 export function patch500ErrorResponseBody(id: string): ErrorMessageBody {
-  let responseBody: ErrorMessageBody;
-  responseBody = {
+  return {
     errors: [
       {
         id: "12344",
@@ -114,5 +103,4 @@ export function patch500ErrorResponseBody(id: string): ErrorMessageBody {
       },
     ],
   };
-  return responseBody;
 }

tests/component-tests/apiGateway-tests/testCases/update-multiple-letter-status.ts

@@ -7,31 +7,25 @@ import {
 import { SupplierApiLetters } from "../../../helpers/generate-fetch-test-data";
 
 export function postLettersRequestHeaders(): RequestHeaders {
-  let requestHeaders: RequestHeaders;
-  requestHeaders = {
+  return {
     "NHSD-Supplier-ID": SUPPLIERID,
     "NHSD-Correlation-ID": "12344",
     "X-Request-ID": "requestId1",
   };
-  return requestHeaders;
 }
 
 export function postLettersInvalidRequestHeaders(): RequestHeaders {
-  let requestHeaders: RequestHeaders;
-  requestHeaders = {
+  return {
     "NHSD-Supplier-ID": SUPPLIERID,
     "NHSD-Correlation-ID": "12344",
     // Request Id is missing
   };
-  return requestHeaders;
 }
 
 export function postValidRequestBody(
   letters: SupplierApiLetters[],
 ): PostMessageRequestBody {
-  let requestBody: PostMessageRequestBody;
-
-  requestBody = {
+  return {
     data: [
       {
         type: "Letter",
@@ -65,15 +59,12 @@ export function postValidRequestBody(
       },
     ],
   };
-  return requestBody;
 }
 
 export function postInvalidStatusRequestBody(
   letters: SupplierApiLetters[],
 ): PostMessageRequestBody {
-  let requestBody: PostMessageRequestBody;
-
-  requestBody = {
+  return {
     data: [
       {
         type: "Letter",
@@ -91,15 +82,12 @@ export function postInvalidStatusRequestBody(
       },
     ],
   };
-  return requestBody;
 }
 
 export function postDuplicateIDRequestBody(
   letters: SupplierApiLetters[],
 ): PostMessageRequestBody {
-  let requestBody: PostMessageRequestBody;
-
-  requestBody = {
+  return {
     data: [
       {
         type: "Letter",
@@ -117,13 +105,10 @@ export function postDuplicateIDRequestBody(
       },
     ],
   };
-  return requestBody;
 }
 
 export function postInvalidStatusResponseBody(): ErrorMessageBody {
-  let responseBody: ErrorMessageBody;
-
-  responseBody = {
+  return {
     errors: [
       {
         id: "12344",
@@ -138,13 +123,10 @@ export function postInvalidStatusResponseBody(): ErrorMessageBody {
       },
     ],
   };
-  return responseBody;
 }
 
 export function postDuplicateIDResponseBody(): ErrorMessageBody {
-  let responseBody: ErrorMessageBody;
-
-  responseBody = {
+  return {
     errors: [
       {
         id: "12344",
@@ -160,13 +142,10 @@ export function postDuplicateIDResponseBody(): ErrorMessageBody {
       },
     ],
   };
-  return responseBody;
 }
 
 export function post500ErrorResponseBody(): ErrorMessageBody {
-  let responseBody: ErrorMessageBody;
-
-  responseBody = {
+  return {
     errors: [
       {
         id: "12344",
@@ -181,5 +160,4 @@ export function post500ErrorResponseBody(): ErrorMessageBody {
       },
     ],
   };
-  return responseBody;
 }

tests/config/reporters.ts

@@ -2,7 +2,6 @@ import type { ReporterDescription } from "@playwright/test";
 import path from "node:path";
 
 const resultsDir = process.env.RESULTS_DIR || "results";
-const reportsDir = process.env.REPORTS_DIR || "reports";
 
 export function getReporters(allureFolder: string) {
   return [

tests/helpers/pnpm-helpers.ts

@@ -60,15 +60,13 @@ export async function runCreateLetter(options: {
   ];
 
   await new Promise<void>((resolve, reject) => {
-    let output = "";
     const child = spawn(cmd, args, {
       stdio: "inherit",
       cwd: root,
       shell: false,
     });
     child.stdout?.on("id", (id) => {
       const text = id.toString();
-      output += text;
       process.stdout.write(text);
     });
 
@@ -118,15 +116,13 @@ export async function createSupplierData(options: {
   ];
 
   await new Promise<void>((resolve, reject) => {
-    let output = "";
     const child = spawn(cmd, args, {
       stdio: "inherit",
       cwd: root,
       shell: false,
     });
     child.stdout?.on("id", (id) => {
       const text = id.toString();
-      output += text;
       process.stdout.write(text);
     });