Skip to content

Commit 4b3167d

Browse files
jakecosgrovemark-r-bjssemmagiffordRossBugginsNHSalexcolbeck1
authored
Sender name updates, minor styling and mobile responsiveness fixes (#78)
* Added mention of 'message cascades' in routing plan content for 'parallel send' feature mention. * 'or' replaced with 'and' * Message status page created - changes to /using-nhs-notify/mesh to match MESH guidance - sender IDs changed to sender names * Emma 2i requested changes * Added /using-nhs-notify/nhs-app-templates, /using-nhs-notify/email-templates, /using-nhs-notify/text-message-templates and /using-nhs-notify/letter-templates. These are based on the Confluence pages https://nhsd-confluence.digital.nhs.uk/pages/viewpage.action?spaceKey=RIS&title=3.8+Creating+letter+templates onwards, with some minor tweaks to word ordering. Romy has approved this content now. Uploaded the standardised Word doc templates for all 4 channels to /assets/worddocs, and linked to these. Craig in cyber security approved this approach (see ticket for screenshot). Updated /using-nhs-notify/personalisation in line with the Confluence page. The FAQs from onboarding indicated there's a user need to provide the PDS personalisation fields. I also added content on how users provide their own personalisation data, in line with Tan's Confluence page https://nhsd-confluence.digital.nhs.uk/display/RIS/NHS+Notify+%7C+Personalisation+Fields. In /pricing/text-messages, I replaced 'it will count as more than one message' with 'it will be charged as more than one message'. This was prompted by a comment from Romy on the text message template content. I tweaked the content to match the later version of the UI prototype, which we based on findings from user research. * Removed mention of bank holidays from emails and text message delivery times. * Removed unnecessary bullets and headings anchor links in Text message templates. Updated link text for the 4 template pages in the Using NHS Notify parent page - removed 'Creating...' from the start of each link. * Fixed typo in /text-message-templates. Removed 'Creating...' from links on /using-nhs-notify. * Updated names of Word docs to replace spaces with hyphens and make all lower case. Updated downloadable links to follow the approach Jake researched, for example [letter template]({% link assets/worddocs/letter-template-nhs-notify.docx %}) * Removed unnecessary space from line 26 on docs/pages/using-nhs-notify/letter-templates. * Update accept.txt Includes: - Noto - URL - ctrl - pending_enrichment - unnotified - permanent_failure - temporary_failure - technical_failure - precompiled - validation_failed - fullName - namePrefix - clientRef * In /using-nhs-notify/delivery-times#letters, replaced the sentence 'Once your letter has been sent, it can take...' with 'Once you've provided us with recipients' NHS numbers, it can take up to 2 working days for our suppliers to dispatch your letter'. I also added anchor links to the top of the same page, /using-nhs-notify/delivery-times, to make navigation easier. * Added content on what users need to do in order to use recipient contact details that are outside of PDS. * Emma recommendations * Removed address_line_x, clientRef, recipientContactValue and template from the bulleted list of personalisation fields from PDS as these are for internal use only. Restructured the first paragraph under ### Personal Demographics Service (PDS) personalisation fields. This was based off a conversation with Jake and it aims to clarify the link between PDS, NHS numbers and personalisation fields. * In /workspaces/nhs-notify-web-cms-dev/docs/_sass/_nhsnotify.scss I added the line 'flex-wrap: wrap;' in the following code: .nhsuk-header__navigation-list { justify-content: flex-start; flex-wrap: wrap; } This is an interim step to make the main nav list items wrap correctly when the site is viewed on a mobile device. It's not our ultimate solution but it makes the site more mobile responsive and accessible. * Removed mentions of date of birth from failed message status descriptions. Removed date of birth as as an example of a column header in a MESH request. * Added link to NHS Notify MESH documentation in /using-nhs-notify/mesh * Squashed commit of the following: commit 7b904fc Author: Ross Buggins <[email protected]> Date: Tue Nov 19 17:02:42 2024 +0000 Quick and easy js to auto hide. commit 8aed356 Author: Jake Cosgrove <[email protected]> Date: Tue Nov 19 16:05:22 2024 +0000 Developer banner and new site banner commit a3d47d2 Author: Jake Cosgrove <[email protected]> Date: Mon Nov 11 15:47:17 2024 +0000 removed phase banner and underlines from primary nav list items when hovered commit 3a30f41 Author: Jake Cosgrove <[email protected]> Date: Mon Nov 11 13:50:40 2024 +0000 removed border from phase banner commit fc61be5 Author: Jake Cosgrove <[email protected]> Date: Fri Nov 8 16:32:05 2024 +0000 Added phase banner component and related sass. Added new template for including pages of content that does not need a side-navigation. commit 45d34e6 Author: Jake Cosgrove <[email protected]> Date: Tue Nov 5 21:59:47 2024 +0000 two-third column tests * Changed first subheading to a h2 from h3 * Removed the other phase banners from Ross' test * removed phase banner includes due to component not being tested or released by developer * Update personalisation.md * First draft updated guidance * Requested changes * Changes from Alex's review: - corrected typo's - added missing anchor link - included image of example inbox showing sender name and 'from' address * Romy suggested that we use screenshots to show where the sender names appear for NHS App and SMS. This commit includes additional images to support user understanding of sender names and where they sit in context. * This commit includes: - new HTML includes specific for images with captions so they fit 100% of their container - images on pages use new includes - inset text has override style class to reduce margin-top - side nav now disappears when below 768px breakpoint (need to talk to design team about mobile solution) * Added content about sending text message sender names for approval with NCSC. * Use new image-with-text.html includes * Content changes following Emma's 2i * Added 'new' to text message sender names --------- Co-authored-by: Mark R <[email protected]> Co-authored-by: emmagifford <[email protected]> Co-authored-by: Ross Buggins <[email protected]> Co-authored-by: alexcolbeck1 <[email protected]>
1 parent 8b90e53 commit 4b3167d

12 files changed

+280
-28
lines changed
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<figure class="nhsuk-image-with-caption {{ include.class | xml_escape }}">
2+
{% assign src = '/assets/images/' | prepend: site.baseurl | append: include.src %}
3+
{% if include.src contains 'https://' %}
4+
<img class="nhsuk-image__img" src='{{ include.src | uri_escape }}' alt='{{ include.alt | xml_escape }}' />
5+
{% else %}
6+
<img class="nhsuk-image__img" src='{{ src }}' alt='{{ include.alt | xml_escape }}' />
7+
{% endif %}
8+
{% if include.caption %}
9+
<figcaption class="nhsuk-image__caption">
10+
{{ include.caption }}
11+
</figcaption>
12+
{% endif %}
13+
</figure>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div class="nhsuk-inset-text">
1+
<div class="nhsuk-inset-text-override">
22
<span class="nhsuk-u-visually-hidden">Information:</span>
33
{{ include.text | markdownify }}
44
</div>

docs/_sass/_nhsnotify-side-nav.scss

Lines changed: 54 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,62 @@
11
.nhsnotify-pane {
2-
display: flex;
2+
display: -webkit-box;
3+
display: -ms-flexbox; // sass-lint:disable-line no-duplicate-properties
4+
display: flex; // sass-lint:disable-line no-duplicate-properties
35
min-height: 0;
46
overflow: inherit;
57
position: relative;
68
}
79

810
.nhsnotify-pane__side-bar {
11+
-ms-flex: 0 0 auto;
12+
-webkit-box-flex: 0;
913
flex: 0 0 auto;
10-
width: 280px;
11-
padding: 0;
14+
width: 220px;
15+
16+
@include mq($until: desktop) {
17+
display: none;
18+
}
1219
}
1320

1421
.nhsnotify-pane__main-content {
15-
display: flex;
22+
-ms-flex: 1 1 100%; // sass-lint:disable-line no-duplicate-properties
23+
-ms-flex-direction: column;
24+
-webkit-box-direction: normal;
25+
-webkit-box-flex: 1;
26+
-webkit-box-orient: vertical;
27+
display: -webkit-box;
28+
display: -ms-flexbox; // sass-lint:disable-line no-duplicate-properties
29+
display: flex; // sass-lint:disable-line no-duplicate-properties
1630
flex: 1 1 100%;
1731
flex-direction: column;
1832
min-width: 0;
33+
34+
@include mq($from: desktop) {
35+
padding-left: nhsuk-spacing(9);
36+
}
37+
1938
}
2039

2140
.nhsnotify-side-nav__list {
22-
font-size: 1em;
23-
line-height: 1.3;
41+
@include nhsuk-font(16, $line-height: 1.3);
2442
margin-bottom: 0;
43+
44+
@include mq($until: desktop) {
45+
@include nhsuk-font(19, $line-height: 1.3);
46+
margin-bottom: nhsuk-spacing(2);
47+
}
2548
}
2649

2750
.nhsnotify-side-nav__list-section {
28-
@extend .nhsuk-u-font-weight-bold;
29-
color: #4c6272;
30-
margin-bottom: 8px;
31-
padding-bottom: 4px;
32-
font-size: 1em;
51+
@include nhsuk-font(19, $line-height: 1.25, $weight: bold);
52+
color: $nhsuk-secondary-text-color;
53+
margin-bottom: 12px;
54+
padding-top: 4px;
55+
56+
@include mq($until: desktop) {
57+
@include nhsuk-font(24, $line-height: 1.25, $weight: bold);
58+
color: $nhsuk-text-color;
59+
}
3360
}
3461

3562
.nhsnotify-side-nav__item {
@@ -55,6 +82,10 @@
5582
.nhsnotify-side-nav__link {
5683
text-decoration: none;
5784

85+
@include mq($until: desktop) {
86+
text-decoration: underline;
87+
}
88+
5889
&:visited {
5990
color: $blue-000;
6091
}
@@ -68,3 +99,15 @@
6899
color: #212b32;
69100
}
70101
}
102+
103+
// Hide content on desktop
104+
.nhsnotify-u-hide-desktop {
105+
@include mq($from: desktop) {
106+
display: none;
107+
}
108+
}
109+
110+
// Mobile navigation
111+
.nhsnotify-index-navigation {
112+
@include nhsuk-responsive-padding(4, 'top');
113+
}

docs/_sass/_nhsnotify.scss

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,3 +107,41 @@
107107
line-height: 1.25;
108108
padding-left: 0.5em;
109109
}
110+
111+
.nhsuk-inset-text-override {
112+
@include top-and-bottom(); /* [1] */
113+
@include reading-width(); /* [2] */
114+
115+
@include nhsuk-responsive-margin(7, "bottom");
116+
@include nhsuk-responsive-margin(4, "top");
117+
@include nhsuk-responsive-padding(4);
118+
119+
border-left: $nhsuk-border-width-inset-text solid $color_nhsuk-blue;
120+
121+
@include mq($media-type: print) {
122+
border-color: $nhsuk-print-text-color;
123+
}
124+
}
125+
126+
.nhsuk-image-with-caption {
127+
background-color: $color_nhsuk-white;
128+
border-bottom: 1px solid $color_nhsuk-grey-4;
129+
130+
margin-left: 0; /* [1] */
131+
margin-right: 0; /* [1] */
132+
133+
@include nhsuk-responsive-margin(6, "bottom");
134+
@include nhsuk-responsive-margin(3, "top");
135+
136+
@include mq($from: desktop) {
137+
width: 100%; /* [2] */
138+
}
139+
140+
@include mq($media-type: print) {
141+
width: 50%; /* [3] */
142+
}
143+
144+
& + .nhsuk-image {
145+
@include nhsuk-responsive-margin(0, "top"); /* [4] */
146+
}
147+
}
147 KB
Loading
226 KB
Loading
412 KB
Loading

docs/pages/features/emails.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ section: Message channels
1212

1313
Use NHS Notify to send free unlimited emails to patients and members of the public, in bulk and individually.
1414

15-
{% include components/image.html
15+
{% include components/image-with-caption.html
1616
src="nhs-notify-email-example.svg"
1717
alt="A screenshot of an email sent by NHS Notify."
1818
caption="An example of an email sent by NHS Notify."

docs/pages/features/letters.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ section: Message channels
1212

1313
You can use NHS Notify to print and send letters to patients and members of the public with addresses in the UK. You can do this in bulk and individually.
1414

15-
{% include components/image.html
15+
{% include components/image-with-caption.html
1616
src="nhs-notify-letter-two-sides-example.svg"
1717
alt="An image showing both sides of a letter sent by NHS Notify"
1818
caption="An example of a black and white double-sided letter sent by NHS Notify."

docs/pages/features/nhs-app-messages.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ section: Message channels
1212

1313
Send free messages of up to 1,000 characters to patients and members of the public who have the NHS App.
1414

15-
{% include components/image.html
15+
{% include components/image-with-caption.html
1616
src="nhs-notify-nhs-app-example-2.svg"
1717
alt="A screenshot of an opened message in the NHS App inbox."
1818
caption="An example of a message sent with the NHS App."
@@ -43,7 +43,7 @@ When a user selects the banner notification, this opens their message in the NHS
4343

4444
To protect recipients, banner notifications pushed by the NHS App do not include any of your message content.
4545

46-
{% include components/image.html
46+
{% include components/image-with-caption.html
4747
src="nhs-notify-nhs-app-banner-notification.svg"
4848
alt="An image of 2 mobile devices side by side showing an example banner notification for both iPhone and Android devices pushed by the NHS App."
4949
caption="An example of a banner notification pushed to an iPhone and an Android device by the NHS App."
@@ -53,7 +53,7 @@ To protect recipients, banner notifications pushed by the NHS App do not include
5353

5454
When a recipient receives a NHS App message, a badge notification will appear on the NHS App icon. Badges let NHS App users know that there’s an unopened message or notification for them in the app.
5555

56-
{% include components/image.html
56+
{% include components/image-with-caption.html
5757
src="nhs-notify-nhs-app-badge-notification.svg"
5858
alt="A screenshot of the NHS App icon with a red badge showing 1 notification."
5959
caption="An example of a badge notification pushed by the NHS App when a message is sent to a recipient’s NHS App inbox."

0 commit comments

Comments
 (0)