api tests using user with no client

Author: alexnuttall

tests/test-team/helpers/auth/cognito-auth-helper.ts

@@ -11,18 +11,22 @@ import {
 import { faker } from '@faker-js/faker';
 import { CredentialsFile } from './credentials-file';
 
+type TestUserStaticDetails = {
+  userId: string;
+  clientId: string | undefined;
+};
+
+type TestUserDetails = TestUserStaticDetails & {
+  email: string;
+};
+
 export type TestUserCredential = {
-  user: { email: string; userId: string; clientId: string | undefined };
+  user: TestUserDetails;
   password: string;
   accessToken: string;
   refreshToken: string;
 };
 
-type TestUserStaticDetails = {
-  userId: string;
-  clientId: string | undefined;
-};
-
 export const testUsers = {
   /**
    * User1 is generally the signed in user
@@ -70,8 +74,7 @@ export const testUsers = {
 
 type TestUserId = keyof typeof testUsers;
 
-export type TestUser = TestUserStaticDetails & {
-  email: string;
+export type TestUser = TestUserDetails & {
   password: string;
   /**
    * Gets an access token for a test user

tests/test-team/template-mgmt-api-tests/create-letter-template.api.spec.ts

@@ -16,9 +16,11 @@ test.describe('POST /v1/letter-template', () => {
   const authHelper = createAuthHelper();
   const templateStorageHelper = new TemplateStorageHelper();
   let user1: TestUser;
+  let user6: TestUser;
 
   test.beforeAll(async () => {
     user1 = await authHelper.getTestUser(testUsers.User1.userId);
+    user6 = await authHelper.getTestUser(testUsers.User6.userId);
   });
 
   test.afterAll(async () => {
@@ -189,6 +191,81 @@ test.describe('POST /v1/letter-template', () => {
     expect(result.template.createdAt).not.toEqual(result.template.updatedAt);
   });
 
+  test('user without a clientId assigned can create a template', async ({
+    request,
+  }) => {
+    const { templateData, multipart, contentType } =
+      TemplateAPIPayloadFactory.getCreateLetterTemplatePayload(
+        {
+          templateType: 'LETTER',
+        },
+        [
+          {
+            _type: 'json',
+            partName: 'template',
+          },
+          {
+            _type: 'file',
+            partName: 'letterPdf',
+            fileName: 'template.pdf',
+            fileType: 'application/pdf',
+            file: pdfUploadFixtures.noCustomPersonalisation.pdf.open(),
+          },
+        ]
+      );
+
+    const start = new Date();
+
+    const response = await request.post(
+      `${process.env.API_BASE_URL}/v1/letter-template`,
+      {
+        data: multipart,
+        headers: {
+          Authorization: await user6.getAccessToken(),
+          'Content-Type': contentType,
+        },
+      }
+    );
+
+    const result = await response.json();
+    const debug = JSON.stringify(result, null, 2);
+
+    expect(response.status(), debug).toBe(201);
+
+    templateStorageHelper.addAdHocTemplateKey({
+      id: result.template.id,
+      owner: user1.userId,
+    });
+
+    expect(result).toEqual({
+      statusCode: 201,
+      template: {
+        createdAt: expect.stringMatching(isoDateRegExp),
+        id: expect.stringMatching(uuidRegExp),
+        name: templateData.name,
+        language: 'en',
+        letterType: 'x0',
+        templateStatus: 'PENDING_VALIDATION',
+        templateType: templateData.templateType,
+        updatedAt: expect.stringMatching(isoDateRegExp),
+        files: {
+          pdfTemplate: {
+            currentVersion: expect.stringMatching(uuidRegExp),
+            fileName: 'template.pdf',
+            virusScanStatus: 'PENDING',
+          },
+          proofs: {},
+        },
+      },
+    });
+
+    expect(result.template.createdAt).toBeDateRoughlyBetween([
+      start,
+      new Date(),
+    ]);
+    expect(result.template.createdAt).not.toEqual(result.template.updatedAt);
+  });
+
   test('returns 401 if no auth token', async ({ request }) => {
     const response = await request.post(
       `${process.env.API_BASE_URL}/v1/letter-template`

tests/test-team/template-mgmt-api-tests/create-template.api.spec.ts

@@ -15,9 +15,11 @@ test.describe('POST /v1/template', () => {
   const authHelper = createAuthHelper();
   const templateStorageHelper = new TemplateStorageHelper();
   let user1: TestUser;
+  let user6: TestUser;
 
   test.beforeAll(async () => {
     user1 = await authHelper.getTestUser(testUsers.User1.userId);
+    user6 = await authHelper.getTestUser(testUsers.User6.userId);
   });
 
   test.afterAll(async () => {
@@ -157,6 +159,54 @@ test.describe('POST /v1/template', () => {
       expect(created.template.createdAt).toEqual(created.template.updatedAt);
     });
 
+    test('user without a clientId assigned can create a template', async ({
+      request,
+    }) => {
+      const template = TemplateAPIPayloadFactory.getCreateTemplatePayload({
+        templateType: 'NHS_APP',
+      });
+
+      const start = new Date();
+
+      const response = await request.post(
+        `${process.env.API_BASE_URL}/v1/template`,
+        {
+          headers: {
+            Authorization: await user6.getAccessToken(),
+          },
+          data: template,
+        }
+      );
+
+      expect(response.status()).toBe(201);
+
+      const created = await response.json();
+
+      templateStorageHelper.addAdHocTemplateKey({
+        id: created.template.id,
+        owner: user1.userId,
+      });
+
+      expect(created).toEqual({
+        statusCode: 201,
+        template: {
+          createdAt: expect.stringMatching(isoDateRegExp),
+          id: expect.stringMatching(uuidRegExp),
+          message: template.message,
+          name: template.name,
+          templateStatus: 'NOT_YET_SUBMITTED',
+          templateType: template.templateType,
+          updatedAt: expect.stringMatching(isoDateRegExp),
+        },
+      });
+
+      expect(created.template.createdAt).toBeDateRoughlyBetween([
+        start,
+        new Date(),
+      ]);
+      expect(created.template.createdAt).toEqual(created.template.updatedAt);
+    });
+
     test('ignores template status if given - template cannot be submitted at create time', async ({
       request,
     }) => {