remove 'client' logging

Author: alexnuttall

lambdas/backend-api/src/__tests__/templates/app/routing-config-client.test.ts

@@ -3,7 +3,6 @@ import type { RoutingConfigRepository } from '@backend-api/templates/infra/routi
 import { RoutingConfigQuery } from '@backend-api/templates/infra/routing-config-repository/query';
 import { RoutingConfigClient } from '@backend-api/templates/app/routing-config-client';
 import { routingConfig } from '../fixtures/routing-config';
-import { createMockLogger } from 'nhs-notify-web-template-management-test-helper-utils/mock-logger';
 import {
   CreateUpdateRoutingConfig,
   RoutingConfig,
@@ -13,14 +12,12 @@ const user = { userId: 'userid', clientId: 'nhs-notify-client-id' };
 
 function setup() {
   const repo = mock<RoutingConfigRepository>();
-  const { logger } = createMockLogger();
 
   const mocks = {
     routingConfigRepository: repo,
-    logger,
   };
 
-  const client = new RoutingConfigClient(repo, logger);
+  const client = new RoutingConfigClient(repo);
 
   return { client, mocks };
 }

lambdas/backend-api/src/templates/app/routing-config-client.ts

@@ -11,48 +11,29 @@ import {
 import { validate } from '@backend-api/utils/validate';
 import type { RoutingConfigRepository } from '../infra/routing-config-repository';
 import type { User } from 'nhs-notify-web-template-management-utils';
-import type { Logger } from 'nhs-notify-web-template-management-utils/logger';
 
 export class RoutingConfigClient {
   constructor(
-    private readonly routingConfigRepository: RoutingConfigRepository,
-    private readonly logger: Logger
+    private readonly routingConfigRepository: RoutingConfigRepository
   ) {}
 
   async createRoutingConfig(
     routingConfig: CreateUpdateRoutingConfig,
     user: User
   ): Promise<Result<RoutingConfig>> {
-    const log = this.logger.child({ routingConfig, user });
-
     const validationResult = await validate(
       $CreateUpdateRoutingConfig,
       routingConfig
     );
 
-    if (validationResult.error) {
-      log
-        .child(validationResult.error.errorMeta)
-        .error('Request failed validation', validationResult.error.actualError);
-
-      return validationResult;
-    }
+    if (validationResult.error) return validationResult;
 
     const createResult = await this.routingConfigRepository.create(
       validationResult.data,
       user
     );
 
-    if (createResult.error) {
-      log
-        .child(createResult.error.errorMeta)
-        .error(
-          'Failed to save routing config to the database',
-          createResult.error.actualError
-        );
-
-      return createResult;
-    }
+    if (createResult.error) return createResult;
 
     return createResult;
   }

lambdas/backend-api/src/templates/container.ts

@@ -74,10 +74,7 @@ export function createContainer() {
     config.routingConfigTableName
   );
 
-  const routingConfigClient = new RoutingConfigClient(
-    routingConfigRepository,
-    logger
-  );
+  const routingConfigClient = new RoutingConfigClient(routingConfigRepository);
 
   return {
     clientConfigRepository,