CCM-11029: error handling in pre.sh

Author: harrim91

infrastructure/terraform/bin/terraform.sh

@@ -391,7 +391,7 @@ rm -rf ${component_path}/.terraform;
 
 # Run global pre.sh
 if [ -f "pre.sh" ]; then
-  source pre.sh "${region}" "${environment}" "${action}" \
+  bash pre.sh "${region}" "${environment}" "${action}" \
     || error_and_die "Global pre script execution failed with exit code ${?}";
 fi;
 
@@ -427,7 +427,7 @@ fi;
 
 # Run pre.sh
 if [ -f "pre.sh" ]; then
-  source pre.sh "${region}" "${environment}" "${action}" \
+  bash pre.sh "${region}" "${environment}" "${action}" \
     || error_and_die "Component pre script execution failed with exit code ${?}";
 fi;
 

infrastructure/terraform/components/app/pre.sh

@@ -1,6 +1,8 @@
-echo "Running app pre.sh"
+#!/usr/bin/env bash
+
+set -euo pipefail
 
-original_dir=$(pwd)
+echo "Running app pre.sh"
 
 cd $(git rev-parse --show-toplevel)
 
@@ -11,5 +13,3 @@ npm run generate-dependencies --workspaces --if-present
 npm run lambda-build --workspaces --if-present
 
 $(git rev-parse --show-toplevel)/lambdas/layers/pdfjs/build.sh
-
-cd $original_dir

infrastructure/terraform/components/sandbox/pre.sh

@@ -1,3 +1,7 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
 REGION=$1
 ENVIRONMENT=$2
 ACTION=$3
@@ -10,7 +14,6 @@ echo "SKIP_SANDBOX_INSTALL=$SKIP_SANDBOX_INSTALL"
 
 
 if [ "${ACTION}" == "apply" ]; then
-    original_dir=$(pwd)
     cd $(git rev-parse --show-toplevel)
     echo "Building lambdas for distribution"
 
@@ -27,7 +30,6 @@ if [ "${ACTION}" == "apply" ]; then
 
     $(git rev-parse --show-toplevel)/lambdas/layers/pdfjs/build.sh
 
-    cd $original_dir
 else
     echo "Skipping lambda build for action $ACTION"
 fi