Skip to content

Commit 0d99afa

Browse files
CCM-8961: Fix integration test letter template creation
1 parent 6937d98 commit 0d99afa

File tree

5 files changed

+11
-28
lines changed

5 files changed

+11
-28
lines changed

frontend/src/components/molecules/MessageTemplates/MessageTemplates.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import {
1313
templateStatusToDisplayMappings,
1414
templateTypeDisplayMappings,
1515
previewSubmittedTemplatePages,
16-
templateStatusToColourMappings,
1716
} from 'nhs-notify-web-template-management-utils';
1817
import { TemplateDto } from 'nhs-notify-backend-client';
1918
import style from './MessageTemplates.module.scss';

tests/test-team/helpers/factories/template-factory.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export const TemplateFactory = {
4242
owner: string,
4343
name: string,
4444
templateStatus = 'NOT_YET_SUBMITTED',
45-
virusScanStatus = 'PENDING'
45+
virusScanStatus = 'PASSED'
4646
): Template => {
4747
return TemplateFactory.create({
4848
id,
@@ -76,7 +76,7 @@ export const TemplateFactory = {
7676
}
7777
): Template => {
7878
return {
79-
templateStatus: 'PENDING_UPLOAD',
79+
templateStatus: 'NOT_YET_SUBMITTED',
8080
version: 1,
8181
createdAt: new Date().toISOString(),
8282
updatedAt: new Date().toISOString(),

tests/test-team/template-mgmt-component-tests/letter/template-mgmt-preview-letter-page.component.spec.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,22 @@ async function createTemplates() {
2929
'pending-letter-preview-template',
3030
user.userId,
3131
'test-pending-template-letter',
32-
'PENDING_UPLOAD'
32+
'PENDING_UPLOAD',
33+
'PENDING'
3334
),
3435
virus: TemplateFactory.createLetterTemplate(
3536
'virus-letter-preview-template',
3637
user.userId,
3738
'test-virus-template-letter',
38-
'VIRUS_SCAN_FAILED'
39+
'VIRUS_SCAN_FAILED',
40+
'FAILED'
3941
),
4042
invalid: TemplateFactory.createLetterTemplate(
4143
'invalid-letter-preview-template',
4244
user.userId,
4345
'test-invalid-template-letter',
44-
'VALIDATION_FAILED'
46+
'VALIDATION_FAILED',
47+
'PASSED'
4548
),
4649
};
4750
}

tests/test-team/template-mgmt-component-tests/template-mgmt-submit-page.component.spec.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -147,20 +147,17 @@ async function createTemplates() {
147147
submit: TemplateFactory.createLetterTemplate(
148148
'submit-letter-submit-template',
149149
user.userId,
150-
'test-template-name',
151-
'PASSED'
150+
'test-template-name'
152151
),
153152
submitAndReturn: TemplateFactory.createLetterTemplate(
154153
'submit-and-return-letter-template',
155154
user.userId,
156-
'test-template-name',
157-
'PASSED'
155+
'test-template-name'
158156
),
159157
valid: TemplateFactory.createLetterTemplate(
160158
'valid-letter-submit-template',
161159
user.userId,
162-
'test-template-name',
163-
'PASSED'
160+
'test-template-name'
164161
),
165162
},
166163
};

utils/utils/src/__tests__/enum.test.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -105,22 +105,6 @@ describe('alphabeticalLanguageList', () => {
105105
});
106106
});
107107

108-
describe('templateStatusToColourMappings', () => {
109-
test('NOT_YET_SUBMITTED', () => {
110-
expect(templateStatusToColourMappings('NOT_YET_SUBMITTED')).toEqual(
111-
undefined
112-
);
113-
});
114-
115-
test('SUBMITTED', () => {
116-
expect(templateStatusToColourMappings('SUBMITTED')).toEqual('grey');
117-
});
118-
119-
test('VIRUS_SCAN_FAILED', () => {
120-
expect(templateStatusToColourMappings('VIRUS_SCAN_FAILED')).toEqual('red');
121-
});
122-
});
123-
124108
describe('templateStatusToDisplayMappings', () => {
125109
test('NOT_YET_SUBMITTED', () => {
126110
expect(templateStatusToDisplayMappings('NOT_YET_SUBMITTED')).toEqual(

0 commit comments

Comments
 (0)