CCM-12327: init lock number on create

Author: harrim91

lambdas/backend-api/src/__tests__/templates/app/template-client.test.ts

@@ -1291,7 +1291,10 @@ describe('templateClient', () => {
       const errorCases: [string, string | number][] = [
         ['empty', ''],
         ['negative', -1],
-        ['non-number', 'a'],
+        ['negative stringified', -1],
+        ['non-number string', 'a'],
+        ['NaN', Number.NaN],
+        ['NaN stringified', 'NaN'],
       ];
       test.each(errorCases)(
         'should return a failure result when lockNumber is invalid: %s',
@@ -2194,7 +2197,10 @@ describe('templateClient', () => {
       const errorCases: [string, string | number][] = [
         ['empty', ''],
         ['negative', -1],
-        ['non-number', 'a'],
+        ['negative stringified', -1],
+        ['non-number string', 'a'],
+        ['NaN', Number.NaN],
+        ['NaN stringified', 'NaN'],
       ];
       test.each(errorCases)(
         'should return a failure result when lockNumber is invalid: %s',

lambdas/backend-api/src/__tests__/templates/infra/template-repository.test.ts

@@ -320,6 +320,7 @@ describe('templateRepository', () => {
         const template = {
           ...channelProperties,
           ...databaseTemplateProperties,
+          lockNumber: 0,
         };
 
         mocks.ddbDocClient

lambdas/backend-api/src/templates/infra/template-repository.ts

@@ -91,6 +91,7 @@ export class TemplateRepository {
       ...(template.templateType === 'LETTER' && {
         campaignId,
       }),
+      lockNumber: 0,
     };
 
     try {

tests/test-team/template-mgmt-api-tests/upload-letter-template.api.spec.ts

@@ -104,7 +104,7 @@ test.describe('POST /v1/letter-template', () => {
         templateType: templateData.templateType,
         updatedAt: expect.stringMatching(isoDateRegExp),
         clientId: user1.clientId,
-        lockNumber: 0,
+        lockNumber: 1, // the api endpoint does a create and then an update so this gets incremented to 1 rather than initial 0
       },
     });
 
@@ -185,7 +185,7 @@ test.describe('POST /v1/letter-template', () => {
         templateType: templateData.templateType,
         updatedAt: expect.stringMatching(isoDateRegExp),
         clientId: user1.clientId,
-        lockNumber: 0,
+        lockNumber: 1,
       },
     });