adding repo tests

Author: alexnuttall

infrastructure/terraform/modules/backend-api/module_create_routing_config_lambda.tf

@@ -22,13 +22,13 @@ module "create_routing_config_lambda" {
   log_retention_in_days = var.log_retention_in_days
 
   iam_policy_document = {
-    body = data.aws_iam_policy_document.get_routing_config_lambda_policy.json
+    body = data.aws_iam_policy_document.create_routing_config_lambda_policy.json
   }
 
   lambda_env_vars         = local.backend_lambda_environment_variables
   function_s3_bucket      = var.function_s3_bucket
   function_code_base_path = local.lambdas_dir
-  function_code_dir       = "backend-api/dist/created-routing-config"
+  function_code_dir       = "backend-api/dist/create-routing-config"
 
   send_to_firehose          = var.send_to_firehose
   log_destination_arn       = var.log_destination_arn

infrastructure/terraform/modules/backend-api/spec.tmpl.json

@@ -759,7 +759,7 @@
         ],
         "type": "string"
       },
-  "UploadLetterProperties": {
+      "UploadLetterProperties": {
         "allOf": [
           {
             "$ref": "#/components/schemas/BaseLetterTemplateProperties"

lambdas/backend-api/src/__tests__/templates/api/create-routing-config.test.ts

@@ -1,21 +1,12 @@
 import type { APIGatewayProxyEvent, Context } from 'aws-lambda';
 import { mock } from 'jest-mock-extended';
 import {
-  TemplateDto,
-  CreateUpdateTemplate,
   CreateUpdateRoutingConfig,
   RoutingConfig,
 } from 'nhs-notify-backend-client';
-import type { Logger } from 'nhs-notify-web-template-management-utils/logger';
 import { createHandler } from '@backend-api/templates/api/create-routing-config';
 import type { RoutingConfigClient } from '@backend-api/templates/app/routing-config-client';
 
-jest.mock('nhs-notify-web-template-management-utils/logger', () => ({
-  logger: mock<Logger>({
-    child: jest.fn().mockReturnThis(),
-  }),
-}));
-
 function setup() {
   const routingConfigClient = mock<RoutingConfigClient>();
   const mocks = { routingConfigClient };

lambdas/backend-api/src/__tests__/templates/infra/routing-config-repository.test.ts

@@ -40,7 +40,7 @@ describe('RoutingConfigRepository', () => {
         TableName: TABLE_NAME,
         Key: {
           id: 'b9b6d56b-421e-462f-9ce5-3012e3fdb27f',
-          owner: 'nhs-notify-client-id',
+          owner: 'CLIENT#nhs-notify-client-id',
         },
       });
     });
@@ -96,4 +96,10 @@ describe('RoutingConfigRepository', () => {
       });
     });
   });
+
+  // describe('create', () => {
+  //   test('should ', async () => {
+
+  //   });
+  // });
 });

lambdas/backend-client/src/schemas/routing-config.ts

@@ -119,8 +119,6 @@ export const $RoutingConfig = schemaFor<RoutingConfig>()(
     id: z.uuidv4(),
     status: z.enum(ROUTING_CONFIG_STATUS_LIST),
     createdAt: z.string(),
-    createdBy: z.string(),
     updatedAt: z.string(),
-    updatedBy: z.string(),
   })
 );

lambdas/backend-client/src/types/generated/types.gen.ts

@@ -70,7 +70,11 @@ export type Channel = 'EMAIL' | 'LETTER' | 'NHSAPP' | 'SMS';
 export type ChannelType = 'primary' | 'secondary';
 
 export type ClientConfiguration = {
+  /**
+   * @deprecated
+   */
   campaignId?: string;
+  campaignIds?: Array<string>;
   features: ClientFeatures;
 };
 
@@ -224,11 +228,8 @@ export type TemplateSuccessList = {
 
 export type TemplateType = 'NHS_APP' | 'EMAIL' | 'SMS' | 'LETTER';
 
-export type UploadLetterProperties = {
-  files?: LetterFiles;
-  language: Language;
-  letterType: LetterType;
-  templateType: 'LETTER';
+export type UploadLetterProperties = BaseLetterTemplateProperties & {
+  campaignId: string;
 };
 
 export type VersionedFileDetails = {