Merge pull request #314 from NHSDigital/feature/CCM-8580-choose-letter-env-var

CCM-8580: letter feature flag env var fixes

Author: alexnuttall

.github/workflows/stage-2-test.yaml

@@ -35,7 +35,6 @@ on:
 env:
   AWS_REGION: eu-west-2
   TERM: xterm-256color
-  NEXT_PUBLIC_ENABLE_LETTERS: true
 
 permissions:
   id-token: write # This is required for requesting the JWT

.github/workflows/stage-4-acceptance.yaml

@@ -34,7 +34,6 @@ on:
 
 env:
   AWS_REGION: eu-west-2
-  NEXT_PUBLIC_ENABLE_LETTERS: true
 
 permissions:
   id-token: write # This is required for requesting the JWT
@@ -90,8 +89,6 @@ jobs:
     runs-on: ubuntu-latest
     needs: [sandbox-set-up]
     environment: dev
-    env:
-      INCLUDE_AUTH_PAGES: 'true'
     timeout-minutes: 10
     steps:
       - name: "Checkout code"
@@ -125,8 +122,6 @@ jobs:
     runs-on: ubuntu-latest
     needs: [sandbox-set-up]
     environment: dev
-    env:
-      INCLUDE_AUTH_PAGES: 'true'
     timeout-minutes: 10
     steps:
       - name: "Checkout code"

frontend/.env.template

@@ -1,4 +1,2 @@
 # Includes auth pages when building web frontend in production mode.
 INCLUDE_AUTH_PAGES=''
-# Enables letters feature flag
-NEXT_PUBLIC_ENABLE_LETTERS=''

frontend/jest.setup.ts

@@ -13,3 +13,6 @@ import 'whatwg-fetch';
 Object.assign(global, { TextDecoder, TextEncoder });
 
 createMocks();
+
+// set feature flag
+process.env.NEXT_PUBLIC_ENABLE_LETTERS = 'true';

scripts/create-env-file.ts

@@ -3,4 +3,7 @@ import { randomBytes } from 'node:crypto';
 
 const secret = process.env.CSRF_SECRET ?? randomBytes(16).toString('hex');
 
-writeFileSync('./frontend/.env', `CSRF_SECRET=${secret}`);
+writeFileSync(
+  './frontend/.env',
+  [`CSRF_SECRET=${secret}`, 'NEXT_PUBLIC_ENABLE_LETTERS=true'].join('\n')
+);

scripts/tests/accessibility.sh

@@ -2,6 +2,11 @@
 
 set -euo pipefail
 
+# feature flag
+export NEXT_PUBLIC_ENABLE_LETTERS=true
+
+export INCLUDE_AUTH_PAGES=true
+
 npm run create-test-user
 
 npm run build

tests/test-team/config/component/component.config.ts

@@ -6,6 +6,7 @@ const buildCommand = [
   'INCLUDE_AUTH_PAGES=true',
   'NEXT_PUBLIC_TIME_TILL_LOGOUT_SECONDS=25',
   'NEXT_PUBLIC_PROMPT_SECONDS_BEFORE_LOGOUT=5',
+  'NEXT_PUBLIC_ENABLE_LETTERS=true',
   'npm run build && npm run start',
 ].join(' ');