CCM-11966: Fix typecheck and unit test issues in piepline

Author: m-salaudeen

frontend/src/__tests__/components/forms/SubmitTemplate/SubmitLetterTemplate.test.tsx

@@ -45,6 +45,7 @@ describe('SubmitLetterTemplate component', () => {
       <SubmitLetterTemplate
         templateId='template-id'
         templateName='template-name'
+        lockNumber={1234}
       />
     );
 

frontend/src/__tests__/components/forms/SubmitTemplate/__snapshots__/SubmitLetterTemplate.test.tsx.snap

@@ -88,6 +88,7 @@ exports[`SubmitLetterTemplate component should render with client proofing and r
             name="lockNumber"
             readonly=""
             type="hidden"
+            value="1234"
           />
           <button
             aria-disabled="false"

lambdas/event-publisher/src/__tests__/domain/should-publish.test.ts

@@ -44,17 +44,15 @@ describe('shouldPublish', () => {
     }
   );
 
-  type LetterStatus = Exclude<
-    TemplateStatus,
-    'NOT_YET_SUBMITTED' | 'TEMPLATE_PROOF_APPROVED'
-  >;
+  type LetterStatus = Exclude<TemplateStatus, 'NOT_YET_SUBMITTED'>;
 
   const letterPublishCases: Record<LetterStatus, boolean> = {
     DELETED: true,
     PENDING_PROOF_REQUEST: true,
     PROOF_AVAILABLE: true,
     SUBMITTED: true,
     WAITING_FOR_PROOF: true,
+    TEMPLATE_PROOF_APPROVED: false,
     PENDING_UPLOAD: false,
     PENDING_VALIDATION: false,
     VALIDATION_FAILED: false,

utils/utils/src/__tests__/enum.test.ts

@@ -34,6 +34,7 @@ import { TEMPLATE_STATUS_LIST } from 'nhs-notify-backend-client';
 
 const mockLetterWithFilesTemplate: TemplateDto = {
   id: '1',
+  lockNumber: 1234,
   templateType: 'LETTER',
   templateStatus: 'NOT_YET_SUBMITTED',
   name: 'Template 1',
@@ -56,9 +57,9 @@ const mockLetterWithFilesTemplate: TemplateDto = {
     },
   },
 };
-
 const mockLetterTemplate: TemplateDto = {
   id: '1',
+  lockNumber: 1234,
   templateType: 'LETTER',
   templateStatus: 'NOT_YET_SUBMITTED',
   name: 'Template 1',
@@ -72,6 +73,7 @@ const mockLetterTemplate: TemplateDto = {
 
 const mockNHSAppTemplate: TemplateDto = {
   id: '2',
+  lockNumber: 1234,
   templateType: 'NHS_APP',
   templateStatus: 'NOT_YET_SUBMITTED',
   name: 'Template 1',
@@ -82,6 +84,7 @@ const mockNHSAppTemplate: TemplateDto = {
 
 const mockSMSTemplate: TemplateDto = {
   id: '3',
+  lockNumber: 1234,
   templateType: 'SMS',
   templateStatus: 'NOT_YET_SUBMITTED',
   name: 'Template 1',
@@ -91,6 +94,7 @@ const mockSMSTemplate: TemplateDto = {
 };
 const mockEmailTemplate: TemplateDto = {
   id: '4',
+  lockNumber: 1234,
   templateType: 'EMAIL',
   subject: 'Email Subject',
   templateStatus: 'NOT_YET_SUBMITTED',