CCM-11886: Add test-specific template names

Author: chris-elliott-nhsd

tests/test-team/helpers/factories/template-factory.ts

@@ -21,25 +21,25 @@ export const TemplateFactory = {
     });
   },
 
-  createSmsTemplate: (id: string, user: TestUser): Template => {
+  createSmsTemplate: (id: string, user: TestUser, name: string = 'test'): Template => {
     return TemplateFactory.create({
       campaignId: testClients[user.clientKey]?.campaignId,
       clientId: user.clientId,
       id,
       message: 'test-message',
-      name: 'test',
+      name,
       owner: `CLIENT#${user.clientId}`,
       templateType: 'SMS',
     });
   },
 
-  createNhsAppTemplate: (id: string, user: TestUser): Template => {
+  createNhsAppTemplate: (id: string, user: TestUser, name: string = 'test'): Template => {
     return TemplateFactory.create({
       campaignId: testClients[user.clientKey]?.campaignId,
       clientId: user.clientId,
       id,
       message: 'test-message',
-      name: 'test-name',
+      name,
       owner: `CLIENT#${user.clientId}`,
       templateType: 'NHS_APP',
     });

tests/test-team/template-mgmt-component-tests/email/template-mgmt-edit-email-page.component.spec.ts

@@ -19,19 +19,23 @@ function createTemplates(user: TestUser) {
   return {
     valid: TemplateFactory.createEmailTemplate(
       'f26a6c9b-29f5-4280-9b8d-aa692f0aa8aa',
-      user
+      user,
+      'edit-email-page-valid',
     ),
     submit: TemplateFactory.createEmailTemplate(
       '29252087-fbfa-459d-9c05-577223a94ad9',
-      user
+      user,
+      'edit-email-page-submit',
     ),
     submitAndReturn: TemplateFactory.createEmailTemplate(
       '2965e999-27d9-48a6-9bed-251c141ce778',
-      user
+      user,
+      'edit-email-page-submit-and-return',
     ),
     goBackAndReturn: TemplateFactory.createEmailTemplate(
       '66e0051e-c201-4ec7-a318-999b4c63d3b9',
-      user
+      user,
+      'edit-email-page-go-back-and-return',
     ),
     noEmailTemplateType: TemplateFactory.create({
       id: 'e61c935f-d4ef-4bd7-b09e-3cdc6cb5923f',

tests/test-team/template-mgmt-component-tests/email/template-mgmt-preview-email-page.component.spec.ts

@@ -35,7 +35,7 @@ async function createTemplates() {
         '5f879439-f809-45a6-a77f-64e96bc34fc8',
         user
       ),
-      name: 'test-template-email',
+      name: 'valid-email-preview-template',
       subject: 'test-template-subject-line',
       message: 'test-template-message',
     },
@@ -69,7 +69,7 @@ test.describe('Preview Email message template Page', () => {
     );
 
     await expect(previewEmailTemplatePage.pageHeading).toContainText(
-      'test-template-email'
+      templates.valid.name
     );
 
     await expect(previewEmailTemplatePage.subjectLineText).toHaveText(

tests/test-team/template-mgmt-component-tests/email/template-mgmt-preview-submitted-email-page.component.spec.ts

@@ -24,19 +24,19 @@ function createTemplates(user: TestUser) {
     valid: {
       ...TemplateFactory.createEmailTemplate(
         '21f984dd-9701-466e-a166-0afeafd0a23f',
-        user
+        user,
+        'valid-email-template-preview-submitted',
       ),
-      name: 'test-template-email',
       subject: 'test-template-subject-line',
       message: 'test-template-message',
       templateStatus: 'SUBMITTED',
     },
     invalid: {
       ...TemplateFactory.createEmailTemplate(
         '201e913d-1c21-4069-a04c-a7760b3dd602',
-        user
+        user,
+        'invalid-email-template-preview-submitted',
       ),
-      name: 'test-template-email',
       subject: 'test-template-subject-line',
       message: 'test-template-message',
       templateStatus: 'NOT_YET_SUBMITTED',
@@ -72,7 +72,7 @@ test.describe('Preview submitted Email message template Page', () => {
     );
 
     await expect(previewSubmittedEmailTemplatePage.pageHeading).toContainText(
-      'test-template-email'
+      templates.valid.name
     );
 
     await expect(previewSubmittedEmailTemplatePage.subjectLineText).toHaveText(

tests/test-team/template-mgmt-component-tests/letter/template-mgmt-preview-submitted-letter-page.component.spec.ts

@@ -23,7 +23,7 @@ function createTemplates(user: TestUser) {
   const validBase = TemplateFactory.uploadLetterTemplate(
     '0b5f3591-8a36-4b33-9873-3c4842db4351',
     user,
-    'valid-email-template-preview-submitted',
+    'valid-letter-template-preview-submitted',
     'SUBMITTED'
   );
 

tests/test-team/template-mgmt-component-tests/nhs-app/template-mgmt-edit-nhs-app-template-page.component.spec.ts

@@ -20,15 +20,18 @@ function createTemplates(user: TestUser) {
   return {
     valid: TemplateFactory.createNhsAppTemplate(
       'c1597c0e-67c0-459f-bad9-3828ead548ff',
-      user
+      user,
+      'edit-nhs-app-template-valid'
     ),
     submit: TemplateFactory.createNhsAppTemplate(
       '659f83ed-6fce-4176-9f69-42274cdfed1d',
-      user
+      user,
+      'edit-nhs-app-template-submit'
     ),
     submitAndReturn: TemplateFactory.createNhsAppTemplate(
       '2570c7b5-469c-43b2-bb59-f2e5352d0001',
-      user
+      user,
+      'edit-nhs-app-template-submit-and-return'
     ),
   };
 }

tests/test-team/template-mgmt-component-tests/nhs-app/template-mgmt-preview-nhs-app-page.component.spec.ts

@@ -33,9 +33,9 @@ async function createTemplates() {
     valid: {
       ...TemplateFactory.createNhsAppTemplate(
         '825c809a-e781-4085-984b-90dc620947ba',
-        user
+        user,
+        'valid-nhs-app-preview-template',
       ),
-      name: 'test-template-nhs-app',
       message: 'test-template-message',
     },
   };
@@ -72,7 +72,7 @@ test.describe('Preview NHS App template Page', () => {
     await expect(previewNhsAppTemplatePage.submitRadioOption).not.toBeChecked();
 
     await expect(previewNhsAppTemplatePage.pageHeading).toContainText(
-      'test-template-nhs-app'
+      templates.valid.name
     );
 
     await expect(previewNhsAppTemplatePage.messageText).toHaveText(

tests/test-team/template-mgmt-component-tests/nhs-app/template-mgmt-preview-submitted-nhs-app-page.component.spec.ts

@@ -24,18 +24,18 @@ function createTemplates(user: TestUser) {
     valid: {
       ...TemplateFactory.createNhsAppTemplate(
         '298799c4-bc2c-49b6-b9cc-74e7750261d2',
-        user
+        user,
+        'valid-nhs-app-template-preview-submitted'
       ),
-      name: 'test-template-nhs-app',
       message: 'test-template-message',
       templateStatus: 'SUBMITTED',
     },
     invalid: {
       ...TemplateFactory.createNhsAppTemplate(
         'a0a0d4c9-e18d-4aa9-8973-336a66fbadde',
-        user
+        user,
+        'invalid-nhs-app-template-preview-submitted',
       ),
-      name: 'test-template-nhs-app',
       message: 'test-template-message',
       templateStatus: 'NOT_YET_SUBMITTED',
     },
@@ -71,7 +71,7 @@ test.describe('Preview submitted NHS App message template Page', () => {
     );
 
     await expect(previewSubmittedNHSAppTemplatePage.pageHeading).toContainText(
-      'test-template-nhs-app'
+      templates.valid.name
     );
 
     await expect(previewSubmittedNHSAppTemplatePage.messageText).toHaveText(

tests/test-team/template-mgmt-component-tests/sms/template-mgmt-edit-sms-page.component.spec.ts

@@ -20,19 +20,23 @@ function createTemplates(user: TestUser) {
   return {
     valid: TemplateFactory.createSmsTemplate(
       '578d292e-a4ae-411a-a7be-c2f1228b6459',
-      user
+      user,
+      'edit-sms-page-valid',
     ),
     submit: TemplateFactory.createSmsTemplate(
       '5b10cafb-ee25-47b6-85eb-540d7dc127b7',
-      user
+      user,
+      'edit-sms-page-submit',
     ),
     submitAndReturn: TemplateFactory.createSmsTemplate(
       '4a3fd84b-0685-4197-91ed-c058acbe1a61',
-      user
+      user,
+      'edit-sms-page-submit-and-return',
     ),
     goBackAndReturn: TemplateFactory.createSmsTemplate(
       '5f04230c-21df-4869-a911-7673f3b908fe',
-      user
+      user,
+      'edit-sms-page-go-back-and-return',
     ),
     noSmsTemplateType: TemplateFactory.create({
       id: 'be8a4618-17e5-45c4-855b-c91d55a3ff66',

tests/test-team/template-mgmt-component-tests/sms/template-mgmt-preview-sms-page.component.spec.ts

@@ -33,9 +33,9 @@ async function createTemplates() {
     valid: {
       ...TemplateFactory.createSmsTemplate(
         '7f41fb5b-7f59-448c-8037-f37c25466455',
-        user
+        user,
       ),
-      name: 'test-template-sms',
+      name: 'valid-sms-preview-template',
       message: 'test-template-message',
     },
   };
@@ -71,7 +71,7 @@ test.describe('Preview SMS message template Page', () => {
     await expect(previewSmsTemplatePage.submitRadioOption).not.toBeChecked();
 
     await expect(previewSmsTemplatePage.pageHeading).toContainText(
-      'test-template-sms'
+      templates.valid.name
     );
 
     await expect(previewSmsTemplatePage.messageText).toHaveText(