CCM-8590: try NEXT_PUBLIC

Author: alexnuttall

.github/workflows/stage-2-test.yaml

@@ -35,7 +35,7 @@ on:
 env:
   AWS_REGION: eu-west-2
   TERM: xterm-256color
-  ENABLE_LETTERS: true
+  NEXT_PUBLIC_ENABLE_LETTERS: true
 
 permissions:
   id-token: write # This is required for requesting the JWT

.github/workflows/stage-4-acceptance.yaml

@@ -34,7 +34,7 @@ on:
 
 env:
   AWS_REGION: eu-west-2
-  ENABLE_LETTERS: true
+  NEXT_PUBLIC_ENABLE_LETTERS: true
 
 permissions:
   id-token: write # This is required for requesting the JWT

frontend/.env.template

@@ -1,4 +1,4 @@
 # Includes auth pages when building web frontend in production mode.
 INCLUDE_AUTH_PAGES=''
 # Enables letters feature flag
-ENABLE_LETTERS=''
+NEXT_PUBLIC_ENABLE_LETTERS=''

frontend/src/__tests__/app/choose-a-template-type/page.test.tsx

@@ -37,7 +37,7 @@ test('ChooseATemplateTypePage', async () => {
 });
 
 test('ChooseATemplateTypePage - LETTER option is hidden when feature flag is not enabled', async () => {
-  delete process.env.ENABLE_LETTERS;
+  delete process.env.NEXT_PUBLIC_ENABLE_LETTERS;
 
   const page = await ChooseATemplateTypePage();
 

frontend/src/__tests__/app/copy-template/page.test.tsx

@@ -50,7 +50,7 @@ describe('CopyTemplatePage', () => {
   });
 
   it('Letter option is hidden when the feature flag is not enabled', async () => {
-    delete process.env.ENABLE_LETTERS;
+    delete process.env.NEXT_PUBLIC_ENABLE_LETTERS;
 
     getTemplateMock.mockResolvedValueOnce(template);
 

frontend/src/__tests__/app/create-letter-template/page.test.tsx

@@ -13,7 +13,7 @@ describe('CreateLetterTemplatePage', () => {
   });
 
   it('returns 404 when letters feature flag is not enabled', async () => {
-    delete process.env.ENABLE_LETTERS;
+    delete process.env.NEXT_PUBLIC_ENABLE_LETTERS;
 
     await expect(CreateLetterTemplatePage()).rejects.toThrow('NEXT_NOT_FOUND');
   });

frontend/src/app/choose-a-template-type/page.tsx

@@ -5,7 +5,7 @@ import { TemplateType } from 'nhs-notify-backend-client';
 
 const ChooseATemplateTypePage = async () => {
   const templateTypes = Object.values(TemplateType).filter(
-    (t) => process.env.ENABLE_LETTERS || t !== TemplateType.LETTER
+    (t) => process.env.NEXT_PUBLIC_ENABLE_LETTERS || t !== TemplateType.LETTER
   );
 
   return <ChooseTemplate templateTypes={templateTypes} />;

frontend/src/app/copy-template/[templateId]/page.tsx

@@ -22,7 +22,7 @@ const CopyTemplatePage = async (props: PageProps) => {
   }
 
   const templateTypes = Object.values(TemplateType).filter(
-    (t) => process.env.ENABLE_LETTERS || t !== TemplateType.LETTER
+    (t) => process.env.NEXT_PUBLIC_ENABLE_LETTERS || t !== TemplateType.LETTER
   );
 
   return (

frontend/src/app/create-letter-template/page.tsx

@@ -2,7 +2,7 @@ import { NHSNotifyMain } from '@atoms/NHSNotifyMain/NHSNotifyMain';
 import { notFound } from 'next/navigation';
 
 const CreateLetterTemplatePage = async () => {
-  if (!process.env.ENABLE_LETTERS) notFound();
+  if (!process.env.NEXT_PUBLIC_ENABLE_LETTERS) notFound();
 
   return (
     <NHSNotifyMain>

tests/test-team/global.d.ts

@@ -4,7 +4,7 @@ declare global {
       API_BASE_URL: string;
       COGNITO_USER_POOL_CLIENT_ID: string;
       COGNITO_USER_POOL_ID: string;
-      ENABLE_LETTERS: string;
+      NEXT_PUBLIC_ENABLE_LETTERS: string;
       PLAYWRIGHT_RUN_ID: string;
       TEMPLATES_TABLE_NAME: string;
     }