CCM-9874: review feedback

Author: harrim91

infrastructure/terraform/components/app/cloudfront_distribution_main.tf

@@ -1,10 +1,10 @@
 resource "aws_cloudfront_distribution" "main" {
   provider = aws.us-east-1
 
-  enabled             = true
-  is_ipv6_enabled     = true
-  comment             = "NHS Notify templates files CDN (${local.csi})"
-  default_root_object = "index.html"
+  enabled         = true
+  is_ipv6_enabled = true
+  comment         = "NHS Notify templates files CDN (${local.csi})"
+
   # https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-distributionconfig.html#cfn-cloudfront-distribution-distributionconfig-priceclass
   price_class = "PriceClass_100"
 

infrastructure/terraform/components/app/module_download_authorizer_lambda.tf

@@ -22,16 +22,15 @@ module "download_authorizer_lambda" {
     body = data.aws_iam_policy_document.authorizer.json
   }
 
-  function_s3_bucket       = local.acct.s3_buckets["artefacts_us_east_1"]["id"]
-  function_code_base_path  = local.lambdas_source_code_dir
-  function_code_dir        = "download-authorizer/dist"
-  handler_function_name    = "handler"
-  runtime                  = "nodejs20.x"
-  memory                   = 128
-  timeout                  = 3
-  lambda_at_edge           = true
-  enable_lambda_insights   = false
-  force_lambda_code_deploy = true
+  function_s3_bucket      = local.acct.s3_buckets["artefacts_us_east_1"]["id"]
+  function_code_base_path = local.lambdas_source_code_dir
+  function_code_dir       = "download-authorizer/dist"
+  handler_function_name   = "handler"
+  runtime                 = "nodejs20.x"
+  memory                  = 128
+  timeout                 = 3
+  lambda_at_edge          = true
+  enable_lambda_insights  = false
 }
 
 data "aws_iam_policy_document" "authorizer" {

lambdas/authorizer/jest.config.ts

@@ -1,5 +1,5 @@
 import type { Config } from 'jest';
-import { baseJestConfig } from 'nhs-notify-web-template-management-utils'; // eslint-disable-line no-restricted-exports
+import { baseJestConfig } from 'nhs-notify-web-template-management-utils';
 
 const config: Config = {
   ...baseJestConfig,

lambdas/download-authorizer/jest.config.ts

@@ -1,5 +1,5 @@
 import type { Config } from 'jest';
-import { baseJestConfig } from 'nhs-notify-web-template-management-utils'; // eslint-disable-line no-restricted-exports
+import { baseJestConfig } from 'nhs-notify-web-template-management-utils';
 
 const config: Config = {
   ...baseJestConfig,