CCM-14583: review

Author: bhansell1

frontend/src/app/review-and-approve-letter-template/[templateId]/page.tsx

@@ -51,7 +51,6 @@ const ReviewAndApproveLetterTemplatePage = async (props: TemplatePageProps) => {
   }
 
   if (
-    // since lock number is unchanged, the following should never be true
     !validatedTemplate.letterVariantId ||
     validatedTemplate.files.longFormRender?.status !== 'RENDERED' ||
     validatedTemplate.files.shortFormRender?.status !== 'RENDERED'

tests/test-team/template-mgmt-accessibility/letter-templates.accessibility.spec.ts

@@ -380,7 +380,10 @@ test.describe('Letter templates', () => {
         }
       ));
 
-    test('Get ready to approve letter template', async ({ page, analyze }) =>
+    test('Get ready to approve letter template page', async ({
+      page,
+      analyze,
+    }) =>
       analyze(
         new TemplateMgmtGetReadyToApproveLetterTemplatePage(page).setPathParam(
           'templateId',

tests/test-team/template-mgmt-component-tests/letter/template-mgmt-get-ready-to-approve-letter.component.spec.ts

@@ -21,9 +21,12 @@ test.describe('Get ready to approve letter template page', () => {
   const templateStorageHelper = new TemplateStorageHelper();
 
   test.beforeAll(async () => {
-    const user = await getTestContext().auth.getTestUser(
-      testUsers.User1.userId
-    );
+    const context = getTestContext();
+
+    const user = await context.auth.getTestUser(testUsers.User1.userId);
+
+    const [globalVariant] =
+      await context.letterVariants.getGlobalLetterVariants();
 
     await templateStorageHelper.seedTemplateData([
       TemplateFactory.uploadLetterTemplate(
@@ -35,7 +38,13 @@ test.describe('Get ready to approve letter template page', () => {
       TemplateFactory.createAuthoringLetterTemplate(
         templateIds.LETTER_AUTHORING,
         user,
-        `Authoring letter - ${templateIds.LETTER_AUTHORING}`
+        `Authoring letter - ${templateIds.LETTER_AUTHORING}`,
+        'NOT_YET_SUBMITTED',
+        {
+          letterVariantId: globalVariant.id,
+          shortFormRender: { status: 'RENDERED' },
+          longFormRender: { status: 'RENDERED' },
+        }
       ),
     ]);
   });
@@ -70,9 +79,7 @@ test.describe('Get ready to approve letter template page', () => {
     await assertFooterLinks(props);
   });
 
-  // TODO: CCM-14753 - unskip test then ticket is merged
-  // eslint-disable-next-line playwright/no-skipped-test
-  test.skip('when user clicks "Continue", then user is taken to review and approve letter template page', async ({
+  test('when user clicks "Continue", then user is taken to review and approve letter template page', async ({
     page,
     baseURL,
   }) => {