Skip to content

Commit 2dcafa0

Browse files
committed
pr comments
1 parent a36ba0a commit 2dcafa0

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

infrastructure/terraform/modules/backend-api/module_s3bucket_download.tf

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
module "s3bucket_download" {
1+
]module "s3bucket_download" {
22
source = "git::https://github.com/NHSDigital/nhs-notify-shared-modules.git//infrastructure/modules/s3bucket?ref=v2.0.2"
33

44
name = "download"
@@ -12,13 +12,6 @@ module "s3bucket_download" {
1212
kms_key_arn = var.kms_key_arn
1313

1414
policy_documents = [data.aws_iam_policy_document.s3bucket_download.json]
15-
16-
public_access = {
17-
block_public_acls = true
18-
block_public_policy = true
19-
ignore_public_acls = true
20-
restrict_public_buckets = true
21-
}
2215
}
2316

2417
data "aws_iam_policy_document" "s3bucket_download" {
@@ -33,10 +26,7 @@ data "aws_iam_policy_document" "s3bucket_download" {
3326
"s3:GetObject",
3427
]
3528

36-
resources = [
37-
module.s3bucket_download.arn,
38-
"${module.s3bucket_download.arn}/*",
39-
]
29+
resources = ["${module.s3bucket_download.arn}/*"]
4030

4131
principals {
4232
type = "Service"

0 commit comments

Comments
 (0)