try foreach

alexnuttall · alexnuttall · commit 364e3bcb4e08 · 2025-05-12T10:55:22.000+01:00
diff --git a/infrastructure/terraform/modules/backend-api/module_s3bucket_download.tf b/infrastructure/terraform/modules/backend-api/module_s3bucket_download.tf
@@ -35,7 +35,7 @@ resource "aws_s3_bucket_policy" "download_bucket_policy" {
 }
 
 data "aws_iam_policy_document" "s3bucket_download" {
-  count = var.cloudfront_distribution_arn != null ? 1 : 0
+  for_each = var.cloudfront_distribution_arn != null ? toset([var.cloudfront_distribution_arn]) : []
 
   statement {
     sid    = "AllowCloudFrontServicePrincipalReadOnly"

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ resource "aws_s3_bucket_policy" "download_bucket_policy" {`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`data "aws_iam_policy_document" "s3bucket_download" {`
`38`		`- count = var.cloudfront_distribution_arn != null ? 1 : 0`
	`38`	`+ for_each = var.cloudfront_distribution_arn != null ? toset([var.cloudfront_distribution_arn]) : []`
`39`	`39`
`40`	`40`	`statement {`
`41`	`41`	`sid = "AllowCloudFrontServicePrincipalReadOnly"`