Skip to content

Commit 382fda8

Browse files
committed
cleanup
1 parent c886865 commit 382fda8

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed

frontend/src/__tests__/components/forms/SubmitTemplate/__snapshots__/SubmitLetterTemplate.test.tsx.snap

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,10 @@ exports[`SubmitLetterTemplate component should render 1`] = `
1616
<h1>
1717
Approve and submit 'template-name'
1818
</h1>
19-
<p>
20-
When you submit a letter template, it will be used by NHS Notify to set up the messages you want to send
19+
<p
20+
class="nhsuk-body-l"
21+
>
22+
When you submit a letter template, it will be used by NHS Notify to set up the messages you want to send.
2123
</p>
2224
<h2
2325
class="nhsuk-heading-s"
@@ -29,10 +31,10 @@ exports[`SubmitLetterTemplate component should render 1`] = `
2931
</p>
3032
<ul>
3133
<li>
32-
appears exactly as you'd like a recipient to receieve it
34+
appears exactly as you'd like a recipient to receive it
3335
</li>
3436
<li>
35-
uses personalisation in the way yuo expect
37+
uses personalisation in the way you expect
3638
</li>
3739
<li>
3840
displays QR codes correctly (if included)
@@ -104,7 +106,7 @@ exports[`SubmitLetterTemplate component should render 1`] = `
104106
id="submit-template-button"
105107
type="submit"
106108
>
107-
Submit template
109+
Approve and submit
108110
</button>
109111
</form>
110112
</div>

frontend/src/components/forms/SubmitTemplate/SubmitLetterTemplate.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ import { submitTemplate } from '@forms/SubmitTemplate/server-action';
99
import { NHSNotifyMain } from '@atoms/NHSNotifyMain/NHSNotifyMain';
1010
import { NHSNotifyButton } from '@atoms/NHSNotifyButton/NHSNotifyButton';
1111

12+
// breaking sonarqube rules about duplication, but the code is temporary
13+
// BEGIN-NOSCAN
1214
export const SubmitLetterTemplareProofingDisabled: FC<{
1315
templateName: string;
1416
templateId: string;
@@ -84,6 +86,7 @@ export const SubmitLetterTemplareProofingDisabled: FC<{
8486
</NHSNotifyMain>
8587
);
8688
};
89+
// END-NOSCAN
8790

8891
export const SubmitLetterTemplate: FC<{
8992
templateName: string;
@@ -122,7 +125,7 @@ export const SubmitLetterTemplate: FC<{
122125
<h1>
123126
{pageHeading} {`'${templateName}'`}
124127
</h1>
125-
<p>{intro}</p>
128+
<p className='nhsuk-body-l'>{intro}</p>
126129
<h2 className='nhsuk-heading-s'>{submitChecklistHeading}</h2>
127130
<p>{submitChecklistIntroduction}</p>
128131
<ul>

frontend/src/content/content.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -374,12 +374,12 @@ const submitLetterTemplate = {
374374
},
375375
pageHeading: 'Approve and submit',
376376
intro:
377-
'When you submit a letter template, it will be used by NHS Notify to set up the messages you want to send',
377+
'When you submit a letter template, it will be used by NHS Notify to set up the messages you want to send.',
378378
submitChecklistHeading: 'Before you submit this template',
379379
submitChecklistIntroduction: 'You should check that your template proof:',
380380
submitChecklistItems: [
381-
`appears exactly as you'd like a recipient to receieve it`,
382-
'uses personalisation in the way yuo expect',
381+
`appears exactly as you'd like a recipient to receive it`,
382+
'uses personalisation in the way you expect',
383383
'displays QR codes correctly (if included)',
384384
],
385385
warningCalloutLabel: 'Important',
@@ -390,7 +390,7 @@ const submitLetterTemplate = {
390390
],
391391
goBackPath: 'preview-letter-template',
392392
goBackButtonText: submitTemplate.goBackButtonText,
393-
buttonText: submitTemplate.buttonText,
393+
buttonText: 'Approve and submit',
394394
};
395395

396396
const copyTemplate = {

0 commit comments

Comments
 (0)