CCM-8868: Fix ui-test

m-salaudeen · m-salaudeen · commit 3d9b1c64904b · 2025-03-20T08:47:05.000Z
diff --git a/frontend/src/__tests__/app/choose-a-template-type/page.test.tsx b/frontend/src/__tests__/app/choose-a-template-type/page.test.tsx
@@ -1,5 +1,7 @@
 import { render } from '@testing-library/react';
-import ChooseATemplateTypePage from '@app/choose-a-template-type/page';
+import ChooseATemplateTypePage, {
+  generateMetadata,
+} from '@app/choose-a-template-type/page';
 import { TemplateFormState } from 'nhs-notify-web-template-management-utils';
 
 jest.mock('next/navigation', () => ({
@@ -29,6 +31,7 @@ jest.mock('react', () => {
 });
 
 test('ChooseATemplateTypePage', async () => {
+  generateMetadata();
   const page = await ChooseATemplateTypePage();
 
   const container = render(page);
diff --git a/frontend/src/__tests__/app/create-email-template/page.test.tsx b/frontend/src/__tests__/app/create-email-template/page.test.tsx
@@ -1,14 +1,17 @@
 /**
  * @jest-environment node
  */
-import CreateEmailTemplatePage from '@app/create-email-template/page';
+import CreateEmailTemplatePage, {
+  generateMetadata,
+} from '@app/create-email-template/page';
 
 jest.mock('@forms/EmailTemplateForm/EmailTemplateForm');
 
 describe('CreateEmailTemplatePage', () => {
   beforeEach(jest.resetAllMocks);
 
   it('should render CreateEmailTemplatePage', async () => {
+    generateMetadata();
     const page = await CreateEmailTemplatePage();
 
     expect(page).toMatchSnapshot();
diff --git a/frontend/src/__tests__/app/create-nhs-app-template/page.test.tsx b/frontend/src/__tests__/app/create-nhs-app-template/page.test.tsx
@@ -1,14 +1,17 @@
 /**
  * @jest-environment node
  */
-import CreateNHSAppTemplatePage from '@app/create-nhs-app-template/page';
+import CreateNHSAppTemplatePage, {
+  generateMetadata,
+} from '@app/create-nhs-app-template/page';
 
 jest.mock('@forms/NhsAppTemplateForm/NhsAppTemplateForm');
 
 describe('CreateNHSAppTemplatePage', () => {
   beforeEach(jest.resetAllMocks);
 
   it('should render CreateNHSAppTemplatePage', async () => {
+    generateMetadata();
     const page = await CreateNHSAppTemplatePage();
 
     expect(page).toMatchSnapshot();
diff --git a/frontend/src/__tests__/app/create-text-message-template/page.test.tsx b/frontend/src/__tests__/app/create-text-message-template/page.test.tsx
@@ -1,14 +1,17 @@
 /**
  * @jest-environment node
  */
-import CreateSMSTemplatePage from '@app/create-text-message-template/page';
+import CreateSMSTemplatePage, {
+  generateMetadata,
+} from '@app/create-text-message-template/page';
 
 jest.mock('@forms/SmsTemplateForm/SmsTemplateForm');
 
 describe('CreateSMSTemplatePage', () => {
   beforeEach(jest.resetAllMocks);
 
   it('should render CreateSMSTemplatePage', async () => {
+    generateMetadata();
     const page = await CreateSMSTemplatePage();
 
     expect(page).toMatchSnapshot();
diff --git a/frontend/src/__tests__/app/edit-nhs-app-template/page.test.tsx b/frontend/src/__tests__/app/edit-nhs-app-template/page.test.tsx
@@ -5,7 +5,9 @@ import { redirect } from 'next/navigation';
 import { NHSAppTemplate } from 'nhs-notify-web-template-management-utils';
 import { getTemplate } from '@utils/form-actions';
 import { NhsAppTemplateForm } from '@forms/NhsAppTemplateForm/NhsAppTemplateForm';
-import EditNhsAppTemplatePage from '@app/edit-nhs-app-template/[templateId]/page';
+import EditNhsAppTemplatePage, {
+  generateMetadata,
+} from '@app/edit-nhs-app-template/[templateId]/page';
 import { TemplateDto } from 'nhs-notify-backend-client';
 import { EMAIL_TEMPLATE, LETTER_TEMPLATE, SMS_TEMPLATE } from '../../helpers';
 
@@ -17,6 +19,7 @@ const getTemplateMock = jest.mocked(getTemplate);
 const redirectMock = jest.mocked(redirect);
 
 describe('EditNhsAppTemplatePage', () => {
+  generateMetadata();
   beforeEach(jest.resetAllMocks);
 
   test('page loads', async () => {
diff --git a/frontend/src/__tests__/app/email-template-submitted/page.test.tsx b/frontend/src/__tests__/app/email-template-submitted/page.test.tsx
@@ -1,7 +1,9 @@
 /**
  * @jest-environment node
  */
-import EmailTemplateSubmittedPage from '@app/email-template-submitted/[templateId]/page';
+import EmailTemplateSubmittedPage, {
+  generateMetadata,
+} from '@app/email-template-submitted/[templateId]/page';
 import { TemplateSubmitted } from '@molecules/TemplateSubmitted/TemplateSubmitted';
 import { getTemplate } from '@utils/form-actions';
 import { redirect } from 'next/navigation';
@@ -48,6 +50,7 @@ describe('EmailTemplateSubmittedPage', () => {
   });
 
   test('should handle invalid template', async () => {
+    generateMetadata();
     getTemplateMock.mockResolvedValueOnce(undefined);
 
     await EmailTemplateSubmittedPage({
diff --git a/frontend/src/__tests__/app/nhs-app-template-submitted/page.test.tsx b/frontend/src/__tests__/app/nhs-app-template-submitted/page.test.tsx
@@ -1,7 +1,9 @@
 /**
  * @jest-environment node
  */
-import NhsAppTemplateSubmittedPage from '@app/nhs-app-template-submitted/[templateId]/page';
+import NhsAppTemplateSubmittedPage, {
+  generateMetadata,
+} from '@app/nhs-app-template-submitted/[templateId]/page';
 import { TemplateSubmitted } from '@molecules/TemplateSubmitted/TemplateSubmitted';
 import { getTemplate } from '@utils/form-actions';
 import { redirect } from 'next/navigation';
@@ -18,6 +20,7 @@ describe('NhsAppTemplateSubmittedPage', () => {
   beforeEach(jest.resetAllMocks);
 
   test('should load page', async () => {
+    generateMetadata();
     const template = {
       id: 'template-id',
       templateType: 'NHS_APP',
diff --git a/frontend/src/__tests__/app/preview-email-template/page.test.tsx b/frontend/src/__tests__/app/preview-email-template/page.test.tsx
@@ -1,7 +1,9 @@
 /**
  * @jest-environment node
  */
-import PreviewEmailTemplatePage from '@app/preview-email-template/[templateId]/page';
+import PreviewEmailTemplatePage, {
+  generateMetadata,
+} from '@app/preview-email-template/[templateId]/page';
 import { PreviewEmailTemplate } from '@forms/PreviewEmailTemplate';
 import { EmailTemplate } from 'nhs-notify-web-template-management-utils';
 import { redirect } from 'next/navigation';
@@ -25,6 +27,7 @@ describe('PreviewEmailTemplatePage', () => {
   beforeEach(jest.resetAllMocks);
 
   it('should load page', async () => {
+    generateMetadata();
     const templateDTO = {
       id: 'template-id',
       templateType: 'EMAIL',
diff --git a/frontend/src/__tests__/app/preview-nhs-app-template/page.test.tsx b/frontend/src/__tests__/app/preview-nhs-app-template/page.test.tsx
@@ -1,7 +1,9 @@
 /**
  * @jest-environment node
  */
-import PreviewNhsAppTemplatePage from '@app/preview-nhs-app-template/[templateId]/page';
+import PreviewNhsAppTemplatePage, {
+  generateMetadata,
+} from '@app/preview-nhs-app-template/[templateId]/page';
 import { PreviewNHSAppTemplate } from '@forms/PreviewNHSAppTemplate/PreviewNHSAppTemplate';
 import { NHSAppTemplate } from 'nhs-notify-web-template-management-utils';
 import { redirect } from 'next/navigation';
@@ -25,6 +27,7 @@ describe('PreviewNhsAppTemplatePage', () => {
   beforeEach(jest.resetAllMocks);
 
   it('should load page', async () => {
+    generateMetadata();
     const templateDTO = {
       id: 'template-id',
       templateType: 'NHS_APP',
diff --git a/frontend/src/__tests__/app/preview-text-message-template/page.test.tsx b/frontend/src/__tests__/app/preview-text-message-template/page.test.tsx
@@ -1,7 +1,9 @@
 /**
  * @jest-environment node
  */
-import PreviewSMSTemplatePage from '@app/preview-text-message-template/[templateId]/page';
+import PreviewSMSTemplatePage, {
+  generateMetadata,
+} from '@app/preview-text-message-template/[templateId]/page';
 import { PreviewSMSTemplate } from '@forms/PreviewSMSTemplate';
 import { SMSTemplate } from 'nhs-notify-web-template-management-utils';
 import { redirect } from 'next/navigation';
@@ -25,6 +27,7 @@ describe('PreviewSMSTemplatePage', () => {
   beforeEach(jest.resetAllMocks);
 
   it('should load page', async () => {
+    generateMetadata();
     const templateDTO = {
       id: 'template-id',
       templateType: 'SMS',
diff --git a/frontend/src/__tests__/app/submit-email-template/page.test.tsx b/frontend/src/__tests__/app/submit-email-template/page.test.tsx
@@ -1,7 +1,9 @@
 /**
  * @jest-environment node
  */
-import SubmitEmailTemplatePage from '@app/submit-email-template/[templateId]/page';
+import SubmitEmailTemplatePage, {
+  generateMetadata,
+} from '@app/submit-email-template/[templateId]/page';
 import { SubmitTemplate } from '@forms/SubmitTemplate/SubmitTemplate';
 import { redirect } from 'next/navigation';
 import { getTemplate } from '@utils/form-actions';
@@ -19,6 +21,7 @@ describe('SubmitEmailTemplatePage', () => {
   beforeEach(jest.resetAllMocks);
 
   test('should load page', async () => {
+    generateMetadata();
     const state = {
       id: 'template-id',
       templateType: 'EMAIL',
diff --git a/frontend/src/__tests__/app/submit-nhs-app-template/page.test.tsx b/frontend/src/__tests__/app/submit-nhs-app-template/page.test.tsx
@@ -1,7 +1,9 @@
 /**
  * @jest-environment node
  */
-import SubmitNhsAppTemplatePage from '@app/submit-nhs-app-template/[templateId]/page';
+import SubmitNhsAppTemplatePage, {
+  generateMetadata,
+} from '@app/submit-nhs-app-template/[templateId]/page';
 import { SubmitTemplate } from '@forms/SubmitTemplate/SubmitTemplate';
 import { redirect } from 'next/navigation';
 import { getTemplate } from '@utils/form-actions';
@@ -24,6 +26,7 @@ describe('SubmitNhsAppTemplatePage', () => {
   beforeEach(jest.resetAllMocks);
 
   test('should load page', async () => {
+    generateMetadata();
     const state = {
       id: 'template-id',
       templateType: 'NHS_APP',
diff --git a/frontend/src/__tests__/app/submit-text-message-template/page.test.tsx b/frontend/src/__tests__/app/submit-text-message-template/page.test.tsx
@@ -1,7 +1,9 @@
 /**
  * @jest-environment node
  */
-import SubmitSmsTemplatePage from '@app/submit-text-message-template/[templateId]/page';
+import SubmitSmsTemplatePage, {
+  generateMetadata,
+} from '@app/submit-text-message-template/[templateId]/page';
 import { SubmitTemplate } from '@forms/SubmitTemplate/SubmitTemplate';
 import { redirect } from 'next/navigation';
 import { getTemplate } from '@utils/form-actions';
@@ -24,6 +26,7 @@ describe('SubmitSmsTemplatePage', () => {
   beforeEach(jest.resetAllMocks);
 
   test('should load page', async () => {
+    generateMetadata();
     const state = {
       id: 'template-id',
       templateType: 'SMS',
diff --git a/frontend/src/__tests__/app/text-message-template-submitted/page.test.tsx b/frontend/src/__tests__/app/text-message-template-submitted/page.test.tsx
@@ -1,7 +1,9 @@
 /**
  * @jest-environment node
  */
-import SmsTemplateSubmittedPage from '@app/text-message-template-submitted/[templateId]/page';
+import SmsTemplateSubmittedPage, {
+  generateMetadata,
+} from '@app/text-message-template-submitted/[templateId]/page';
 import { TemplateSubmitted } from '@molecules/TemplateSubmitted/TemplateSubmitted';
 import { getTemplate } from '@utils/form-actions';
 import { redirect } from 'next/navigation';
@@ -18,6 +20,7 @@ describe('TextMessageTemplateSubmittedPage', () => {
   beforeEach(jest.resetAllMocks);
 
   test('should load page', async () => {
+    generateMetadata();
     const template = {
       id: 'template-id',
       templateType: 'SMS',
diff --git a/frontend/src/__tests__/components/molecules/__snapshots__/ManageTemplates.test.tsx.snap b/frontend/src/__tests__/components/molecules/__snapshots__/ManageTemplates.test.tsx.snap
@@ -143,28 +143,20 @@ exports[`ManageTemplates component matches snapshot with not submitted status 1`
                   class="nhsuk-u-margin-bottom-2"
                 >
                   <a
+                    aria-label="Copy Template 1"
                     href="/copy-template/1"
                     id="copy-template-link-0"
                   >
-                    <span
-                      class="nhsuk-u-visually-hidden"
-                    >
-                      Template 1
-                    </span>
                     Copy
                   </a>
                 </p>
                 <p
                   class="nhsuk-u-margin-bottom-2"
                 >
                   <a
+                    aria-label="Delete Template 1"
                     href="/delete-template/1"
                   >
-                    <span
-                      class="nhsuk-u-visually-hidden"
-                    >
-                      Template 1
-                    </span>
                     Delete
                   </a>
                 </p>
@@ -249,14 +241,10 @@ exports[`ManageTemplates component matches snapshot with not submitted status 1`
                   class="nhsuk-u-margin-bottom-2"
                 >
                   <a
+                    aria-label="Copy Template 2"
                     href="/copy-template/2"
                     id="copy-template-link-1"
                   >
-                    <span
-                      class="nhsuk-u-visually-hidden"
-                    >
-                      Template 2
-                    </span>
                     Copy
                   </a>
                 </p>
@@ -489,14 +477,10 @@ exports[`ManageTemplates component matches snapshot with submitted status 1`] =
                   class="nhsuk-u-margin-bottom-2"
                 >
                   <a
+                    aria-label="Copy Template 1"
                     href="/copy-template/1"
                     id="copy-template-link-0"
                   >
-                    <span
-                      class="nhsuk-u-visually-hidden"
-                    >
-                      Template 1
-                    </span>
                     Copy
                   </a>
                 </p>
@@ -581,14 +565,10 @@ exports[`ManageTemplates component matches snapshot with submitted status 1`] =
                   class="nhsuk-u-margin-bottom-2"
                 >
                   <a
+                    aria-label="Copy Template 2"
                     href="/copy-template/2"
                     id="copy-template-link-1"
                   >
-                    <span
-                      class="nhsuk-u-visually-hidden"
-                    >
-                      Template 2
-                    </span>
                     Copy
                   </a>
                 </p>
diff --git a/frontend/src/components/molecules/ManageTemplates/ManageTemplates.tsx b/frontend/src/components/molecules/ManageTemplates/ManageTemplates.tsx
@@ -100,20 +100,18 @@ export function ManageTemplates({
                         <Link
                           href={`/copy-template/${template.id}`}
                           id={`copy-template-link-${index}`}
+                          aria-label={`${manageTemplatesContent.tableHeadings.action.copy} ${template.name}`}
                         >
-                          <span className='nhsuk-u-visually-hidden'>
-                            {template.name}
-                          </span>
                           {manageTemplatesContent.tableHeadings.action.copy}
                         </Link>
                       </p>
                     )}
                     {template.templateStatus === 'NOT_YET_SUBMITTED' ? (
                       <p className='nhsuk-u-margin-bottom-2'>
-                        <Link href={`/delete-template/${template.id}`}>
-                          <span className='nhsuk-u-visually-hidden'>
-                            {template.name}
-                          </span>
+                        <Link
+                          href={`/delete-template/${template.id}`}
+                          aria-label={`${manageTemplatesContent.tableHeadings.action.delete} ${template.name}`}
+                        >
                           {manageTemplatesContent.tableHeadings.action.delete}
                         </Link>
                       </p>
diff --git a/utils/utils/src/types.ts b/utils/utils/src/types.ts
@@ -6,7 +6,6 @@ import {
   SmsProperties,
   TemplateDto,
 } from 'nhs-notify-backend-client';
-import { TemplateType } from 'nhs-notify-backend-client';
 
 export type FormId =
   | 'choose-a-template-type'
