CCM-12327: increment lock number on sftp updates

Author: harrim91

lambdas/sftp-letters/src/__tests__/infra/template-lock-repository.test.ts

@@ -44,11 +44,13 @@ describe('TemplateLockRepository', () => {
           '#sftpSendLockTime': 'sftpSendLockTime',
           '#supplier': 'supplier',
           '#supplierReferences': 'supplierReferences',
+          '#lockNumber': 'lockNumber',
         },
         ExpressionAttributeValues: {
           ':condition_2_sftpSendLockTime': mockDate.getTime() + sendLockTtlMs,
           ':sftpSendLockTime': mockDate.getTime(),
           ':supplier': 'supplier-reference',
+          ':lockNumber': 1,
         },
         ConditionExpression:
           'attribute_not_exists (#sftpSendLockTime) OR #sftpSendLockTime > :condition_2_sftpSendLockTime',
@@ -58,7 +60,7 @@ describe('TemplateLockRepository', () => {
         },
         TableName: templatesTableName,
         UpdateExpression:
-          'SET #sftpSendLockTime = :sftpSendLockTime, #supplierReferences.#supplier = :supplier',
+          'SET #sftpSendLockTime = :sftpSendLockTime, #supplierReferences.#supplier = :supplier ADD #lockNumber :lockNumber',
       });
     });
 
@@ -109,16 +111,19 @@ describe('TemplateLockRepository', () => {
       expect(mocks.client).toHaveReceivedCommandWith(UpdateCommand, {
         ExpressionAttributeNames: {
           '#sftpSendLockTime': 'sftpSendLockTime',
+          '#lockNumber': 'lockNumber',
         },
         ExpressionAttributeValues: {
           ':sftpSendLockTime': mockDate.getTime() + 2_592_000_000,
+          ':lockNumber': 1,
         },
         Key: {
           id: templateId,
           owner: `CLIENT#${clientId}`,
         },
         TableName: templatesTableName,
-        UpdateExpression: 'SET #sftpSendLockTime = :sftpSendLockTime',
+        UpdateExpression:
+          'SET #sftpSendLockTime = :sftpSendLockTime ADD #lockNumber :lockNumber',
       });
     });
   });

lambdas/sftp-letters/src/infra/template-lock-repository.ts

@@ -12,7 +12,6 @@ export class TemplateLockRepository {
     private readonly lockTtl: number
   ) {}
 
-  // TODO: CCM-12327
   async acquireLockAndSetSupplierReference(
     clientId: string,
     id: string,
@@ -28,6 +27,7 @@ export class TemplateLockRepository {
     )
       .setLockTime('sftpSendLockTime', time, time + this.lockTtl)
       .setSupplierReference(supplier, supplierReference)
+      .incrementLockNumber()
       .build();
 
     try {
@@ -42,7 +42,6 @@ export class TemplateLockRepository {
     return true;
   }
 
-  // TODO: CCM-12327
   async finaliseLock(clientId: string, id: string) {
     const time = this.getDate().getTime();
 
@@ -52,6 +51,7 @@ export class TemplateLockRepository {
       id
     )
       .setLockTimeUnconditional('sftpSendLockTime', time + THIRTY_DAYS_MS)
+      .incrementLockNumber()
       .build();
 
     return await this.client.send(new UpdateCommand(update));