fix missing owner

Author: alexnuttall

frontend/src/__tests__/components/molecules/PreviewTemplateDetails.test.tsx

@@ -219,6 +219,13 @@ describe('PreviewTemplateDetailsLetter', () => {
               currentVersion: '4C728B7D-A028-4BA2-B180-A63CDD2AE1E9',
               virusScanStatus: 'PASSED',
             },
+            proofs: {
+              'a.pdf': {
+                fileName: 'a.pdf',
+                virusScanStatus: 'PASSED',
+                supplier: 'MBA',
+              },
+            },
           },
           createdAt: '2025-01-13T10:19:25.579Z',
           updatedAt: '2025-01-13T10:19:25.579Z',

frontend/src/__tests__/components/molecules/__snapshots__/PreviewTemplateDetails.test.tsx.snap

@@ -215,6 +215,58 @@ exports[`PreviewTemplateDetailsLetter If the template is client-owned, the clien
         </dd>
       </div>
     </dl>
+    <dl
+      class="nhsuk-summary-list nhsuk-u-margin-bottom-4 preview"
+    >
+      <div
+        class="nhsuk-summary-list__row"
+      >
+        <dt
+          class="nhsuk-summary-list__key"
+        >
+          Template proof files
+        </dt>
+        <dd
+          class="nhsuk-summary-list__value"
+        >
+          <ul
+            class="proofs"
+          >
+            <li>
+              <a
+                data-testid="proof-link_a.pdf"
+                href="/templates/files/client/proofs/template-id/a.pdf"
+                rel="noopener noreferrer"
+                target="_blank"
+              >
+                <div
+                  class="container"
+                >
+                  <svg
+                    class="icon"
+                    fill="none"
+                    height="26"
+                    viewBox="0 0 20 26"
+                    width="20"
+                    xmlns="http://www.w3.org/2000/svg"
+                  >
+                    <path
+                      d="M0 0V26H20V6.59375L19.7188 6.28125L13.7188 0.28125L13.4062 0H0ZM2 2H12V8H18V24H2V2ZM14 3.4375L16.5625 6H14V3.4375Z"
+                      fill="#4C6272"
+                    />
+                  </svg>
+                  <p
+                    class="text"
+                  >
+                    a.pdf
+                  </p>
+                </div>
+              </a>
+            </li>
+          </ul>
+        </dd>
+      </div>
+    </dl>
   </div>
 </DocumentFragment>
 `;

frontend/src/components/molecules/PreviewTemplateDetails/PreviewTemplateDetailsLetter.tsx

@@ -17,6 +17,8 @@ export default function PreviewTemplateDetailsLetter({
 }: {
   template: LetterTemplate;
 }) {
+  console.log(template);
+
   const proofFilenames = Object.values(template.files.proofs ?? {})
     .filter(({ virusScanStatus }) => virusScanStatus === 'PASSED')
     .map(({ fileName }) => fileName);
@@ -28,7 +30,7 @@ export default function PreviewTemplateDetailsLetter({
     template.owner;
 
   const owner = template.owner ?? '';
-  const proofOwner = owner.startsWith('CLIENT#') ? owner.slice(6) : owner;
+  const proofOwner = owner.startsWith('CLIENT#') ? owner.slice(7) : owner;
 
   return (
     <>

infrastructure/terraform/modules/backend-api/module_get_template_lambda.tf

@@ -40,7 +40,7 @@ data "aws_iam_policy_document" "get_template_lambda_policy" {
     effect = "Allow"
 
     actions = [
-      "dynamodb:GetItem",
+      "dynamodb:BatchGetItem",
     ]
 
     resources = [

infrastructure/terraform/modules/backend-api/module_lambda_validate_letter_template_files.tf

@@ -55,7 +55,7 @@ data "aws_iam_policy_document" "validate_letter_template_files" {
     effect = "Allow"
 
     actions = [
-      "dynamodb:GetItem",
+      "dynamodb:BatchGetItem",
       "dynamodb:UpdateItem",
     ]
 

lambdas/backend-api/src/__tests__/templates/app/template-client.test.ts

@@ -378,7 +378,7 @@ describe('templateClient', () => {
         updatedAt: updateTime,
       };
 
-      const { owner: _1, version: _2, ...expectedDto } = finalTemplate;
+      const { version: _, ...expectedDto } = finalTemplate;
 
       mocks.templateRepository.create.mockResolvedValueOnce({
         data: initialCreatedTemplate,
@@ -486,7 +486,7 @@ describe('templateClient', () => {
         updatedAt: updateTime,
       };
 
-      const { owner: _1, version: _2, ...expectedDto } = finalTemplate;
+      const { version: _, ...expectedDto } = finalTemplate;
 
       mocks.templateRepository.create.mockResolvedValueOnce({
         data: initialCreatedTemplate,

lambdas/backend-api/src/templates/app/template-client.ts

@@ -521,7 +521,7 @@ export class TemplateClient {
   private mapDatabaseObjectToDTO(
     databaseTemplate: DatabaseTemplate
   ): TemplateDto | undefined {
-    const { owner: _1, version: _2, ...templateDTO } = databaseTemplate;
+    const { version: _, ...templateDTO } = databaseTemplate;
 
     return isTemplateDtoValid(templateDTO);
   }