CCM-11492 Refactor api client and remove redundant code

Author: nicki-nhs

frontend/src/components/forms/MessagePlan/server-action.ts

@@ -1,8 +1,7 @@
-import { ApplicationResult, failure, success } from '@backend-api/utils/result';
+import { failure } from '@backend-api/utils/result';
 import {
   $CreateUpdateRoutingConfig,
   $ListRoutingConfigFilters,
-  type CreateUpdateRoutingConfig,
   ErrorCase,
   type ListRoutingConfigFilters,
   type Result,
@@ -213,26 +212,4 @@ export class RoutingConfigClient {
 
     return query.count();
   }
-
-  private async validateCampaignId(
-    clientId: string,
-    data: CreateUpdateRoutingConfig
-  ): Promise<ApplicationResult<null>> {
-    const clientConfigurationResult =
-      await this.clientConfigRepository.get(clientId);
-
-    const { data: clientConfiguration, error: clientConfigurationError } =
-      clientConfigurationResult;
-
-    if (clientConfigurationError) return clientConfigurationResult;
-
-    if (!clientConfiguration?.campaignIds?.includes(data.campaignId)) {
-      return failure(
-        ErrorCase.VALIDATION_FAILED,
-        'Invalid campaign ID in request'
-      );
-    }
-
-    return success(null);
-  }
 }

lambdas/backend-api/src/templates/app/routing-config-client.ts

@@ -2,7 +2,7 @@ import MockAdapter from 'axios-mock-adapter';
 import {
   isValidUuid,
   routingConfigurationApiClient as client,
-  axiosClient,
+  httpClient,
 } from '../routing-config-api-client';
 import { RoutingConfig, RoutingConfigStatus } from '../types/generated';
 import { ErrorCase } from '../types/error-cases';
@@ -12,7 +12,7 @@ const notFoundRoutingConfigId = '3b5d7f9a-1c2e-4b3d-8f0a-6e7d8c9b0a1f';
 const invalidRoutingConfigId = 'not-a-uuid';
 
 describe('RoutingConfigurationApiClient', () => {
-  const axiosMock = new MockAdapter(axiosClient);
+  const axiosMock = new MockAdapter(httpClient);
 
   beforeEach(() => {
     axiosMock.reset();

lambdas/backend-client/src/__tests__/routing-config-api-client.test.ts

@@ -1,5 +1,3 @@
-export * from './client-configuration-api-client';
-export * from './routing-config-api-client';
 export * from './schemas/client';
 export * from './schemas/routing-config';
 export * from './schemas/schema-for';

lambdas/backend-client/src/index.ts

@@ -21,9 +21,9 @@ export function isValidUuid(id: string): boolean {
   );
 }
 
-export const axiosClient = createAxiosClient();
+export const httpClient = createAxiosClient();
 
-class RoutingConfigurationApiClient {
+export const routingConfigurationApiClient = {
   async create(
     routingConfig: Pick<
       RoutingConfig,
@@ -35,7 +35,7 @@ class RoutingConfigurationApiClient {
       '/v1/routing-configuration' satisfies PostV1RoutingConfigurationData['url'];
 
     const response = await catchAxiosError(
-      axiosClient.post<RoutingConfigSuccess>(url, routingConfig, {
+      httpClient.post<RoutingConfigSuccess>(url, routingConfig, {
         headers: {
           'Content-Type': 'application/json',
           Authorization: token,
@@ -52,7 +52,7 @@ class RoutingConfigurationApiClient {
     return {
       data: response.data.data,
     };
-  }
+  },
 
   async count(
     token: string,
@@ -62,7 +62,7 @@ class RoutingConfigurationApiClient {
       '/v1/routing-configurations/count' satisfies GetV1RoutingConfigurationsCountData['url'];
 
     const { data, error } = await catchAxiosError(
-      axiosClient.get<CountSuccess>(url, {
+      httpClient.get<CountSuccess>(url, {
         headers: { Authorization: token },
         params: { status },
       })
@@ -73,7 +73,7 @@ class RoutingConfigurationApiClient {
     }
 
     return { ...data };
-  }
+  },
 
   async get(
     token: string,
@@ -97,7 +97,7 @@ class RoutingConfigurationApiClient {
     >;
 
     const { data, error } = await catchAxiosError(
-      axiosClient.get<RoutingConfigSuccess>(url, {
+      httpClient.get<RoutingConfigSuccess>(url, {
         headers: { Authorization: token },
       })
     );
@@ -107,14 +107,14 @@ class RoutingConfigurationApiClient {
     }
 
     return { ...data };
-  }
+  },
 
   async list(token: string): Promise<Result<RoutingConfig[]>> {
     const url =
       '/v1/routing-configurations' satisfies GetV1RoutingConfigurationsData['url'];
 
     const { data, error } = await catchAxiosError(
-      axiosClient.get<RoutingConfigSuccessList>(url, {
+      httpClient.get<RoutingConfigSuccessList>(url, {
         headers: { Authorization: token },
       })
     );
@@ -124,7 +124,7 @@ class RoutingConfigurationApiClient {
     }
 
     return { ...data };
-  }
+  },
 
   async update(
     token: string,
@@ -148,7 +148,7 @@ class RoutingConfigurationApiClient {
     >;
 
     const { data, error } = await catchAxiosError(
-      axiosClient.put<RoutingConfigSuccess>(url, routingConfig, {
+      httpClient.put<RoutingConfigSuccess>(url, routingConfig, {
         headers: { Authorization: token },
       })
     );
@@ -158,8 +158,5 @@ class RoutingConfigurationApiClient {
     }
 
     return { ...data };
-  }
-}
-
-export const routingConfigurationApiClient =
-  new RoutingConfigurationApiClient();
+  },
+};