CCM-11453: message plan list page (#697)

Co-authored-by: alex.nuttall1 <[email protected]>

Author: bhansell1

.github/workflows/stage-2-test.yaml

@@ -74,6 +74,8 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 5
     needs: [discover-workspaces]
+    env:
+      TZ: Europe/London
     strategy:
       fail-fast: false
       matrix:

data-migration/user-transfer/src/migrate.ts

@@ -126,6 +126,7 @@ export async function migrate(params: MigrateParameters) {
   const filename = `${name}-${params.dryRun ? 'dryrun' : 'run'}${ext}`;
   const data = JSON.stringify(output);
 
+  // eslint-disable-next-line security/detect-non-literal-fs-filename
   writeFileSync(path.join(dir, filename), data);
 
   await writeRemote(

data-migration/user-transfer/src/plan.ts

@@ -71,6 +71,7 @@ export async function plan(params: PlanParameters) {
 
   await writeRemote(path, data, templatesS3BackupBucketName);
 
+  // eslint-disable-next-line security/detect-non-literal-fs-filename
   writeFileSync(`./migrations/${filename}.json`, data);
 
   print(`Results written to ${filename}.json`);

frontend/src/__tests__/app/message-plans/page.test.tsx

@@ -0,0 +1,113 @@
+/**
+ * @jest-environment node
+ */
+import { getRoutingConfigs, countRoutingConfigs } from '@utils/message-plans';
+import {
+  type MessagePlansProps,
+  MessagePlans,
+} from '@molecules/MessagePlans/MessagePlans';
+import { serverIsFeatureEnabled } from '@utils/server-features';
+import MessagePlansPage, { generateMetadata } from '@app/message-plans/page';
+import { ReactElement } from 'react';
+import { RoutingConfig } from 'nhs-notify-backend-client';
+
+jest.mock('@utils/message-plans');
+jest.mock('@utils/server-features');
+
+const countRoutingConfigsMock = jest.mocked(countRoutingConfigs);
+const serverIsFeatureEnabledMock = jest.mocked(serverIsFeatureEnabled);
+const getRoutingConfigsMock = jest.mocked(getRoutingConfigs);
+
+const buildRoutingConfig = (rc: Partial<RoutingConfig>): RoutingConfig => ({
+  campaignId: 'abc',
+  cascade: [],
+  cascadeGroupOverrides: [],
+  clientId: 'client-a',
+  createdAt: '2025-09-09T10:00:00Z',
+  status: 'DRAFT',
+  id: '',
+  name: '',
+  updatedAt: '',
+  ...rc,
+});
+
+describe('MessagePlansPage', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+    serverIsFeatureEnabledMock.mockResolvedValueOnce(true);
+  });
+
+  test('page metadata', async () => {
+    const metadata = await generateMetadata();
+
+    expect(metadata).toEqual({
+      title: 'Message plans - NHS Notify',
+    });
+  });
+
+  test('renders the page with drafts and production routing plans', async () => {
+    getRoutingConfigsMock.mockResolvedValueOnce([
+      buildRoutingConfig({
+        id: '1',
+        name: 'Draft A',
+        updatedAt: '2025-09-10T10:00:00Z',
+        status: 'DRAFT',
+      }),
+      buildRoutingConfig({
+        id: '2',
+        name: 'Prod X',
+        updatedAt: '2025-09-09T11:00:00Z',
+        status: 'COMPLETED',
+      }),
+      buildRoutingConfig({
+        id: '3',
+        name: 'Prod Y',
+        updatedAt: '2025-09-08T12:00:00Z',
+        status: 'COMPLETED',
+      }),
+    ]);
+
+    countRoutingConfigsMock.mockResolvedValueOnce(1).mockResolvedValueOnce(2);
+
+    const page = (await MessagePlansPage()) as ReactElement<
+      MessagePlansProps,
+      typeof MessagePlans
+    >;
+
+    expect(getRoutingConfigsMock).toHaveBeenCalledTimes(1);
+
+    expect(countRoutingConfigsMock).toHaveBeenNthCalledWith(1, 'DRAFT');
+
+    expect(countRoutingConfigsMock).toHaveBeenNthCalledWith(2, 'COMPLETED');
+
+    expect(page.props.draft).toEqual({
+      plans: [
+        {
+          id: '1',
+          name: 'Draft A',
+          lastUpdated: '2025-09-10T10:00:00Z',
+          status: 'DRAFT',
+        },
+      ],
+      count: 1,
+    });
+
+    expect(page.props.production).toEqual({
+      plans: [
+        {
+          id: '2',
+          name: 'Prod X',
+          lastUpdated: '2025-09-09T11:00:00Z',
+          status: 'COMPLETED',
+        },
+        {
+          id: '3',
+          name: 'Prod Y',
+          lastUpdated: '2025-09-08T12:00:00Z',
+          status: 'COMPLETED',
+        },
+      ],
+      count: 2,
+    });
+  });
+});

frontend/src/__tests__/components/forms/EmailTemplateForm/server-action.test.ts

@@ -14,7 +14,7 @@ const createTemplateMock = jest.mocked(createTemplate);
 const redirectMock = jest.mocked(redirect);
 
 const initialState: EmailTemplate = {
-  id: 'template-id',
+  id: '89cc73bb-6d61-4b8b-a728-b5e40f0751fd',
   templateType: 'EMAIL',
   templateStatus: 'NOT_YET_SUBMITTED',
   name: 'name',
@@ -109,25 +109,52 @@ describe('CreateEmailTemplate server actions', () => {
       })
     );
 
-    expect(saveTemplateMock).toHaveBeenCalledWith({
+    expect(saveTemplateMock).toHaveBeenCalledWith(initialState.id, {
       ...initialState,
       name: 'template-name',
       subject: 'template-subject-line',
       message: 'template-message',
     });
 
     expect(redirectMock).toHaveBeenCalledWith(
-      '/preview-email-template/template-id?from=edit',
+      `/preview-email-template/${initialState.id}?from=edit`,
       'push'
     );
   });
 
+  test('redirects to invalid-template if the ID in formState is not a uuid', async () => {
+    const badIdState = {
+      ...initialState,
+      id: 'non-uuid',
+      name: 'template-name',
+      subject: 'template-subject-line',
+      message: 'template-message',
+      createdAt: '2025-01-13T10:19:25.579Z',
+      updatedAt: '2025-01-13T10:19:25.579Z',
+    };
+
+    await processFormActions(
+      badIdState,
+      getMockFormData({
+        emailTemplateName: 'template-name',
+        emailTemplateSubjectLine: 'template-subject-line',
+        emailTemplateMessage: 'template-message',
+      })
+    );
+
+    expect(saveTemplateMock).not.toHaveBeenCalled();
+
+    expect(redirectMock).toHaveBeenCalledWith('/invalid-template', 'replace');
+  });
+
   test('should create the template and redirect', async () => {
     const { id: _, ...initialDraftState } = initialState; // eslint-disable-line sonarjs/no-unused-vars
 
+    const generatedId = '06c6fb58-e749-4ee4-8343-57d7f7ecfe1f';
+
     createTemplateMock.mockResolvedValue({
       ...initialDraftState,
-      id: 'new-template-id',
+      id: generatedId,
       name: 'template-name',
       subject: 'template-subject-line',
       message: 'template-message',
@@ -152,7 +179,7 @@ describe('CreateEmailTemplate server actions', () => {
     });
 
     expect(redirectMock).toHaveBeenCalledWith(
-      '/preview-email-template/new-template-id?from=edit',
+      `/preview-email-template/${generatedId}?from=edit`,
       'push'
     );
   });

frontend/src/__tests__/components/forms/NhsAppTemplateForm/server-action.test.ts

@@ -1,6 +1,6 @@
 import { getMockFormData } from '@testhelpers';
 import { saveTemplate, createTemplate } from '@utils/form-actions';
-import {
+import type {
   NHSAppTemplate,
   CreateUpdateNHSAppTemplate,
 } from 'nhs-notify-web-template-management-utils';
@@ -23,7 +23,7 @@ const initialState: CreateUpdateNHSAppTemplate = {
 
 const savedState: NHSAppTemplate = {
   ...initialState,
-  id: 'template-id',
+  id: 'a28c9e75-d6c9-4efe-879e-e082238938cf',
   templateStatus: 'NOT_YET_SUBMITTED',
   createdAt: '2025-01-13T10:19:25.579Z',
   updatedAt: '2025-01-13T10:19:25.579Z',
@@ -130,18 +130,37 @@ describe('CreateNHSAppTemplate server actions', () => {
       })
     );
 
-    expect(saveTemplateMock).toHaveBeenCalledWith({
+    expect(saveTemplateMock).toHaveBeenCalledWith(savedState.id, {
       ...savedState,
       name: 'template-name',
       message: 'template-message',
     });
 
     expect(redirectMock).toHaveBeenCalledWith(
-      `/preview-nhs-app-template/template-id?from=edit`,
+      `/preview-nhs-app-template/${savedState.id}?from=edit`,
       'push'
     );
   });
 
+  test('redirects to invalid-template if the ID in formState is not a uuid', async () => {
+    const badIdState = {
+      ...savedState,
+      id: 'no-uuid',
+    };
+
+    await processFormActions(
+      badIdState,
+      getMockFormData({
+        nhsAppTemplateName: 'template-name',
+        nhsAppTemplateMessage: 'template-message',
+      })
+    );
+
+    expect(saveTemplateMock).not.toHaveBeenCalled();
+
+    expect(redirectMock).toHaveBeenCalledWith('/invalid-template', 'replace');
+  });
+
   test('should save a template that contains a url with angle brackets, if they are url encoded', async () => {
     saveTemplateMock.mockResolvedValue({
       ...savedState,
@@ -159,15 +178,15 @@ describe('CreateNHSAppTemplate server actions', () => {
       })
     );
 
-    expect(saveTemplateMock).toHaveBeenCalledWith({
+    expect(saveTemplateMock).toHaveBeenCalledWith(savedState.id, {
       ...savedState,
       name: 'template-name',
       message:
         '**a message linking to [example.com](https://www.example.com/withparams?param1=%3C%3E)**',
     });
 
     expect(redirectMock).toHaveBeenCalledWith(
-      `/preview-nhs-app-template/template-id?from=edit`,
+      `/preview-nhs-app-template/${savedState.id}?from=edit`,
       'push'
     );
   });
@@ -190,7 +209,7 @@ describe('CreateNHSAppTemplate server actions', () => {
     });
 
     expect(redirectMock).toHaveBeenCalledWith(
-      '/preview-nhs-app-template/template-id?from=edit',
+      `/preview-nhs-app-template/${savedState.id}?from=edit`,
       'push'
     );
   });