add s3 access logging

Author: alexnuttall

infrastructure/terraform/components/app/README.md

@@ -30,7 +30,6 @@
 | <a name="input_enable_amplify_branch_auto_build"></a> [enable\_amplify\_branch\_auto\_build](#input\_enable\_amplify\_branch\_auto\_build) | Enable automatic building of branches | `bool` | `false` | no |
 | <a name="input_enable_cognito_built_in_idp"></a> [enable\_cognito\_built\_in\_idp](#input\_enable\_cognito\_built\_in\_idp) | Enable the use of Cognito as an IDP; CIS2 is prefered | `bool` | `false` | no |
 | <a name="input_enable_event_caching"></a> [enable\_event\_caching](#input\_enable\_event\_caching) | Enable caching of events to an S3 bucket | `bool` | `true` | no |
-| <a name="input_enable_file_download"></a> [enable\_file\_download](#input\_enable\_file\_download) | Feature flag for downloading files | `bool` | `true` | no |
 | <a name="input_enable_letters"></a> [enable\_letters](#input\_enable\_letters) | Feature flag for letters | `string` | `false` | no |
 | <a name="input_enable_proofing"></a> [enable\_proofing](#input\_enable\_proofing) | Feature flag for proofing | `string` | `false` | no |
 | <a name="input_environment"></a> [environment](#input\_environment) | The name of the tfscaffold environment | `string` | n/a | yes |

infrastructure/terraform/components/app/module_s3bucket_cf_logs.tf

@@ -65,10 +65,9 @@ module "s3bucket_cf_logs" {
     data.aws_iam_policy_document.s3bucket_cf_logs.json
   ]
 
-  # Ignore access logs while we prove out deploying
-  # bucket_logging_target = {
-  #   bucket = local.s3_buckets["access_logs"]["id"]
-  # }
+  bucket_logging_target = {
+    bucket = local.s3_buckets["access_logs"]["id"]
+  }
 
   public_access = {
     block_public_acls       = true

infrastructure/terraform/components/app/variables.tf

@@ -194,12 +194,6 @@ variable "enable_proofing" {
   default     = false
 }
 
-variable "enable_file_download" {
-  type        = bool
-  description = "Feature flag for downloading files"
-  default     = true
-}
-
 variable "observability_account_id" {
   type        = string
   description = "The Observability Account ID that needs access"