CCM-11544 Test fixes

Author: nicki-nhs

tests/test-team/template-mgmt-routing-component-tests/letter/choose-large-print-letter-template.routing-component.spec.ts

@@ -266,11 +266,13 @@ test.describe('Routing - Choose large print letter template page', () => {
       new RoutingChooseLargePrintLetterTemplatePage(page);
     await chooseLargePrintLetterTemplatePage
       .setPathParam('messagePlanId', routingConfigs.valid.id)
-      .setSearchParam('lockNumber', '1')
+      .setSearchParam('lockNumber', '')
       .loadPage();
 
     await chooseLargePrintLetterTemplatePage.saveAndContinueButton.click();
 
+    await page.waitForLoadState('load');
+
     await page.waitForURL((url) =>
       url.href.includes(
         `/templates/message-plans/choose-large-print-letter-template/${routingConfigs.valid.id}?lockNumber=1`
@@ -295,6 +297,9 @@ test.describe('Routing - Choose large print letter template page', () => {
       .getRadioButton(templates.LARGE_PRINT_LETTER1.id)
       .check();
 
+    // eslint-disable-next-line playwright/no-wait-for-timeout
+    await page.waitForTimeout(5000); // Wait for debounce
+
     await chooseLargePrintLetterTemplatePage.saveAndContinueButton.click();
 
     await page.waitForURL(

tests/test-team/template-mgmt-routing-component-tests/letter/choose-other-language-letter-template.routing-component.spec.ts

@@ -336,7 +336,7 @@ test.describe('Routing - Choose other language letter templates page', () => {
 
       await expect(
         chooseOtherLanguageLetterTemplatePage.noTemplatesMessage
-      ).toHaveText('You do not have any o language letter templates yet.');
+      ).toHaveText('You do not have any other language letter templates yet.');
 
       await chooseOtherLanguageLetterTemplatePage.goToTemplatesLink.click();
 
@@ -526,13 +526,16 @@ test.describe('Routing - Choose other language letter templates page', () => {
 
     await chooseOtherLanguageLetterTemplatePage.saveAndContinueButton.click();
 
-    await expect(page).toHaveURL(
-      `${baseURL}/templates/message-plans/choose-other-language-letter-template/${routingConfigs.valid.id}?lockNumber=${routingConfigs.valid.lockNumber + 1}`
-    );
+    await page.waitForLoadState('load');
 
     await expect(
       chooseOtherLanguageLetterTemplatePage.errorSummary
     ).toBeVisible();
+
+    await expect(page).toHaveURL(
+      `${baseURL}/templates/message-plans/choose-other-language-letter-template/${routingConfigs.valid.id}?lockNumber=${routingConfigs.valid.lockNumber + 1}`
+    );
+
     await expect(
       chooseOtherLanguageLetterTemplatePage.errorSummaryHint
     ).toHaveText('You have not chosen any templates');
@@ -557,14 +560,16 @@ test.describe('Routing - Choose other language letter templates page', () => {
 
     await chooseOtherLanguageLetterTemplatePage.saveAndContinueButton.click();
 
-    await expect(page).toHaveURL(
-      `${baseURL}/templates/message-plans/choose-other-language-letter-template/${routingConfigs.valid.id}?lockNumber=${routingConfigs.valid.lockNumber + 1}`
-    );
+    await page.waitForLoadState('load');
 
     await expect(
       chooseOtherLanguageLetterTemplatePage.errorSummary
     ).toBeVisible();
 
+    await expect(page).toHaveURL(
+      `${baseURL}/templates/message-plans/choose-other-language-letter-template/${routingConfigs.valid.id}?lockNumber=${routingConfigs.valid.lockNumber + 1}`
+    );
+
     await expect(
       chooseOtherLanguageLetterTemplatePage.errorSummaryList.first()
     ).toHaveText('Choose only one template for each language');
@@ -589,13 +594,16 @@ test.describe('Routing - Choose other language letter templates page', () => {
 
     await chooseOtherLanguageLetterTemplatePage.saveAndContinueButton.click();
 
-    await expect(page).toHaveURL(
-      `${baseURL}/templates/message-plans/choose-other-language-letter-template/${routingConfigs.valid.id}?lockNumber=${routingConfigs.valid.lockNumber + 1}`
-    );
+    await page.waitForLoadState('load');
 
     await expect(
       chooseOtherLanguageLetterTemplatePage.errorSummary
     ).toBeVisible();
+
+    await expect(page).toHaveURL(
+      `${baseURL}/templates/message-plans/choose-other-language-letter-template/${routingConfigs.valid.id}?lockNumber=${routingConfigs.valid.lockNumber + 1}`
+    );
+
     await expect(
       chooseOtherLanguageLetterTemplatePage.errorSummary.locator('.nhsuk-hint')
     ).toHaveText('You have not chosen any templates');
@@ -617,7 +625,7 @@ test.describe('Routing - Choose other language letter templates page', () => {
 
     await chooseOtherLanguageLetterTemplatePage.saveAndContinueButton.click();
 
-    await expect(page).toHaveURL(
+    await page.waitForURL(
       `${baseURL}/templates/message-plans/choose-templates/${routingConfigs.valid.id}`
     );
   });