CCM-12438: check flag before parsing input

Author: harrim91

lambdas/backend-api/src/__tests__/templates/app/routing-config-client.test.ts

@@ -298,9 +298,16 @@ describe('RoutingConfigClient', () => {
       });
     });
 
-    test('returns 400 error when input is invalid', async () => {
+    test('returns validation error when input is invalid', async () => {
       const { client, mocks } = setup();
 
+      mocks.clientConfigRepository.get.mockResolvedValueOnce({
+        data: {
+          features: { routing: true },
+          campaignIds: [routingConfig.campaignId],
+        },
+      });
+
       const result = await client.createRoutingConfig(
         { a: 1 } as unknown as CreateUpdateRoutingConfig,
         user
@@ -671,6 +678,12 @@ describe('RoutingConfigClient', () => {
 
     test('returns validation error when update is invalid', async () => {
       const { client, mocks } = setup();
+      mocks.clientConfigRepository.get.mockResolvedValueOnce({
+        data: {
+          features: { routing: true },
+          campaignIds: [routingConfig.campaignId],
+        },
+      });
 
       const update: CreateUpdateRoutingConfig = {
         campaignId: routingConfig.campaignId,

lambdas/backend-api/src/templates/app/routing-config-client.ts

@@ -22,15 +22,6 @@ export class RoutingConfigClient {
     payload: unknown,
     user: User
   ): Promise<Result<RoutingConfig>> {
-    const validationResult = await validate(
-      $CreateUpdateRoutingConfig,
-      payload
-    );
-
-    if (validationResult.error) return validationResult;
-
-    const validated = validationResult.data;
-
     const clientConfigurationResult = await this.clientConfigRepository.get(
       user.clientId
     );
@@ -47,6 +38,15 @@ export class RoutingConfigClient {
       );
     }
 
+    const validationResult = await validate(
+      $CreateUpdateRoutingConfig,
+      payload
+    );
+
+    if (validationResult.error) return validationResult;
+
+    const validated = validationResult.data;
+
     if (!clientConfiguration?.campaignIds?.includes(validated.campaignId)) {
       return failure(
         ErrorCase.VALIDATION_FAILED,
@@ -62,15 +62,6 @@ export class RoutingConfigClient {
     payload: unknown,
     user: User
   ): Promise<Result<RoutingConfig>> {
-    const validationResult = await validate(
-      $CreateUpdateRoutingConfig,
-      payload
-    );
-
-    if (validationResult.error) return validationResult;
-
-    const validated = validationResult.data;
-
     const clientConfigurationResult = await this.clientConfigRepository.get(
       user.clientId
     );
@@ -80,6 +71,15 @@ export class RoutingConfigClient {
 
     if (clientConfigurationError) return clientConfigurationResult;
 
+    const validationResult = await validate(
+      $CreateUpdateRoutingConfig,
+      payload
+    );
+
+    if (validationResult.error) return validationResult;
+
+    const validated = validationResult.data;
+
     if (!clientConfiguration?.features.routing) {
       return failure(
         ErrorCase.VALIDATION_FAILED,