CCM-8426: lint fixes

Author: Ian-Hodges

tests/test-team/pages/sms/template-mgmt-edit-sms-page.ts

@@ -37,6 +37,8 @@ export class TemplateMgmtEditSmsPage extends TemplateMgmtBasePage {
   }
 
   async loadPage(templateId: string) {
-    await this.navigateTo(`/templates/edit-text-message-template/${templateId}`);
+    await this.navigateTo(
+      `/templates/edit-text-message-template/${templateId}`
+    );
   }
 }

tests/test-team/template-mgmt-component-tests/email/template-mgmt-create-email-page.component.spec.ts

@@ -34,9 +34,7 @@ test.describe('Create Email message template Page', () => {
 
     await createEmailTemplatePage.loadPage();
 
-    await expect(page).toHaveURL(
-      `${baseURL}/templates/create-email-template`
-    );
+    await expect(page).toHaveURL(`${baseURL}/templates/create-email-template`);
 
     expect(await createEmailTemplatePage.pageHeader.textContent()).toBe(
       'Create email template'
@@ -158,11 +156,9 @@ test.describe('Create Email message template Page', () => {
 
       await createEmailTemplatePage.clickSubmitButton();
 
-      const previewPageRegex = "\\/templates\\/preview-email-template\\/([0-9a-fA-F-]+)(?:\\?from=edit)?$";
+      const previewPageRegex = String.raw`\/templates\/preview-email-template\/([0-9a-fA-F-]+)(?:\?from=edit)?$`;
 
-      await expect(page).toHaveURL(
-        RegExp(previewPageRegex)
-      );
+      await expect(page).toHaveURL(new RegExp(previewPageRegex));
 
       const previewPageParts = page.url().match(previewPageRegex);
 

tests/test-team/template-mgmt-component-tests/email/template-mgmt-edit-email-page.component.spec.ts

@@ -117,9 +117,9 @@ test.describe('Edit Email message template Page', () => {
 
       await editEmailTemplatePage.personalisationFields.click();
 
-      await expect(
-        editEmailTemplatePage.personalisationFields
-      ).toHaveAttribute('open');
+      await expect(editEmailTemplatePage.personalisationFields).toHaveAttribute(
+        'open'
+      );
     });
 
     test('when user clicks "Message formatting" tool tips, then tool tips are displayed', async ({
@@ -157,15 +157,10 @@ test.describe('Edit Email message template Page', () => {
         baseURL,
       }) => {
         const editTemplatePage = new TemplateMgmtEditEmailPage(page);
-
-        await editTemplatePage.loadPage(templates.empty.id);
-
+        await editTemplatePage.loadPage('empty-email-template');
         const newTabPromise = page.waitForEvent('popup');
-
         await page.getByRole('link', { name }).click();
-
         const newTab = await newTabPromise;
-
         await expect(newTab).toHaveURL(`${baseURL}/${url}`);
       });
     }
@@ -247,9 +242,9 @@ test.describe('Edit Email message template Page', () => {
 
       await expect(editEmailTemplatePage.errorSummary).toBeVisible();
 
-      await expect(
-        editEmailTemplatePage.errorSummary.locator('h2')
-      ).toHaveText('There is a problem');
+      await expect(editEmailTemplatePage.errorSummary.locator('h2')).toHaveText(
+        'There is a problem'
+      );
 
       await expect(
         editEmailTemplatePage.errorSummary.locator(
@@ -342,10 +337,9 @@ test.describe('Edit Email message template Page', () => {
 
       await editEmailTemplatePage.clickSubmitButton();
 
-      const emailMessageErrorLink =
-        editEmailTemplatePage.errorSummary.locator(
-          '[href="#emailTemplateMessage"]'
-        );
+      const emailMessageErrorLink = editEmailTemplatePage.errorSummary.locator(
+        '[href="#emailTemplateMessage"]'
+      );
 
       await expect(emailMessageErrorLink).toHaveText(errorMessage);
 

tests/test-team/template-mgmt-component-tests/nhs-app/template-mgmt-create-nhs-app-template-page.component.spec.ts

@@ -74,11 +74,9 @@ test.describe('Create NHS App Template Page', () => {
       .fill('This is an NHS App message');
     await createTemplatePage.clickSubmitButton();
 
-    const previewPageRegex = "\\/templates\\/preview-nhs-app-template\\/([0-9a-fA-F-]+)(?:\\?from=edit)?$";
+    const previewPageRegex = String.raw`\/templates\/preview-nhs-app-template\/([0-9a-fA-F-]+)(?:\?from=edit)?$`;
 
-    await expect(page).toHaveURL(
-      RegExp(previewPageRegex)
-    );
+    await expect(page).toHaveURL(new RegExp(previewPageRegex));
 
     const previewPageParts = page.url().match(previewPageRegex);
     expect(previewPageParts?.length).toEqual(2);

tests/test-team/template-mgmt-component-tests/nhs-app/template-mgmt-edit-nhs-app-template-page.component.spec.ts

@@ -262,15 +262,10 @@ test.describe('Edit NHS App Template Page', () => {
       baseURL,
     }) => {
       const editTemplatePage = new TemplateMgmtEditNhsAppPage(page);
-
-      await editTemplatePage.loadPage(templates.emptyTemplateData.id);
-
+      await editTemplatePage.loadPage('empty-nhs-app-template');
       const newTabPromise = page.waitForEvent('popup');
-
       await page.getByRole('link', { name }).click();
-
       const newTab = await newTabPromise;
-
       await expect(newTab).toHaveURL(`${baseURL}/${url}`);
     });
   }

tests/test-team/template-mgmt-component-tests/sms/template-mgmt-create-sms-page.component.spec.ts

@@ -8,7 +8,6 @@ import {
   assertNotifyBannerLink,
   assertSkipToMainContent,
 } from '../template-mgmt-common.steps';
-import { Template, TemplateType } from '../../helpers/types';
 import {
   createAuthHelper,
   TestUser,
@@ -27,9 +26,7 @@ test.describe('Create SMS message template Page', () => {
     await templateStorageHelper.deleteAdHocTemplates();
   });
 
-  test('when user visits page, then page is loaded', async ({
-    page,
-  }) => {
+  test('when user visits page, then page is loaded', async ({ page }) => {
     const createSmsTemplatePage = new TemplateMgmtCreateSmsPage(page);
 
     await createSmsTemplatePage.loadPage();
@@ -174,11 +171,9 @@ test.describe('Create SMS message template Page', () => {
 
       await createSmsTemplatePage.clickSubmitButton();
 
-      const previewPageRegex = "\\/templates\\/preview-text-message-template\\/([0-9a-fA-F-]+)(?:\\?from=edit)?$";
+      const previewPageRegex = String.raw`\/templates\/preview-text-message-template\/([0-9a-fA-F-]+)(?:\?from=edit)?$`;
 
-      await expect(page).toHaveURL(
-        RegExp(previewPageRegex)
-      );
+      await expect(page).toHaveURL(new RegExp(previewPageRegex));
 
       const previewPageParts = page.url().match(previewPageRegex);
       expect(previewPageParts?.length).toEqual(2);

tests/test-team/template-mgmt-component-tests/sms/template-mgmt-edit-sms-page.component.spec.ts

@@ -189,15 +189,10 @@ test.describe('Edit SMS message template Page', () => {
         baseURL,
       }) => {
         const editTemplatePage = new TemplateMgmtEditSmsPage(page);
-
-        await editTemplatePage.loadPage(templates.empty.id);
-
+        await editTemplatePage.loadPage('empty-sms-template');
         const newTabPromise = page.waitForEvent('popup');
-
         await page.getByRole('link', { name }).click();
-
         const newTab = await newTabPromise;
-
         await expect(newTab).toHaveURL(`${baseURL}/${url}`);
       });
     }
@@ -210,13 +205,9 @@ test.describe('Edit SMS message template Page', () => {
 
       await editSmsTemplatePage.loadPage(templates.submit.id);
 
-      await editSmsTemplatePage.nameInput.fill(
-        'This is an SMS template name'
-      );
+      await editSmsTemplatePage.nameInput.fill('This is an SMS template name');
 
-      await editSmsTemplatePage.messageTextArea.fill(
-        'This is an SMS message'
-      );
+      await editSmsTemplatePage.messageTextArea.fill('This is an SMS message');
 
       await editSmsTemplatePage.clickSubmitButton();
 
@@ -269,9 +260,7 @@ test.describe('Edit SMS message template Page', () => {
       ).toBeVisible();
 
       await expect(
-        editSmsTemplatePage.errorSummary.locator(
-          `[href="#smsTemplateMessage"]`
-        )
+        editSmsTemplatePage.errorSummary.locator(`[href="#smsTemplateMessage"]`)
       ).toBeVisible();
     });