add e2e assertion

Author: alexnuttall

frontend/src/components/molecules/PreviewTemplateDetails/PreviewTemplateDetailsLetter.tsx

@@ -72,6 +72,7 @@ export function PreviewTemplateDetailsLetter({
                       className={styles.container}
                       target='_blank'
                       rel='noopener noreferrer'
+                      data-testid='proof-link'
                     >
                       <Filename filename={file} />
                     </Link>

tests/test-team/pages/letter/template-mgmt-preview-letter-page.ts

@@ -10,11 +10,13 @@ export class TemplateMgmtPreviewLetterPage extends TemplateMgmtPreviewBasePage {
 
   public readonly errorSummary: Locator;
   public readonly continueButton: Locator;
+  public readonly pdfLinks: Locator;
 
   constructor(page: Page) {
     super(page);
     this.errorSummary = page.locator('[class="nhsuk-error-summary"]');
     this.continueButton = page.locator('[id="preview-letter-template-cta"]');
+    this.pdfLinks = page.locator('[data-testid="proof-link"]');
   }
 
   async clickContinueButton() {

tests/test-team/template-mgmt-e2e-tests/template-mgmt-letter-full.e2e.spec.ts

@@ -1,3 +1,4 @@
+/* eslint-disable sonarjs/no-nested-functions */
 import { test, expect } from '@playwright/test';
 import { TemplateMgmtCreateLetterPage } from '../pages/letter/template-mgmt-create-letter-page';
 import { TemplateStorageHelper } from '../helpers/db/template-storage-helper';
@@ -151,6 +152,15 @@ test.describe.skip('letter complete e2e journey', () => {
       await page.reload();
 
       await expect(previewTemplatePage.continueButton).toBeVisible();
+
+      const pdfHrefs = await previewTemplatePage.pdfLinks.evaluateAll(
+        (anchors) => anchors.map((a) => 'href' in a && a.href)
+      );
+
+      expect(pdfHrefs.length).toBeGreaterThan(0);
+
+      for (const href of pdfHrefs) expect(href).toContain(templateId);
+
       await previewTemplatePage.clickContinueButton();
     }).toPass({ timeout: 60_000 });