Merge pull request #241 from NHSDigital/CCM-7908_VarsFromGithubFix

CCM-7908 adding mechanism for TFVAR based secret

Author: aidenvaines-cgi

infrastructure/terraform/components/app/ssm_parameter_amplify_password.tf

@@ -1,7 +1,9 @@
 resource "aws_ssm_parameter" "amplify_password" {
   count = var.enable_amplify_basic_auth ? 1 : 0
 
-  name  = "/${local.csi}/amplify_password"
+  name        = "/${local.csi}/amplify_password"
+  description = "The Basic Auth password used for the amplify app. This parameter is sourced from Github Environment variables"
+
   type  = "String"
   value = var.AMPLIFY_BASIC_AUTH_SECRET != "unset" ?  var.AMPLIFY_BASIC_AUTH_SECRET : random_password.password[0].result
 }

infrastructure/terraform/components/app/variables.tf

@@ -95,9 +95,9 @@ variable "enable_amplify_basic_auth" {
 
 # Github Environments only handles uppercase envvars
 variable "AMPLIFY_BASIC_AUTH_SECRET" {
+  # Github only does uppercase env vars
   type        = string
   description = "Secret key/password to use for Amplify Basic Auth - This is entended to be read from CI variables and not commited to any codebase"
-  sensitive   = true
   default     = "unset"
 }