CCM-10579: Observability Prod Cutover (#575)

Author: sidnhs

infrastructure/terraform/components/app/README.md

@@ -40,7 +40,6 @@
 | <a name="input_letter_suppliers"></a> [letter\_suppliers](#input\_letter\_suppliers) | Letter suppliers enabled in the environment | <pre>map(object({<br/>    email_addresses  = list(string)<br/>    enable_polling   = bool<br/>    default_supplier = optional(bool)<br/>  }))</pre> | `{}` | no |
 | <a name="input_log_retention_in_days"></a> [log\_retention\_in\_days](#input\_log\_retention\_in\_days) | The retention period in days for the Cloudwatch Logs events to be retained, default of 0 is indefinite | `number` | `0` | no |
 | <a name="input_observability_account_id"></a> [observability\_account\_id](#input\_observability\_account\_id) | The Observability Account ID that needs access | `string` | n/a | yes |
-| <a name="input_override_log_destination_arn"></a> [override\_log\_destination\_arn](#input\_override\_log\_destination\_arn) | Override the log destination ARN for this component. | `string` | `""` | no |
 | <a name="input_parent_acct_environment"></a> [parent\_acct\_environment](#input\_parent\_acct\_environment) | Name of the environment responsible for the acct resources used, affects things like DNS zone. Useful for named dev environments | `string` | `"main"` | no |
 | <a name="input_project"></a> [project](#input\_project) | The name of the tfscaffold project | `string` | n/a | yes |
 | <a name="input_region"></a> [region](#input\_region) | The AWS Region | `string` | n/a | yes |

infrastructure/terraform/components/app/locals.tf

@@ -2,5 +2,5 @@ locals {
   cloudfront_files_domain_name = "files.${local.root_domain_name}"
   root_domain_name             = "${var.environment}.${local.acct.dns_zone["name"]}"
   lambdas_source_code_dir      = "../../../../lambdas"
-  log_destination_arn          = var.override_log_destination_arn != "" ? var.override_log_destination_arn : "arn:aws:logs:${var.region}:${var.observability_account_id}:destination:nhs-main-obs-firehose-logs" # TODO CCM-10579 Please remove this after we do dev/nonprod cutover for this BC
+  log_destination_arn          = "arn:aws:logs:${var.region}:${var.observability_account_id}:destination:nhs-main-obs-firehose-logs"
 }

infrastructure/terraform/components/app/module_backend_api.tf

@@ -32,5 +32,5 @@ module "backend_api" {
   template_submitted_sender_email_address = "template-submitted@${module.ses.domain}"
   proof_requested_sender_email_address    = "proof-requested@${module.ses.domain}"
 
-  sns_topic_arn  = module.eventpub.sns_topic.arn
+  sns_topic_arn = module.eventpub.sns_topic.arn
 }

infrastructure/terraform/components/app/variables.tf

@@ -218,10 +218,3 @@ variable "external_email_domain" {
   default     = null
   description = "Externally managed domain used to create an SES identity for sending emails from. Validation DNS records will need to be manually configured in the DNS provider."
 }
-
-variable "override_log_destination_arn" {
-  type        = string
-  description = "Override the log destination ARN for this component."
-  default     = ""
-}
-