typos

Author: alexnuttall

lambdas/sftp-letters/src/__tests__/app/poll.test.ts

@@ -25,6 +25,8 @@ test('polls SFTP folder', async () => {
         'download-dir/sftp-environment/proofs': directoryType,
         'download-dir/sftp-environment/proofs/client_campaign_template-1_en_x0':
           directoryType,
+        'download-dir/sftp-environment/proofs/unexpected-id-format':
+          directoryType,
       };
 
       return existsMappings[path] ?? false;
@@ -44,6 +46,8 @@ test('polls SFTP folder', async () => {
           mockPdfBuffer,
         'download-dir/sftp-environment/proofs/client_campaign_template-1_en_x0/proof-2.pdf':
           mockPdfBuffer,
+        'download-dir/sftp-environment/proofs/unexpected-id-format/proof-1.pdf':
+          mockPdfBuffer,
         'download-dir/sftp-environment/proofs/client_campaign_template-1_en_x0/invalid-file.pdf':
           mockMalformedPdfBuffer,
       }[path];
@@ -101,6 +105,13 @@ test('polls SFTP folder', async () => {
               modifyTime: Date.now(),
             },
           ],
+        'download-dir/sftp-environment/proofs/unexpected-id-format': [
+          {
+            name: 'proof-1.pdf',
+            type: fileType,
+            modifyTime: Date.now(),
+          },
+        ],
       })[path] ?? [],
   });
 

lambdas/sftp-letters/src/app/poll.ts

@@ -98,15 +98,15 @@ export class App {
     const idLogger = logger.child({ expandedTemplateId, templateId });
 
     for (const proofFile of proofFiles) {
-      if (proofFile.type === '-') {
+      if (proofFile.type === '-' && templateId) {
         await this.copyFileToS3(
           sftpClient,
           `${baseSftpPath}/${expandedTemplateId}/${proofFile.name}`,
           `${baseS3Path}/${templateId}/${proofFile.name}`,
           logger
         );
       } else {
-        idLogger.info('Unexpected non-file item found');
+        idLogger.info('Unexpected item found', { proofFile });
       }
     }
   }