Skip to content

Commit 67a9fd1

Browse files
bhansell1bhansell1
committed
CCM-11343: turn off lint rules
1 parent 39531ae commit 67a9fd1

File tree

5 files changed

+9
-160
lines changed

5 files changed

+9
-160
lines changed

‎.eslintrc.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
],
5454
"security/detect-object-injection": "off",
5555
"sonarjs/no-duplicate-string": "off",
56+
"sonarjs/todo-tag": "off",
5657
"no-param-reassign": "off",
5758
"no-useless-constructor": "off",
5859
"sonarjs/no-small-switch": "off",

‎frontend/src/__tests__/components/organisms/__snapshots__/PreviewLetterTemplate.test.tsx.snap‎

Lines changed: 6 additions & 158 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template language
148148
<span
149149
class="nhsuk-u-visually-hidden"
150150
>
151-
Important:
151+
Important:
152152
</span>
153153
Important
154154
</span>
@@ -160,7 +160,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template language
160160
After you submit your template, our service team will send you a proof by email instead.
161161
</p>
162162
<p>
163-
This email will tell you what todo next.
163+
This email will tell you what to do next.
164164
</p>
165165
</div>
166166
</div>
@@ -189,158 +189,6 @@ exports[`PreviewLetterTemplate component matches snapshot when template language
189189
</DocumentFragment>
190190
`;
191191

192-
exports[`PreviewLetterTemplate component matches snapshot when template proofingEnabled false 1`] = `
193-
<DocumentFragment>
194-
<div
195-
class="nhsuk-back-link"
196-
>
197-
<a
198-
class="nhsuk-back-link__link"
199-
href="/templates/message-templates"
200-
id="back-link"
201-
>
202-
<svg
203-
aria-hidden="true"
204-
class="nhsuk-icon nhsuk-icon__chevron-left"
205-
height="24"
206-
viewBox="0 0 24 24"
207-
width="24"
208-
xmlns="http://www.w3.org/2000/svg"
209-
>
210-
<path
211-
d="M8.5 12c0-.3.1-.5.3-.7l5-5c.4-.4 1-.4 1.4 0s.4 1 0 1.4L10.9 12l4.3 4.3c.4.4.4 1 0 1.4s-1 .4-1.4 0l-5-5c-.2-.2-.3-.4-.3-.7z"
212-
/>
213-
</svg>
214-
Back to all templates
215-
</a>
216-
</div>
217-
<main
218-
class="nhsuk-main-wrapper"
219-
id="maincontent"
220-
role="main"
221-
>
222-
<div
223-
class="nhsuk-grid-row"
224-
>
225-
<div
226-
class="nhsuk-grid-column-full"
227-
>
228-
<h1
229-
class="preview__heading"
230-
data-testid="preview-message__heading"
231-
>
232-
letter
233-
</h1>
234-
<div
235-
class="nhsuk-width-container nhsuk-u-margin-bottom-6 nhsuk-body-m"
236-
>
237-
<dl
238-
class="nhsuk-summary-list nhsuk-u-margin-bottom-4 preview"
239-
>
240-
<div
241-
class="nhsuk-summary-list__row"
242-
>
243-
<dt
244-
class="nhsuk-summary-list__key"
245-
>
246-
Template ID
247-
</dt>
248-
<dd
249-
class="nhsuk-summary-list__value"
250-
>
251-
0A097DCD-35F9-4DAD-A37E-AC358B71B74D
252-
</dd>
253-
</div>
254-
<div
255-
class="nhsuk-summary-list__row"
256-
>
257-
<dt
258-
class="nhsuk-summary-list__key"
259-
>
260-
Type
261-
</dt>
262-
<dd
263-
class="nhsuk-summary-list__value"
264-
/>
265-
</div>
266-
<div
267-
class="nhsuk-summary-list__row"
268-
>
269-
<dt
270-
class="nhsuk-summary-list__key"
271-
>
272-
Status
273-
</dt>
274-
<dd
275-
class="nhsuk-summary-list__value"
276-
>
277-
<strong
278-
class="nhsuk-tag"
279-
data-test-id="status-tag-not-yet-submitted"
280-
/>
281-
</dd>
282-
</div>
283-
<div
284-
class="nhsuk-summary-list__row"
285-
>
286-
<dt
287-
class="nhsuk-summary-list__key"
288-
>
289-
Template file
290-
</dt>
291-
<dd
292-
class="nhsuk-summary-list__value"
293-
>
294-
<div
295-
class="container"
296-
>
297-
<svg
298-
class="icon"
299-
fill="none"
300-
height="26"
301-
viewBox="0 0 20 26"
302-
width="20"
303-
xmlns="http://www.w3.org/2000/svg"
304-
>
305-
<path
306-
d="M0 0V26H20V6.59375L19.7188 6.28125L13.7188 0.28125L13.4062 0H0ZM2 2H12V8H18V24H2V2ZM14 3.4375L16.5625 6H14V3.4375Z"
307-
fill="#4C6272"
308-
/>
309-
</svg>
310-
<p
311-
class="text"
312-
>
313-
file.pdf
314-
</p>
315-
</div>
316-
</dd>
317-
</div>
318-
</dl>
319-
</div>
320-
<a
321-
aria-disabled="false"
322-
class="nhsuk-button"
323-
data-testid="preview-letter-template-cta"
324-
draggable="false"
325-
href="/templates/submit-letter-template/0A097DCD-35F9-4DAD-A37E-AC358B71B74D"
326-
id="preview-letter-template-cta"
327-
role="button"
328-
>
329-
Submit template
330-
</a>
331-
<p>
332-
<a
333-
href="/message-templates"
334-
>
335-
Back to all templates
336-
</a>
337-
</p>
338-
</div>
339-
</div>
340-
</main>
341-
</DocumentFragment>
342-
`;
343-
344192
exports[`PreviewLetterTemplate component matches snapshot when template status is NOT_YET_SUBMITTED 1`] = `
345193
<DocumentFragment>
346194
<div
@@ -1242,7 +1090,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template status i
12421090
<span
12431091
class="nhsuk-u-visually-hidden"
12441092
>
1245-
Error:
1093+
Error:
12461094
</span>
12471095
The personalisation fields in your files are missing or do not match.
12481096
</span>
@@ -1252,7 +1100,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template status i
12521100
<span
12531101
class="nhsuk-u-visually-hidden"
12541102
>
1255-
Error:
1103+
Error:
12561104
</span>
12571105
Check that the personalisation fields in your template file match the fields in your example personalisation file
12581106
</span>
@@ -1452,7 +1300,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template status i
14521300
<span
14531301
class="nhsuk-u-visually-hidden"
14541302
>
1455-
Error:
1303+
Error:
14561304
</span>
14571305
The file(s) you uploaded may contain a virus.
14581306
</span>
@@ -1462,7 +1310,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template status i
14621310
<span
14631311
class="nhsuk-u-visually-hidden"
14641312
>
1465-
Error:
1313+
Error:
14661314
</span>
14671315
Create a new letter template to upload your file(s) again or upload different file(s).
14681316
</span>

‎frontend/src/content/content.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ const previewLetterTemplate = {
270270
text1: `The proof of this letter template will not be available online because of the language you've chosen.`,
271271
text2:
272272
'After you submit your template, our service team will send you a proof by email instead.',
273-
text3: 'This email will tell you what todo next.',
273+
text3: 'This email will tell you what to do next.',
274274
},
275275
};
276276

‎lambdas/backend-client/src/schemas/template-schema.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ export const $CreateLetterProperties = schemaFor<CreateLetterProperties>()(
9898
export const $LetterProperties = schemaFor<LetterProperties>()(
9999
$CreateLetterProperties.extend({
100100
files: $LetterFiles,
101-
/* eslint-disable sonarjs/todo-tag */
102101
// TODO: CCM-10432 - remove, not needed after client migration
103102
owner: z.string().optional(),
104103
personalisationParameters: z.array(z.string()).optional(),

‎scripts/githooks/check-todos.sh‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ EXCLUDED_FILES=(
3333
"Makefile"
3434
"project.code-workspace"
3535
"src/jekyll-devcontainer/src/.devcontainer/devcontainer.json"
36+
".eslintrc.json"
3637
)
3738

3839
EXCLUDED_DIRS=(

0 commit comments

Comments
 (0)