CCM-11492 Hide fallback conditions for final channel and add routing config ID to URLs

Author: nicki-nhs

frontend/src/__tests__/components/organisms/CreateEditMessagePlan.test.tsx

@@ -94,14 +94,15 @@ describe('CreateEditMessagePlan', () => {
       ...(messagePlanChannelList.children as HTMLCollectionOf<HTMLElement>),
     ].map((el) => el.dataset.testid);
 
-    expect(listItemsTestIds).toEqual([
-      'message-plan-block-NHSAPP',
-      'message-plan-fallback-conditions-NHSAPP',
-      'message-plan-block-EMAIL',
-      'message-plan-fallback-conditions-EMAIL',
-      'message-plan-block-SMS',
-      'message-plan-fallback-conditions-SMS',
-    ]);
+    const expectedTestIds: string[] = [];
+    for (const [id, channel] of channels.entries()) {
+      expectedTestIds.push(`message-plan-block-${channel}`);
+      if (id < channels.length - 1) {
+        expectedTestIds.push(`message-plan-fallback-conditions-${channel}`);
+      }
+    }
+
+    expect(listItemsTestIds).toEqual(expectedTestIds);
   });
 
   it('should render CTAs for both saving and moving to production', () => {
@@ -131,7 +132,7 @@ describe('CreateEditMessagePlan', () => {
     const link = screen.getByTestId('change-message-plan-name-link');
     expect(link.textContent).toBe('Change name');
     expect(link.getAttribute('href')).toBe(
-      '/message-plans/create-message-plan'
+      `/message-plans/edit-message-plan/${plan.id}`
     );
   });
 

frontend/src/__tests__/components/organisms/MessagePlanChannelList.test.tsx

@@ -57,7 +57,7 @@ describe('MessagePlanChannelList', () => {
     expect(container.querySelector('ul.channel-list')).toBeInTheDocument();
   });
 
-  it('should render a block and a fallback section for each cascade item', () => {
+  it('should render a block and a fallback section for each cascade item, apart from the final channel', () => {
     const channels: Channel[] = ['NHSAPP', 'EMAIL', 'SMS'];
     const messagePlan = buildRoutingConfig(channels);
 
@@ -68,14 +68,20 @@ describe('MessagePlanChannelList', () => {
       />
     );
 
-    for (const channel of channels) {
-      expect(
-        screen.getByTestId(`message-plan-block-${channel}`)
-      ).toBeInTheDocument();
-      expect(
-        screen.getByTestId(`message-plan-fallback-conditions-${channel}`)
-      ).toBeInTheDocument();
-    }
+    expect(screen.getByTestId('message-plan-block-NHSAPP')).toBeInTheDocument();
+    expect(
+      screen.getByTestId('message-plan-fallback-conditions-NHSAPP')
+    ).toBeInTheDocument();
+
+    expect(screen.getByTestId('message-plan-block-EMAIL')).toBeInTheDocument();
+    expect(
+      screen.getByTestId('message-plan-fallback-conditions-EMAIL')
+    ).toBeInTheDocument();
+
+    expect(screen.getByTestId('message-plan-block-SMS')).toBeInTheDocument();
+    expect(
+      screen.queryByTestId('message-plan-fallback-conditions-SMS')
+    ).toBeNull();
   });
 
   it('should render nothing inside the list when cascade is empty', () => {