CCM-8585: fix module refs

Author: alexnuttall

infrastructure/terraform/modules/backend-api/module_create_letter_template_lambda.tf

@@ -15,7 +15,7 @@ module "create_letter_template_lambda" {
 
   environment_variables = {
     TEMPLATES_TABLE_NAME = aws_dynamodb_table.templates.name
-    SCAN_BUCKET_NAME     = aws_s3_bucket.pdf_template_scan.bucket
+    SCAN_BUCKET_NAME     = module.s3bucket_pdf_template_scan.bucket
   }
 
   execution_role_policy_document = data.aws_iam_policy_document.create_letter_template_lambda_policy.json
@@ -62,7 +62,7 @@ data "aws_iam_policy_document" "create_letter_template_lambda_policy" {
     ]
 
     resources = [
-      "${aws_s3_bucket.pdf_template_scan.arn}/*",
+      "${module.s3bucket_pdf_template_scan.arn}/*",
     ]
   }
 }

infrastructure/terraform/modules/backend-api/module_s3bucket_scan.tf

@@ -50,8 +50,8 @@ data "aws_iam_policy_document" "s3bucket_pdf_template_scan" {
     effect  = "Deny"
     actions = ["s3:*"]
     resources = [
-      aws_s3_bucket.pdf_template_scan.arn,
-      "${aws_s3_bucket.pdf_template_scan.arn}/*",
+      module.s3bucket_pdf_template_scan.arn,
+      "${module.s3bucket_pdf_template_scan.arn}/*",
     ]
     principals {
       type        = "AWS"