Skip to content

Commit 6f4c6ec

Browse files
Fixes after bad rebase
1 parent 15d0f43 commit 6f4c6ec

File tree

8 files changed

+10
-51
lines changed

8 files changed

+10
-51
lines changed

frontend/src/__tests__/components/forms/CopyTemplate/CopyTemplate.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ describe('Choose template page', () => {
4141
screen.getByTestId('EMAIL-radio'),
4242
screen.getByTestId('NHS_APP-radio'),
4343
screen.getByTestId('SMS-radio'),
44-
screen.getByTestId('LETTER-radio'),
4544
];
4645
const submitButton = screen.getByTestId('submit-button');
4746

frontend/src/__tests__/components/forms/CopyTemplate/__snapshots__/CopyTemplate.test.tsx.snap

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -153,25 +153,6 @@ exports[`Choose template page renders error component 1`] = `
153153
Text message (SMS)
154154
</label>
155155
</div>
156-
<div
157-
class="nhsuk-radios__item"
158-
>
159-
<input
160-
class="nhsuk-radios__input"
161-
data-testid="LETTER-radio"
162-
id="templateType-LETTER"
163-
name="templateType"
164-
type="radio"
165-
value="LETTER"
166-
/>
167-
<label
168-
class="nhsuk-label nhsuk-radios__label"
169-
for="templateType-LETTER"
170-
id="templateType-LETTER--label"
171-
>
172-
Letter
173-
</label>
174-
</div>
175156
</div>
176157
</div>
177158
</fieldset>
@@ -319,25 +300,6 @@ exports[`Choose template page selects one radio button at a time 1`] = `
319300
Text message (SMS)
320301
</label>
321302
</div>
322-
<div
323-
class="nhsuk-radios__item"
324-
>
325-
<input
326-
class="nhsuk-radios__input"
327-
data-testid="LETTER-radio"
328-
id="templateType-LETTER"
329-
name="templateType"
330-
type="radio"
331-
value="LETTER"
332-
/>
333-
<label
334-
class="nhsuk-label nhsuk-radios__label"
335-
for="templateType-LETTER"
336-
id="templateType-LETTER--label"
337-
>
338-
Letter
339-
</label>
340-
</div>
341303
</div>
342304
</div>
343305
</fieldset>

frontend/src/components/forms/ChooseTemplate/ChooseTemplate.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { chooseTemplatePageContent } from '@content/content';
99
import {
1010
TemplateType,
1111
templateTypeDisplayMappings,
12-
} from 'nhs-notify-web-template-management-utils/src/enum';
12+
} from 'nhs-notify-web-template-management-utils';
1313
import { chooseTemplateAction } from './server-action';
1414

1515
export const ChooseTemplate = () => {

frontend/src/components/forms/CopyTemplate/CopyTemplate.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ import { BackLink } from 'nhsuk-react-components';
77
import { NHSNotifyRadioButtonForm } from '@molecules/NHSNotifyRadioButtonForm/NHSNotifyRadioButtonForm';
88
import { ZodErrorSummary } from '@molecules/ZodErrorSummary/ZodErrorSummary';
99
import { copyTemplatePageContent } from '@content/content';
10-
import { Template } from 'nhs-notify-web-template-management-utils/src/types';
1110
import {
11+
Template,
1212
TemplateType,
1313
templateTypeDisplayMappings,
14-
} from 'nhs-notify-web-template-management-utils/src/enum';
14+
} from 'nhs-notify-web-template-management-utils';
1515
import { getBasePath } from '@utils/get-base-path';
1616
import { copyTemplateAction } from './server-action';
1717

frontend/src/components/forms/CopyTemplate/server-action.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,9 @@ import { redirect, RedirectType } from 'next/navigation';
44
import {
55
FormState,
66
Template,
7-
} from 'nhs-notify-web-template-management-utils/src/types';
8-
import {
97
TemplateStatus,
108
TemplateType,
11-
} from 'nhs-notify-web-template-management-utils/src/enum';
9+
} from 'nhs-notify-web-template-management-utils';
1210
import { z } from 'zod';
1311
import { createTemplate } from '@utils/form-actions';
1412
import { format } from 'date-fns/format';

tests/test-team/helpers/types.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,13 @@ export const templateTypeDisplayMappings = (type: TemplateType) =>
99
[TemplateType.NHS_APP]: 'NHS App message',
1010
[TemplateType.SMS]: 'Text message (SMS)',
1111
[TemplateType.EMAIL]: 'Email',
12-
[TemplateType.LETTER]: 'Letter',
1312
})[type];
1413

1514
export const templateTypeToUrlTextMappings = (type: TemplateType) =>
1615
({
1716
[TemplateType.NHS_APP]: 'nhs-app',
1817
[TemplateType.SMS]: 'text-message',
1918
[TemplateType.EMAIL]: 'email',
20-
[TemplateType.LETTER]: 'letter',
2119
})[type];
2220

2321
export enum TemplateStatus {

tests/test-team/template-mgmt-component-tests/template-mgmt-copy-page.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ test.describe('Copy Template Page', () => {
8787

8888
await copyTemplatePage.loadPage(templates.email.id);
8989

90-
await expect(copyTemplatePage.radioButtons).toHaveCount(4);
90+
await expect(copyTemplatePage.radioButtons).toHaveCount(3);
9191
});
9292

9393
test('should display error if no template type option selected and continue button clicked', async ({

utils/src/enum.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ export enum TemplateType {
22
NHS_APP = 'NHS_APP',
33
EMAIL = 'EMAIL',
44
SMS = 'SMS',
5-
LETTER = 'LETTER',
65
}
76

87
export enum TemplateStatus {
@@ -15,7 +14,6 @@ export const templateTypeDisplayMappings = (type: TemplateType) =>
1514
[TemplateType.NHS_APP]: 'NHS App message',
1615
[TemplateType.SMS]: 'Text message (SMS)',
1716
[TemplateType.EMAIL]: 'Email',
18-
[TemplateType.LETTER]: 'Letter',
1917
})[type];
2018

2119
export const templateStatustoDisplayMappings = (status: TemplateStatus) =>
@@ -29,5 +27,9 @@ export const templateTypeToUrlTextMappings = (type: TemplateType) =>
2927
[TemplateType.NHS_APP]: 'nhs-app',
3028
[TemplateType.SMS]: 'text-message',
3129
[TemplateType.EMAIL]: 'email',
32-
[TemplateType.LETTER]: 'letter',
3330
})[type];
31+
32+
export const previewTemplatePages = (type: TemplateType) =>
33+
`preview-${templateTypeToUrlTextMappings(type)}-template`;
34+
export const viewSubmittedTemplatePages = (type: TemplateType) =>
35+
`view-submitted-${templateTypeToUrlTextMappings(type)}-template`;

0 commit comments

Comments
 (0)