CCM-11026: typecheck fixes

Author: harrim91

lambdas/backend-api/src/__tests__/templates/app/template-client.test.ts

@@ -1,3 +1,4 @@
+import { File } from 'node:buffer';
 import { randomUUID } from 'node:crypto';
 import { mock } from 'jest-mock-extended';
 import type {

lambdas/backend-api/src/__tests__/templates/domain/template-pdf.test.ts

@@ -7,7 +7,7 @@ import { TemplatePdf } from '@backend-api/templates/domain/template-pdf';
 test('has the given key attributes', () => {
   const pdf = new TemplatePdf(
     { id: 'template-id', owner: 'template-owner' },
-    Buffer.from('')
+    Uint8Array.from('')
   );
 
   expect(pdf.templateId).toBe('template-id');
@@ -20,7 +20,7 @@ test('parse with no custom personalisation', async () => {
   );
   const pdf = new TemplatePdf(
     { id: 'template-id', owner: 'template-owner' },
-    file
+    new Uint8Array(file)
   );
   await pdf.parse();
 
@@ -67,7 +67,7 @@ test('parse with custom personalisation', async () => {
   );
   const pdf = new TemplatePdf(
     { id: 'template-id', owner: 'template-owner' },
-    file
+    new Uint8Array(file)
   );
   await pdf.parse();
 

lambdas/backend-api/src/__tests__/templates/infra/client-config-repository.test.ts

@@ -280,7 +280,7 @@ describe('ClientConfigRepository', () => {
             actualError: expect.objectContaining({
               issues: expect.arrayContaining([
                 expect.objectContaining({
-                  message: 'Invalid input: expected object, received undefined',
+                  message: '"undefined" is not valid JSON',
                 }),
               ]),
             }),
@@ -312,7 +312,7 @@ describe('ClientConfigRepository', () => {
             actualError: expect.objectContaining({
               issues: expect.arrayContaining([
                 expect.objectContaining({
-                  message: 'Invalid input: expected object, received undefined',
+                  message: '"undefined" is not valid JSON',
                 }),
               ]),
             }),

lambdas/backend-api/src/__tests__/templates/infra/letter-upload-repository.test.ts

@@ -1,3 +1,4 @@
+import { Blob, File } from 'node:buffer';
 import {
   GetObjectCommand,
   GetObjectCommandOutput,

lambdas/backend-api/src/templates/app/get-letter-upload-parts.ts

@@ -1,3 +1,4 @@
+import { File } from 'node:buffer';
 import { failure, success } from '@backend-api/utils/result';
 import { ErrorCase, Result } from 'nhs-notify-backend-client';
 import { LETTER_MULTIPART } from 'nhs-notify-backend-client/src/schemas/constants';

lambdas/backend-api/src/templates/app/template-client.ts

@@ -1,3 +1,4 @@
+import type { File } from 'node:buffer';
 import { randomUUID } from 'node:crypto';
 import { failure, success, validate } from '@backend-api/utils/index';
 import {
@@ -22,10 +23,10 @@ import {
 } from 'nhs-notify-web-template-management-utils';
 import { isRightToLeft } from 'nhs-notify-web-template-management-utils/enum';
 import { Logger } from 'nhs-notify-web-template-management-utils/logger';
+import { z } from 'zod/v4';
 import { LetterUploadRepository } from '../infra/letter-upload-repository';
 import { ProofingQueue } from '../infra/proofing-queue';
 import { ClientConfigRepository } from '../infra/client-config-repository';
-import { z } from 'zod/v4';
 
 export class TemplateClient {
   private $LetterForProofing = z.intersection(

lambdas/backend-api/src/templates/domain/template-pdf.ts

@@ -60,7 +60,7 @@ export class TemplatePdf {
     if (!this.parsed) {
       const { getDocument } = await import('pdfjs-dist/legacy/build/pdf.mjs');
 
-      const loading = getDocument(this.source.buffer);
+      const loading = getDocument(this.source);
 
       const document = await loading.promise;
 

lambdas/backend-api/src/templates/infra/letter-upload-repository.ts

@@ -1,3 +1,4 @@
+import type { File } from 'node:buffer';
 import { z } from 'zod/v4';
 import { ErrorCase } from 'nhs-notify-backend-client';
 import type {

scripts/config/pre-commit.yaml

@@ -18,13 +18,10 @@ repos:
       - id: pretty-format-json
         exclude: |
           (?x)^(
-            package-lock.json
-          )$
-        args: ['--autofix']
-        exclude: |
-          (?x)^(
+            package-lock.json|
             packages/event-schemas/schemas/[^/]+/[^/]+\.json
           )$
+        args: ['--autofix']
     # -   id: ...
   - repo: local
     hooks: