Skip to content

Commit 761a35d

Browse files
harrim91harrim91
committed
CCM-9973: remove audio cd and braille letter options
1 parent 632f64e commit 761a35d

File tree

14 files changed

+39
-95
lines changed

14 files changed

+39
-95
lines changed

‎frontend/src/__tests__/components/forms/LetterTemplateForm.test.tsx/LetterTemplateForm.test.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ test('renders page with preloaded field values', () => {
2929
initialState={mockDeep<TemplateFormState<LetterTemplate>>({
3030
validationError: undefined,
3131
name: 'template-name',
32-
letterType: 'q1',
32+
letterType: 'x1',
3333
language: 'ar',
3434
})}
3535
/>

‎frontend/src/__tests__/components/forms/LetterTemplateForm.test.tsx/__snapshots__/LetterTemplateForm.test.tsx.snap‎

Lines changed: 7 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ exports[`Client-side validation triggers 1`] = `
155155
<span
156156
class="nhsuk-u-visually-hidden"
157157
>
158-
Error:
158+
Error:
159159
</span>
160160
Enter a template name
161161
</span>
@@ -190,16 +190,6 @@ exports[`Client-side validation triggers 1`] = `
190190
id="letterTemplateLetterType"
191191
name="letterTemplateLetterType"
192192
>
193-
<option
194-
value="x3"
195-
>
196-
Audio CD
197-
</option>
198-
<option
199-
value="q1"
200-
>
201-
Braille
202-
</option>
203193
<option
204194
value="q4"
205195
>
@@ -419,7 +409,7 @@ exports[`Client-side validation triggers 1`] = `
419409
<span
420410
class="nhsuk-u-visually-hidden"
421411
>
422-
Error:
412+
Error:
423413
</span>
424414
Select a letter template PDF
425415
</span>
@@ -654,7 +644,7 @@ exports[`renders page one error 1`] = `
654644
<span
655645
class="nhsuk-u-visually-hidden"
656646
>
657-
Error:
647+
Error:
658648
</span>
659649
Template name error
660650
</span>
@@ -690,16 +680,6 @@ exports[`renders page one error 1`] = `
690680
id="letterTemplateLetterType"
691681
name="letterTemplateLetterType"
692682
>
693-
<option
694-
value="x3"
695-
>
696-
Audio CD
697-
</option>
698-
<option
699-
value="q1"
700-
>
701-
Braille
702-
</option>
703683
<option
704684
value="q4"
705685
>
@@ -1164,7 +1144,7 @@ exports[`renders page with multiple errors 1`] = `
11641144
<span
11651145
class="nhsuk-u-visually-hidden"
11661146
>
1167-
Error:
1147+
Error:
11681148
</span>
11691149
Template name error
11701150
</span>
@@ -1200,16 +1180,6 @@ exports[`renders page with multiple errors 1`] = `
12001180
id="letterTemplateLetterType"
12011181
name="letterTemplateLetterType"
12021182
>
1203-
<option
1204-
value="x3"
1205-
>
1206-
Audio CD
1207-
</option>
1208-
<option
1209-
value="q1"
1210-
>
1211-
Braille
1212-
</option>
12131183
<option
12141184
value="q4"
12151185
>
@@ -1429,7 +1399,7 @@ exports[`renders page with multiple errors 1`] = `
14291399
<span
14301400
class="nhsuk-u-visually-hidden"
14311401
>
1432-
Error:
1402+
Error:
14331403
</span>
14341404
PDF error
14351405
</span>
@@ -1476,7 +1446,7 @@ exports[`renders page with multiple errors 1`] = `
14761446
<span
14771447
class="nhsuk-u-visually-hidden"
14781448
>
1479-
Error:
1449+
Error:
14801450
</span>
14811451
CSV error
14821452
</span>
@@ -1653,23 +1623,13 @@ exports[`renders page with preloaded field values 1`] = `
16531623
id="letterTemplateLetterType"
16541624
name="letterTemplateLetterType"
16551625
>
1656-
<option
1657-
value="x3"
1658-
>
1659-
Audio CD
1660-
</option>
1661-
<option
1662-
selected=""
1663-
value="q1"
1664-
>
1665-
Braille
1666-
</option>
16671626
<option
16681627
value="q4"
16691628
>
16701629
British Sign Language
16711630
</option>
16721631
<option
1632+
selected=""
16731633
value="x1"
16741634
>
16751635
Large print

‎frontend/src/__tests__/components/forms/LetterTemplateForm.test.tsx/server-action.test.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ describe('CreateLetterTemplate server actions', () => {
4848
id: 'new-template-id',
4949
templateStatus: 'NOT_YET_SUBMITTED',
5050
name: 'template-name',
51-
letterType: 'q1',
51+
letterType: 'x1',
5252
language: 'ar',
5353
files: {
5454
pdfTemplate: {
@@ -77,7 +77,7 @@ describe('CreateLetterTemplate server actions', () => {
7777
initialState,
7878
getMockFormData({
7979
letterTemplateName: 'template-name',
80-
letterTemplateLetterType: 'q1',
80+
letterTemplateLetterType: 'x1',
8181
letterTemplateLanguage: 'ar',
8282
letterTemplatePdf,
8383
letterTemplateCsv,
@@ -88,7 +88,7 @@ describe('CreateLetterTemplate server actions', () => {
8888
{
8989
...initialState,
9090
name: 'template-name',
91-
letterType: 'q1',
91+
letterType: 'x1',
9292
language: 'ar',
9393
},
9494
letterTemplatePdf,
@@ -107,7 +107,7 @@ describe('CreateLetterTemplate server actions', () => {
107107
id: 'new-template-id',
108108
templateStatus: 'NOT_YET_SUBMITTED',
109109
name: 'template-name',
110-
letterType: 'q1',
110+
letterType: 'x1',
111111
language: 'ar',
112112
files: {
113113
pdfTemplate: {
@@ -137,7 +137,7 @@ describe('CreateLetterTemplate server actions', () => {
137137
{ ...initialState, id: 'existing-id' },
138138
getMockFormData({
139139
letterTemplateName: 'template-name',
140-
letterTemplateLetterType: 'q1',
140+
letterTemplateLetterType: 'x1',
141141
letterTemplateLanguage: 'ar',
142142
letterTemplatePdf,
143143
letterTemplateCsv,

‎frontend/src/__tests__/components/organisms/PreviewLetterTemplate.test.tsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ describe('PreviewLetterTemplate component', () => {
1111
id: 'template-id',
1212
templateStatus: 'VIRUS_SCAN_FAILED',
1313
language: 'en',
14-
letterType: 'q1',
14+
letterType: 'x1',
1515
files: {
1616
pdfTemplate: {
1717
fileName: 'file.pdf',
@@ -90,7 +90,7 @@ describe('PreviewLetterTemplate component', () => {
9090
id: 'template-id',
9191
templateStatus: 'VALIDATION_FAILED',
9292
language: 'en',
93-
letterType: 'q1',
93+
letterType: 'x1',
9494
files: {
9595
pdfTemplate: {
9696
fileName: 'file.pdf',
@@ -121,7 +121,7 @@ describe('PreviewLetterTemplate component', () => {
121121
id: 'template-id',
122122
templateStatus: 'PENDING_UPLOAD',
123123
language: 'en',
124-
letterType: 'q1',
124+
letterType: 'x1',
125125
files: {
126126
pdfTemplate: {
127127
fileName: 'file.pdf',
@@ -147,7 +147,7 @@ describe('PreviewLetterTemplate component', () => {
147147
id: 'template-id',
148148
templateStatus: 'PENDING_VALIDATION',
149149
language: 'en',
150-
letterType: 'q1',
150+
letterType: 'x1',
151151
files: {
152152
pdfTemplate: {
153153
fileName: 'file.pdf',

‎frontend/src/__tests__/components/organisms/__snapshots__/PreviewLetterTemplate.test.tsx.snap‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template status i
383383
<dd
384384
class="nhsuk-summary-list__value"
385385
>
386-
Braille letter
386+
Large print letter
387387
</dd>
388388
</div>
389389
<div
@@ -527,7 +527,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template status i
527527
<dd
528528
class="nhsuk-summary-list__value"
529529
>
530-
Braille letter
530+
Large print letter
531531
</dd>
532532
</div>
533533
<div
@@ -653,7 +653,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template status i
653653
<span
654654
class="nhsuk-u-visually-hidden"
655655
>
656-
Error:
656+
Error:
657657
</span>
658658
The personalisation fields in your files are missing or do not match.
659659
</span>
@@ -663,7 +663,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template status i
663663
<span
664664
class="nhsuk-u-visually-hidden"
665665
>
666-
Error:
666+
Error:
667667
</span>
668668
Check that the personalisation fields in your template file match the fields in your test personalisation file
669669
</span>
@@ -705,7 +705,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template status i
705705
<dd
706706
class="nhsuk-summary-list__value"
707707
>
708-
Braille letter
708+
Large print letter
709709
</dd>
710710
</div>
711711
<div
@@ -866,7 +866,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template status i
866866
<span
867867
class="nhsuk-u-visually-hidden"
868868
>
869-
Error:
869+
Error:
870870
</span>
871871
The file(s) you uploaded may contain a virus.
872872
</span>
@@ -876,7 +876,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template status i
876876
<span
877877
class="nhsuk-u-visually-hidden"
878878
>
879-
Error:
879+
Error:
880880
</span>
881881
Create a new letter template to upload your file(s) again or upload different file(s).
882882
</span>
@@ -918,7 +918,7 @@ exports[`PreviewLetterTemplate component matches snapshot when template status i
918918
<dd
919919
class="nhsuk-summary-list__value"
920920
>
921-
Braille letter
921+
Large print letter
922922
</dd>
923923
</div>
924924
<div

‎frontend/src/__tests__/utils/form-actions.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ describe('form-actions', () => {
108108
id: 'new-template-id',
109109
templateStatus: 'NOT_YET_SUBMITTED',
110110
name: 'template-name',
111-
letterType: 'q1',
111+
letterType: 'x1',
112112
language: 'ar',
113113
files: {
114114
pdfTemplate: {
@@ -166,7 +166,7 @@ describe('form-actions', () => {
166166
id: 'new-template-id',
167167
templateStatus: 'NOT_YET_SUBMITTED',
168168
name: 'template-name',
169-
letterType: 'q1',
169+
letterType: 'x1',
170170
language: 'ar',
171171
files: {
172172
pdfTemplate: {
@@ -592,7 +592,7 @@ describe('form-actions', () => {
592592
id: 'new-template-id',
593593
templateStatus: 'NOT_YET_SUBMITTED',
594594
name: 'template-name',
595-
letterType: 'q1',
595+
letterType: 'x1',
596596
language: 'ar',
597597
files: {
598598
pdfTemplate: {

‎infrastructure/terraform/modules/backend-api/spec.tmpl.json‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,11 +227,9 @@
227227
},
228228
"LetterType": {
229229
"enum": [
230-
"q1",
231230
"q4",
232231
"x0",
233-
"x1",
234-
"x3"
232+
"x1"
235233
],
236234
"type": "string"
237235
},

‎lambdas/backend-api/src/__tests__/templates/app/template-client.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -916,7 +916,7 @@ describe('templateClient', () => {
916916
name: 'name',
917917
templateType: 'LETTER',
918918
language: 'it',
919-
letterType: 'q1',
919+
letterType: 'x1',
920920
};
921921

922922
const result = await templateClient.updateTemplate(
@@ -1567,7 +1567,7 @@ describe('templateClient', () => {
15671567
createdAt: new Date().toISOString(),
15681568
updatedAt: new Date().toISOString(),
15691569
personalisationParameters,
1570-
letterType: 'q1',
1570+
letterType: 'x1',
15711571
language: 'en',
15721572
files: {
15731573
pdfTemplate: {
@@ -1632,7 +1632,7 @@ describe('templateClient', () => {
16321632
createdAt: new Date().toISOString(),
16331633
updatedAt: new Date().toISOString(),
16341634
personalisationParameters,
1635-
letterType: 'q1',
1635+
letterType: 'x1',
16361636
language: 'en',
16371637
files: {
16381638
pdfTemplate: {

‎lambdas/backend-client/src/__tests__/schemas/template-schema.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ describe('Template schemas', () => {
164164
test('$CreateUpdateNonLetter should fail when input is a letter', () => {
165165
const letter: CreateUpdateTemplate = {
166166
templateType: 'LETTER',
167-
letterType: 'q1',
167+
letterType: 'x1',
168168
language: 'ar',
169169
name: 'letter',
170170
};

0 commit comments

Comments
 (0)