CCM-11889: allow domain association removal to fail

mark-r-bjss · mark-r-bjss · commit 7672e11b0787 · 2025-12-16T12:11:50.000Z
diff --git a/infrastructure/terraform/components/app/amplify_domain_association.tf b/infrastructure/terraform/components/app/amplify_domain_association.tf
@@ -30,7 +30,8 @@ resource "null_resource" "amplify_domain_association" {
   }
 
   provisioner "local-exec" {
-    when    = destroy
-    command = "aws amplify delete-domain-association --app-id ${self.triggers.amplify_app_id} --domain-name ${self.triggers.amplify_domain_name}"
+    when       = destroy
+    command    = "aws amplify delete-domain-association --app-id ${self.triggers.amplify_app_id} --domain-name ${self.triggers.amplify_domain_name}"
+    on_failure = continue
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,8 @@ resource "null_resource" "amplify_domain_association" {`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`provisioner "local-exec" {`
`33`		`- when = destroy`
`34`		`- command = "aws amplify delete-domain-association --app-id ${self.triggers.amplify_app_id} --domain-name ${self.triggers.amplify_domain_name}"`
	`33`	`+ when = destroy`
	`34`	`+ command = "aws amplify delete-domain-association --app-id ${self.triggers.amplify_app_id} --domain-name ${self.triggers.amplify_domain_name}"`
	`35`	`+ on_failure = continue`
`35`	`36`	`}`
`36`	`37`	`}`