change custom attr name, unsure why its suddenly rejecting colons

Author: alexnuttall

infrastructure/terraform/components/sandbox/aws_cognito_user_pool_sandbox.tf

@@ -9,7 +9,7 @@ resource "aws_cognito_user_pool" "sandbox" {
   }
 
   schema {
-    name                = "sbx:client_id"
+    name                = "sbx_client_id"
     attribute_data_type = "String"
     mutable             = true
     required            = false

lambdas/cognito-triggers/src/__tests__/pre-token-generation.test.ts

@@ -59,7 +59,7 @@ const eventWithCustomAttr = (): PreTokenGenerationV2Event => ({
       email: '[email protected]',
       email_verified: 'True',
       sub: '76c25234-b041-70f2-8ba4-caf538363b35',
-      'custom:sbx:client_id': 'f58d4b65-870c-42c0-8bb6-2941c5be2bec',
+      'custom:sbx_client_id': 'f58d4b65-870c-42c0-8bb6-2941c5be2bec',
     },
   },
   response: {
@@ -71,7 +71,7 @@ const eventWithCustomAttr = (): PreTokenGenerationV2Event => ({
   version: '2',
 });
 
-describe('when user has custom:sbx:client_id attribute', () => {
+describe('when user has custom:sbx_client_id attribute', () => {
   test('adds nhs-notify:client-id claim from custom attribute in event', async () => {
     const result = await new PreTokenGenerationLambda().handler(
       eventWithCustomAttr()

lambdas/cognito-triggers/src/pre-token-generation.ts

@@ -21,7 +21,7 @@ export type PreTokenGenerationV2Event = Omit<
 export class PreTokenGenerationLambda {
   handler = async (event: PreTokenGenerationV2Event) => {
     let response = { ...event };
-    const clientId = event.request.userAttributes['custom:sbx:client_id'];
+    const clientId = event.request.userAttributes['custom:sbx_client_id'];
 
     if (clientId) {
       response = PreTokenGenerationLambda.setTokenClaims(

tests/accessibility/test-user-client.ts

@@ -27,7 +27,7 @@ export class TestUserClient {
             Value: 'true',
           },
           {
-            Name: 'custom:sbx:client_id',
+            Name: 'custom:sbx_client_id',
             Value: clientId,
           },
         ],

tests/test-team/helpers/auth/cognito-auth-helper.ts

@@ -178,7 +178,7 @@ export class CognitoAuthHelper {
     const clientAttribute = userDetails.clientId
       ? [
           {
-            Name: 'custom:sbx:client_id',
+            Name: 'custom:sbx_client_id',
             Value: userDetails.clientId,
           },
         ]